linux-stable.git/drivers/target/target_core_device.c, branch v3.3.2

target: prevent NULL pointer dereference in target_report_luns

2012-04-02T17:32:02+00:00

commit 47f1b8803e1e358ebbf4f82bfdb98971c912a2c3 upstream.

transport_kmap_data_sg can return NULL.  I never saw this trigger, but
returning -ENOMEM seems better than a crash.  Also removes a pointless
case while at it.

Signed-off-by: Joern Engel 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

target: fix use after free in target_report_luns

2012-04-02T17:31:57+00:00

commit 382436f8804fe1cb20b9a2a811a10eb2d8554721 upstream.

Fix possible NULL pointer dereference in target_report_luns failure path.

Signed-off-by: Joern Engel 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

target: Allow control CDBs with data > 1 page

2012-01-18T08:35:58+00:00

We need to handle >1 page control cdbs, so extend the code to do a vmap
if bigger than 1 page. It seems like kmap() is still preferable if just
a page, fewer TLB shootdowns(?), so keep using that when possible.

Rename function pair for their new scope.

Signed-off-by: Andy Grover 
Cc: 
Signed-off-by: Nicholas Bellinger

target: fix return code of core_tpg_.*_lun

2012-01-18T08:33:44+00:00

- core_tpg_pre_addlun()
  returns always ERR_PTR() or the pointer, never NULL. The additional
  check for NULL in core_dev_add_lun() is not required.

- core_tpg_pre_dellun()
  returns always ERR_PTR() or the pointer, never NULL. The check for NULL
  in core_dev_del_lun() is wrong. The third argument (int *) is never
  used, remove it.

- core_dev_add_lun()
  returns always NULL or the pointer, never ERR_PTR. The check for
  IS_ERR() is not required.

(nab: Convert core_dev_add_lun() use err.h macros for failure
handling to be consistent with the rest of target_core_fabric_configfs.c
callers)

Signed-off-by: Sebastian Andrzej Siewior 
Cc: 
Signed-off-by: Nicholas Bellinger

target: use save/restore lock primitive in core_dec_lacl_count()

2012-01-18T08:30:39+00:00

It may happen that uasp will free the request in irq conntext, the
callchain:

 uasp_cmd_release() -> transport_generic_free_cmd() -> core_dec_lacl_count()

where the last function enables the IRQ. Those irqs are re-disabled
later (due to the spin.*irq_restore) but in between we could get hurt.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Nicholas Bellinger

target: Drop se_device TCQ queue_depth usage from I/O path

2011-12-14T11:42:13+00:00

Historically, pSCSI devices have been the ones that required target-core
to enforce a per se_device->depth_left.  This patch changes target-core
to no longer (by default) enforce a per se_device->depth_left or sleep in
transport_tcq_window_closed() when we out of queue slots for all backend
export cases.

Cc: Christoph Hellwig 
Cc: Roland Dreier 
Cc: Joern Engel 
Signed-off-by: Nicholas Bellinger

target: header reshuffle, part2

2011-12-14T11:26:05+00:00

This reorganized the headers under include/target into:

 - target_core_base.h stays as is with all target-wide data stuctures and defines
 - target_core_backend.h contains the whole interface to I/O backends
 - target_core_fabric.h contains the whole interface to fabric modules

Except for those only the various configfs macro headers stay around.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: reshuffle headers

2011-12-14T08:51:12+00:00

Create a new headers, drivers/target/target_core_internal.h that is supposed
to hold all target_core-internal prototypes.  Move all non-exported includes
from include/target to it, and merge the smaller prototype-only includes
inside drivers/target into it as well.  Mark functions that were found to
not be called outside their implementation file static.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: Don't return an error if disabling unsupported features

2011-12-06T06:00:58+00:00

If an attribute is present (but not yet supported) it should be OK
to write 0 (a no-op) to the attribute.

This is an issue because userspace should be able to save and restore all
set attribute values without error.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target: remove the unused se_dev_list

2011-12-06T06:00:57+00:00

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger