linux-stable.git/drivers/target/target_core_device.c, branch linux-3.7.y

target: Fix divide by zero bug in fabric_max_sectors for unconfigured devices

2013-02-27T17:21:24+00:00

commit 7a3cf6ca1ab2a2f7161c6dec5a787fc7a5de864e upstream

This patch fixes a possible divide by zero bug when the fabric_max_sectors
device attribute is written and backend se_device failed to be successfully
configured -> enabled.

Go ahead and use block_size=512 within se_dev_set_fabric_max_sectors()
in the event of a target_configure_device() failure case, as no valid
dev->dev_attrib.block_size value will have been setup yet.

Signed-off-by: Nicholas Bellinger 
Cc: Herton Ronaldo Krzesinski 
Signed-off-by: Greg Kroah-Hartman

target: Add link_magic for fabric allow_link destination target_items

2013-01-21T19:44:44+00:00

commit 0ff8754981261a80f4b77db2536dfea92c2d4539 upstream.

This patch adds [dev,lun]_link_magic value assignment + checks within generic
target_fabric_port_link() and target_fabric_mappedlun_link() code to ensure
destination config_item *target_item sent from configfs_symlink() ->
config_item_operations->allow_link() is the underlying se_device->dev_group
and se_lun->lun_group that we expect to symlink.

Reported-by: Sebastian Andrzej Siewior 
Cc: Sebastian Andrzej Siewior 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: CAI Qian 
Signed-off-by: Greg Kroah-Hartman

target: Avoid integer overflow in se_dev_align_max_sectors()

2012-11-01T07:38:44+00:00

The expression (max_sectors * block_size) might overflow a u32
(indeed, since iblock sets max_hw_sectors to UINT_MAX, it is
guaranteed to overflow and end up with a much-too-small result in many
common cases).  Fix this by doing an equivalent calculation that
doesn't require multiplication.

While we're touching this code, avoid splitting a printk format across
two lines and use pr_info(...) instead of printk(KERN_INFO ...).

Signed-off-by: Roland Dreier 
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger

target: Drop se_subsystem_api->[write_cache,fua_write]_emulated flags

2012-09-18T00:13:34+00:00

This patch drops se_subsystem_api->[write_cache,fua_write]_emulated flags
set by viritual FILEIO/IBLOCK/RD_MCP backend drivers in favor of explict
TRANSPORT_PLUGIN_PHBA_PDEV checks to know when to fail if userspace is
attempting to set virtual emulation bits for an pSCSI (passthrough)
backend device.

Reported-by: Christoph Hellwig 
Cc: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: Fix minor spelling typos in drivers/target

2012-09-18T00:13:31+00:00

Correct spelling typo in printk and comment within drivers/target.

Signed-off-by: Masanari Iida 
Signed-off-by: Nicholas Bellinger

target: fail REPORT LUNS with less than 16 bytes of payload

2012-09-07T18:09:14+00:00

SPC says:

"The ALLOCATION LENGTH field is defined in 4.3.5.6. The allocation length
should be at least 16.  Device servers compliant with SPC return CHECK
CONDITION status, with the sense key set to ILLEGAL REQUEST, and the
additional sense code set to INVALID FIELD IN CDB when the allocation
length is less than 16 bytes".

Testcase: sg_raw -r8 /dev/sdb a0 00 00 00 00 00 00 00 00 08 00 00
    should fail with ILLEGAL REQUEST / INVALID FIELD IN CDB sense
    does not fail without the patch
    fails correctly with the patch

Signed-off-by: Paolo Bonzini 
Signed-off-by: Nicholas Bellinger

target: Make unnecessarily global se_dev_align_max_sectors() static

2012-07-17T00:35:35+00:00

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

target: Make core_disable_device_list_for_node use pre-refactoring lock ordering

2012-07-17T00:35:24+00:00

So after kicking around commit 547ac4c9c90 around a bit more, a tcm_qla2xxx LUN
unlink OP has generated the following warning:

[   50.386625] qla2xxx [0000:07:00.0]-00af:0: Performing ISP error recovery - ha=ffff880263774000.
[   70.572988] qla2xxx [0000:07:00.0]-8038:0: Cable is unplugged...
[  126.527531] ------------[ cut here ]------------
[  126.532677] WARNING: at kernel/softirq.c:159 local_bh_enable_ip+0x41/0x8c()
[  126.540433] Hardware name: S5520HC
[  126.544248] Modules linked in: tcm_vhost ib_srpt ib_cm ib_sa ib_mad ib_core tcm_qla2xxx tcm_loop tcm_fc libfc iscsi_target_mod target_core_pscsi target_core_file target_core_iblock target_core_mod configfs ipv6 iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi dm_round_robin dm_multipath scsi_dh loop i2c_i801 kvm_intel kvm crc32c_intel i2c_core microcode joydev button iomemory_vsl(O) pcspkr ext3 jbd uhci_hcd lpfc ata_piix libata ehci_hcd qla2xxx mlx4_core scsi_transport_fc scsi_tgt igb [last unloaded: scsi_wait_scan]
[  126.595567] Pid: 3283, comm: unlink Tainted: G           O 3.5.0-rc2+ #33
[  126.603128] Call Trace:
[  126.605853]  [] ? warn_slowpath_common+0x78/0x8c
[  126.612737]  [] ? local_bh_enable_ip+0x41/0x8c
[  126.619433]  [] ? core_disable_device_list_for_node+0x70/0xe3 [target_core_mod]
[  126.629323]  [] ? core_clear_lun_from_tpg+0x88/0xeb [target_core_mod]
[  126.638244]  [] ? core_tpg_post_dellun+0x17/0x48 [target_core_mod]
[  126.646873]  [] ? core_dev_del_lun+0x26/0x8c [target_core_mod]
[  126.655114]  [] ? dput+0x27/0x154
[  126.660549]  [] ? target_fabric_port_unlink+0x3b/0x41 [target_core_mod]
[  126.669661]  [] ? configfs_unlink+0xfc/0x14a [configfs]
[  126.677224]  [] ? vfs_unlink+0x58/0xb7
[  126.683141]  [] ? do_unlinkat+0xbb/0x142
[  126.689253]  [] ? page_fault+0x25/0x30
[  126.695170]  [] ? system_call_fastpath+0x16/0x1b
[  126.702053] ---[ end trace 2f8e5b0a9ec797ef ]---
[  126.756336] qla2xxx [0000:07:00.0]-00af:0: Performing ISP error recovery - ha=ffff880263774000.
[  146.942414] qla2xxx [0000:07:00.0]-8038:0: Cable is unplugged...

So this warning triggered because device_list disable logic is now
holding nacl->device_list_lock w/ spin_lock_irqsave before obtaining
port->sep_alua_lock with only spin_lock_bh..

The original disable logic obtains *deve ahead of dropping the entry
from deve->alua_port_list and then obtains ->device_list_lock to do the
remaining work.  Also, I'm pretty sure this particular warning is being
generated by a demo-mode session in tcm_qla2xxx, and not by explicit
NodeACL MappedLUNs.  The Initiator MappedLUNs are already protected by a
seperate configfs symlink reference back se_lun->lun_group, and the
demo-mode se_node_acl (and associated ->device_list[]) is released
during se_portal_group->tpg_group shutdown.

The following patch drops the extra functional change to disable logic
in commit 547ac4c9c90

Cc: Andy Grover 
Signed-off-by: Nicholas Bellinger

target: refactor core_update_device_list_for_node()

2012-07-17T00:35:24+00:00

Code was almost entirely divided based on value of bool param "enable".

Split it into two functions.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target: Remove hba param from core_dev_add_lun

2012-07-17T00:35:22+00:00

Only used in a debugprint, and function signature is cleaner now.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger