linux-stable.git/drivers/target/sbp, branch linux-3.7.y

sbp-target: fix error path in sbp_make_tpg()

2013-01-17T16:45:58+00:00

commit e1fe2060d7e8f58a69374135e32e90f0bb79a7fd upstream.

If the TPG memory is allocated successfully, but we fail further along
in the function, a dangling pointer to freed memory is left in the TPort
structure. This is mostly harmless, but does prevent re-trying the
operation without first removing the TPort altogether.

Reported-by: Chen Gang 
Signed-off-by: Chris Boot 
Cc: Andy Grover 
Cc: Nicholas A. Bellinger 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

sbp-target: fix return value check in sbp_register_configfs()

2012-09-22T23:29:52+00:00

In case of error, the function target_fabric_configfs_init() returns
ERR_PTR() not NULL pointer. The NULL test in the return value check
should be replaced with IS_ERR().

dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun 
Signed-off-by: Nicholas Bellinger

target: use list_move_tail instead of list_del/list_add_tail

2012-09-18T00:13:36+00:00

Using list_move_tail() instead of list_del() + list_add_tail().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun 
Signed-off-by: Nicholas Bellinger

target: Simplify fabric sense data length handling

2012-09-18T00:12:58+00:00

Every fabric driver has to supply a se_tfo->set_fabric_sense_len()
method, just so iSCSI can return an offset of 2.  However, every fabric
driver is already allocating a sense buffer and passing it into the
target core, either via transport_init_se_cmd() or target_submit_cmd().

So instead of having iSCSI pass the start of its sense buffer into the
core and then later tell the core to skip the first 2 bytes, it seems
easier for iSCSI just to do the offset of 2 when it passes the sense
buffer into the core.  Then we can drop the se_tfo->set_fabric_sense_len()
everywhere, and just add a couple of lines of code to iSCSI to set the
sense data length to the beginning of the buffer right before it sends
it over the network.

(nab: Remove .set_fabric_sense_len usage from tcm_qla2xxx_npiv_ops +
      change transport_get_sense_buffer to follow v3.6-rc6 code w/o
      ->set_fabric_sense_len usage)

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

target: Remove unused target_core_fabric_ops.get_fabric_sense_len method

2012-09-17T23:15:47+00:00

There are no callers of se_tfo->get_fabric_sense_len(), so we should
stop having every fabric driver implement it.

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

target/sbp: Remove strict param from sbp_parse_wwn

2012-09-17T23:15:47+00:00

It's always set, and controls whether uppercase A-F are allowed hex values.
I don't see a reason not to accept these.

Signed-off-by: Andy Grover 
Cc: Chris Boot 
Signed-off-by: Nicholas Bellinger

target: Allow for target_submit_cmd() returning errors

2012-07-18T00:05:05+00:00

We want it to be possible for target_submit_cmd() to return errors up
to its fabric module callers.  For now just update the prototype to
return an int, and update all callers to handle non-zero return values
as an error.

This is immediately useful for tcm_qla2xxx to fix a long-standing active
I/O session shutdown race, but tcm_fc, usb-gadget, and sbp-target the
fabric maintainers need to check + ACK that handling a target_submit_cmd()
failure due to session shutdown does not introduce regressions

(nab: Respin against for-next after initial NACK + update docbook comment +
      fix double se_cmd init in exception path for usb-gadget)

Cc: Chad Dupuis 
Cc: Arun Easi 
Cc: Chris Boot 
Cc: Stefan Richter 
Cc: Mark Rustad 
Cc: Sebastian Andrzej Siewior 
Cc: Felipe Balbi 
Cc: Andy Grover 
Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

sbp-target: Consolidate duplicated error path code in sbp_handle_command()

2012-07-17T00:35:26+00:00

Cc: Chris Boot 
Cc: Stefan Richter 
Signed-off-by: Roland Dreier

target: remove transport_generic_process_write

2012-07-17T00:35:16+00:00

Just call target_execute_cmd directly.  Also, convert loopback, sbp,
usb-gadget to use the newly exported target_execute_cmd().

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

sbp-target: rename a variable to avoid name clash

2012-05-30T23:15:33+00:00

'int login_id' shadows 'static atomic_t login_id'.
Seen as compilation warning on x86-32.

Signed-off-by: Stefan Richter 
Acked-by: Chris Boot 
Signed-off-by: Nicholas Bellinger