linux-stable.git/drivers/target/iscsi, branch v3.3

iscsi-target: Fix reservation conflict -EBUSY response handling bug

2012-03-14T04:43:58+00:00

This patch addresses a iscsi-target specific bug related to reservation conflict
handling in iscsit_handle_scsi_cmd() that has been causing reservation conflicts
to complete and not fail as expected due to incorrect errno checking.  The problem
occured with the change to return -EBUSY from transport_generic_cmd_sequencer() ->
transport_generic_allocate_tasks() failures, that broke iscsit_handle_scsi_cmd()
checking for -EINVAL in order to invoke a non GOOD status response.

This was manifesting itself as data corruption with legacy SPC-2 reservations,
but also effects iscsi-target LUNs with SPC-3 persistent reservations.

This bug was originally introduced in lio-core commit:

commit 03e98c9eb916f3f0868c1dc344dde2a60287ff72
Author: Nicholas Bellinger 
Date:   Fri Nov 4 02:36:16 2011 -0700

    target: Address legacy PYX_TRANSPORT_* return code breakage

Reported-by: Martin Svec 
Cc: Martin Svec 
Cc: Christoph Hellwig 
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger

iscsi: use IP_FREEBIND socket option

2012-02-07T06:48:53+00:00

Use IP_FREEBIND socket option so that iscsi portal configuration with
explicit IP addresses can happen during boot, before network interfaces
have been assigned IPs.

This is especially important on systemd based Linux boxes where system
boot happens asynchronously and non-trivial configuration must be done
to get targetcli.service to start synchronously after the network is
configured.

Reference:
http://lists.fedoraproject.org/pipermail/devel/2011-October/158025.html

Signed-off-by: Dax Kelson 
Cc: "Nicholas A. Bellinger" 
Cc: "Andy Grover" 
Cc: "Lennart Poettering" 
Signed-off-by: Nicholas Bellinger

iscsi_target: in_aton needs linux/inet.h

2012-02-07T06:48:30+00:00

Fixes this error after a recent nfs cleanup:

drivers/target/iscsi/iscsi_target_configfs.c: In function 'lio_target_call_addnptotpg':
drivers/target/iscsi/iscsi_target_configfs.c:214:3: error: implicit declaration of function 'in6_pton' [-Werror=implicit-function-declaration]
drivers/target/iscsi/iscsi_target_configfs.c:239:3: error: implicit declaration of function 'in_aton' [-Werror=implicit-function-declaration]

Signed-off-by: Stephen Rothwell 
Signed-off-by: Nicholas Bellinger

iscsi-target: Fix discovery with INADDR_ANY and IN6ADDR_ANY_INIT

2012-01-18T08:35:58+00:00

This patch addresses a bug with sendtargets discovery where INADDR_ANY (0.0.0.0)
+ IN6ADDR_ANY_INIT ([0:0:0:0:0:0:0:0]) network portals where incorrectly being
reported back to initiators instead of the address of the connecting interface.
To address this, save local socket ->getname() output during iscsi login setup,
and makes iscsit_build_sendtargets_response() return these TargetAddress keys
when INADDR_ANY or IN6ADDR_ANY_INIT portals are in use.

Reported-by: Dax Kelson 
Reported-by: Andy Grover 
Cc: David S. Miller 
Cc: 
Signed-off-by: Nicholas Bellinger

iscsi-target: Fix up a few assignments

2012-01-18T08:35:57+00:00

A statement such as
  struct iscsi_node_attrib *na = na = iscsit_tpg_get_node_attrib(sess);
has undefined behaviour since there are two assignments to 'na', strictly
speaking (the order in which side-effects from the assignments take place
is undefined since there's no intervening sequence point), and it looks
unintentional in any case.

Signed-off-by: Jesper Juhl 
Signed-off-by: Nicholas Bellinger

iscsi-target: make one-bit bitfields unsigned

2012-01-18T08:35:57+00:00

Signed bitfields are a problem because instead of being 1 or 0 like
you'd expect they are 0 and -1.  It doesn't cause a problem in this case
but sparse complains:

drivers/target/iscsi/iscsi_target_core.h:564:56: error: dubious one-bit
signed bitfield

Signed-off-by: Dan Carpenter 
Signed-off-by: Nicholas Bellinger

iscsi-target: Fix double list_add with iscsit_alloc_buffs reject

2012-01-18T08:35:57+00:00

This patch fixes a bug where the iscsit_add_reject_from_cmd() call
from a failure to iscsit_alloc_buffs() was incorrectly passing
add_to_conn=1 and causing a double list_add after iscsi_cmd->i_list
had already been added in iscsit_handle_scsi_cmd().

Cc: 
Signed-off-by: Nicholas Bellinger

iscsi-target: Fix reject release handling in iscsit_free_cmd()

2012-01-18T08:35:56+00:00

This patch addresses a bug where iscsit_free_cmd() was incorrectly calling
iscsit_release_cmd() for ISCSI_OP_REJECT because iscsi_add_reject*() will
overwrite the original iscsi_cmd->iscsi_opcode assignment.  This bug was
introduced with the following commit:

commit 0be67f2ed8f577d2c72d917928394c5885fa9134
Author: Nicholas Bellinger 
Date:   Sun Oct 9 01:48:14 2011 -0700

    iscsi-target: Remove SCF_SE_LUN_CMD flag abuses

and was manifesting itself as list corruption with the following:

[  131.191092] ------------[ cut here ]------------
[  131.191092] WARNING: at lib/list_debug.c:53 __list_del_entry+0x8d/0x98()
[  131.191092] Hardware name: VMware Virtual Platform
[  131.191092] list_del corruption. prev->next should be ffff880022d3c100, but was 6b6b6b6b6b6b6b6b
[  131.191092] Modules linked in: tcm_vhost ib_srpt ib_cm ib_sa ib_mad ib_core tcm_qla2xxx qla2xxx tcm_loop tcm_fc libfc scsi_transport_fc crc32c iscsi_target_mod target_core_stgt scsi_tgt target_core_pscsi target_core_file target_core_iblock target_core_mod configfs ipv6 iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi sr_mod cdrom sd_mod e1000 ata_piix libata mptspi mptscsih mptbase [last unloaded: scsi_wait_scan]
[  131.191092] Pid: 2250, comm: iscsi_ttx Tainted: G        W    3.2.0-rc4+ #42
[  131.191092] Call Trace:
[  131.191092]  [] warn_slowpath_common+0x80/0x98
[  131.191092]  [] warn_slowpath_fmt+0x41/0x43
[  131.191092]  [] __list_del_entry+0x8d/0x98
[  131.191092]  [] transport_lun_remove_cmd+0x9b/0xb7 [target_core_mod]
[  131.191092]  [] transport_generic_free_cmd+0x5d/0x71 [target_core_mod]
[  131.191092]  [] iscsit_free_cmd+0x1e/0x27 [iscsi_target_mod]
[  131.191092]  [] iscsit_close_connection+0x14d/0x5b2 [iscsi_target_mod]
[  131.191092]  [] iscsit_take_action_for_connection_exit+0xdb/0xe0 [iscsi_target_mod]
[  131.191092]  [] iscsi_target_tx_thread+0x15cb/0x1608 [iscsi_target_mod]
[  131.191092]  [] ? check_preempt_wakeup+0x121/0x185
[  131.191092]  [] ? __dequeue_entity+0x2e/0x33
[  131.191092]  [] ? iscsit_send_text_rsp+0x25f/0x25f [iscsi_target_mod]
[  131.191092]  [] ? iscsit_send_text_rsp+0x25f/0x25f [iscsi_target_mod]
[  131.191092]  [] ? schedule+0x55/0x57
[  131.191092]  [] kthread+0x7d/0x85
[  131.191092]  [] kernel_thread_helper+0x4/0x10
[  131.191092]  [] ? kthread_worker_fn+0x16d/0x16d
[  131.191092]  [] ? gs_change+0x13/0x13

Reported-by: 
Cc: 
Signed-off-by: Nicholas Bellinger

iscsi-target: fix chap identifier simple_strtoul usage

2011-12-14T11:28:09+00:00

This patch makes chap_server_compute_md5() use proper unsigned long
usage for the CHAP_I (identifier) and check for values beyond 255 as
per RFC-1994.

Reported-by: Joern Engel 
Signed-off-by: Nicholas Bellinger

target: remove useless casts

2011-12-14T11:28:07+00:00

A reader should spend an extra moment whenever noticing a cast,
because either something special is going on that deserves extra
attention or, as is all too often the case, the code is wrong.

These casts, afaics, have all been useless.  They cast a foo* to a
foo*, cast a void* to the assigned type, cast a foo* to void*, before
assigning it to a void* variable, etc.

In a few cases I also removed an additional &...[0], which is equally
useless.

Lastly I added three FIXMEs where, to the best of my judgement, the
code appears to have a bug.  It would be good if someone could check
these.

Signed-off-by: Joern Engel 
Signed-off-by: Nicholas Bellinger