linux-stable.git/drivers/staging/wlan-ng, branch master

staging: wlan-ng: Remove broken driver prism2_usb

2024-03-26T16:04:49+00:00

Driver has a throughput of 200 to 800kByte/s in non encrypted
transmission. All encrypted modes are not working. WLAN without WPA2 is
useless these days. Driver is unused since April 2021 as a bug broke the
function. Find fix for bug in link below. Remove driver because of its
low performance and unusability.

Link: https://lore.kernel.org/linux-staging/5fa18cb8-3c51-4ac6-811e-63ae74f82f17@gmail.com/
Signed-off-by: Philipp Hortmann 
Link: https://lore.kernel.org/r/20240326084742.GA16228@matrix-ESPRIMO-P710
Signed-off-by: Greg Kroah-Hartman

staging: wlan-ng: Rename 'wlan_unsetup' to 'wlan_teardown'

2024-03-25T18:08:08+00:00

Rename function identifier 'wlan_unsetup' to 'wlan_teardown' in files
p80211netdev.c, p80211netdev.h and prism2usb.c, a pairing function for
'wlan_setup' to match common kernel coding style.

Signed-off-by: Felix N. Kimbu 
Reviewed-by: Dan Carpenter 
Link: https://lore.kernel.org/r/ZfGG093fyjI4G/ci@MOLeToid
Signed-off-by: Greg Kroah-Hartman

staging: wlan-ng: Rename 'foo' to 'rc' in p80211conv.c

2024-03-25T18:08:01+00:00

Rename identifier 'foo' to 'rc' in skb_p80211_to_ether() and
skb_ether_to_p80211() to match the common kernel coding style.

Signed-off-by: Felix N. Kimbu 
Reviewed-by: Dan Carpenter 
Link: https://lore.kernel.org/r/ZfEvTF7qwYZORGsY@MOLeToid
Signed-off-by: Greg Kroah-Hartman

staging: wlan-ng: remove function prism2sta_ev_txexc

2023-10-17T13:43:52+00:00

The function prism2sta_ev_txexc() is called by the function
hfa384x_usbin_txcompl() to print the transmit exception event - a debug
information using netdev_dbg().

The debugging utility function can be called directly by
hfa384x_usbin_txcompl().

Signed-off-by: Calvince Otieno 
Link: https://lore.kernel.org/r/ZS5eKFCfu7sGOCHL@lab-ubuntu
Signed-off-by: Greg Kroah-Hartman

staging: wlan-ng: use netdev_dbg over pr_debug

2023-10-17T13:43:42+00:00

This patch replaces the usage of pr_debug() with netdev_dbg().
The change is made to enhance context-aware debugging,
improve code clarity, and maintain compatibility with established
network debugging practices. There were no functional code changes.

Signed-off-by: Calvince Otieno 
Link: https://lore.kernel.org/r/ZS5RSsaNvOvshNj6@lab-ubuntu
Signed-off-by: Greg Kroah-Hartman

staging: wlan-ng: replace pr_debug() with netdev_dbg()

2023-10-16T15:54:04+00:00

This patch replaces the usage of pr_debug() with netdev_dbg().
The change is made to enhance context-aware debugging,
improve code clarity, and maintain compatibility with established
network debugging practices. There were no functional code changes.

Signed-off-by: Calvince Otieno 
Link: https://lore.kernel.org/r/ZS0AZahhusLoN4b/@lab-ubuntu
Signed-off-by: Greg Kroah-Hartman

staging: wlan-ng: replace strncpy() with strscpy()

2023-10-16T15:53:49+00:00

Checkpatch suggests the use of strscpy() instead of strncpy().
The advantages are that it always adds a NUL terminator and it prevents
a read overflow if the src string is not properly terminated. One
potential disadvantage is that it doesn't zero pad the string like
strncpy() does.
In this code, strscpy() and strncpy() are equivalent and it does not
affect runtime behavior. The string is zeroed on the line before
using memset(). The resulting string was always NUL terminated and
PRISM2_USB_FWFILE is string literal "prism2_ru.fw" so it's NUL
terminated.
However, even though using strscpy() does not fix any bugs, it's
still nicer and makes checkpatch happy.

Signed-off-by: Calvince Otieno 
Reviewed-by: Dan Carpenter 
Link: https://lore.kernel.org/r/ZSzapU+eKWvHVwxi@lab-ubuntu
Signed-off-by: Greg Kroah-Hartman

staging: wlan-ng: remove undefined function

2023-10-16T15:53:38+00:00

The function p80211wext_get_wireless_stats() is declared in the code
but has neither been defined nor referenced.

It's definition was removed 13 years ago in the
commit cb3126e60ffc ("Staging: wlan-ng: Switch from wext to cfg80211")

Signed-off-by: Calvince Otieno 
Link: https://lore.kernel.org/r/ZSzphFeckE7dM5g/@lab-ubuntu
Signed-off-by: Greg Kroah-Hartman

staging: wlan-ng: remove unnecessary helper function

2023-10-16T15:53:25+00:00

The function prism2sta_inf_handover() is called by the parent
function prism2sta_ev_info() to print a literal debug information
string using pr_debug(). The debugging utility function can be called
directly within prism2sta_ev_info().

Furthermore, to make the debugging more module-specific, the netdev_dbg()
function is preferred over the generic pr_debug() utility function.

Signed-off-by: Calvince Otieno 
Link: https://lore.kernel.org/r/ZSzJuwlEKPBj9kLN@lab-ubuntu
Signed-off-by: Greg Kroah-Hartman

staging: wlan-ng: remove unused function prototypes

2023-10-16T15:53:16+00:00

These functions are declared but not defined or used anywhere. Their
definitions were removed 15 years ago.

prism2mgmt_set_grpaddr() was removed in the
commit 1e7201836c57 ("Staging: wlan-ng: Delete a pile of unused mibs.
And fix WEXT SET_TXPOWER.")
It's signature was changed in the commit 5a2214e2e02f ("staging:
wlang-ng: avoid new typedef: hfa384x_t")

prism2mgmt_get_grpaddr() and prism2mgmt_get_grpaddr_index() were
removed in the commit cbec30c4c00c ("Staging: wlan-ng: Delete a large pile of
now-unused code.")

Signed-off-by: Calvince Otieno 
Link: https://lore.kernel.org/r/ZSxFS8EnFr998PqS@lab-ubuntu
Signed-off-by: Greg Kroah-Hartman