linux-stable.git/drivers/staging/vt6655, branch v5.0

cross-tree: phase out dma_zalloc_coherent()

2019-01-08T12:58:37+00:00

We already need to zero out memory for dma_alloc_coherent(), as such
using dma_zalloc_coherent() is superflous. Phase it out.

This change was generated with the following Coccinelle SmPL patch:

@ replace_dma_zalloc_coherent @
expression dev, size, data, handle, flags;
@@

-dma_zalloc_coherent(dev, size, handle, flags)
+dma_alloc_coherent(dev, size, handle, flags)

Suggested-by: Christoph Hellwig 
Signed-off-by: Luis Chamberlain 
[hch: re-ran the script on the latest tree]
Signed-off-by: Christoph Hellwig

staging: vt6655: fix small typo

2018-11-07T12:07:26+00:00

Correct spelling mistakes of "Calculate"

Signed-off-by: Yangtao Li 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Remove space after cast

2018-10-09T12:59:58+00:00

Remove space after cast to fix checkpatch issue.
CHECK: No space is necessary after a cast

Signed-off-by: Mamta Shukla 
Reviewed-by: Himanshu Jha 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Add spaces around operators

2018-10-09T12:59:58+00:00

Add spaces around '*' and '-' to fix checkpatch issue.

Signed-off-by: Mamta Shukla 
Reviewed-by: Himanshu Jha 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Add blank line after function/struct/union/enum declarations

2018-10-09T12:59:58+00:00

Add blank line after function/struct/union/enum declarations to fix
checkpatch issue.
CHECK: Please use a blank line after function/struct/union/enum
declarations

Signed-off-by: Mamta Shukla 
Reviewed-by: Himanshu Jha 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: remove some redundant variables

2018-07-11T12:47:08+00:00

Variables rx_sts, sq, frame and is_pspoll are being assigned but are
never used hence they are redundant and can be removed.

Cleans up clang warnings:
warning: variable 'sq' set but not used [-Wunused-but-set-variable]
warning: variable 'rx_sts' set but not used [-Wunused-but-set-variable]
warning: variable 'frame' set but not used [-Wunused-but-set-variable]
warning: variable 'is_pspoll' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: remove unnecessary line breaks in function definition.

2018-04-23T13:23:36+00:00

This patch corrects the function definition style of CARDvSafeResetRx.
Issue found by checkpatch.

CHECK: Lines should not end with a '('

Signed-off-by: Danilo Alves 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: add handling memory leak on vnt_start()

2018-04-23T13:23:36+00:00

There was no code for handling memory leaks of device_init_rings() and
request_irq(). It needs to free allocated memory in the device_init_rings()
, when request_irq() would be failed. Add freeing sequences of irq and
device init rings.

Signed-off-by: Ji-Hun Kim 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: check for memory allocation failures

2018-04-23T13:23:36+00:00

There are no null pointer checking on rd_info and td_info values which
are allocated by kzalloc. It has potential null pointer dereferencing
issues. Implement error handling code on device_init_rd*, device_init_td*
and vnt_start for the allocation failures.

Signed-off-by: Ji-Hun Kim 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Delete unused typedef enum _chip_type

2018-03-28T11:57:44+00:00

Delete unused typedef enum _chip_type.

Signed-off-by: Nishka Dasgupta 
Acked-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman