linux-stable.git/drivers/staging/vt6655, branch linux-5.15.y Linux kernel stable tree staging: vt6655: fix potential memory leak 2022-10-26T10:35:47+00:00 Nam Cao namcaov@gmail.com 2022-09-09T14:13:39+00:00 ff8551d411f12b5abc5ca929ab87643afa8a9588 [ Upstream commit c8ff91535880d41b49699b3829fb6151942de29e ] In function device_init_td0_ring, memory is allocated for member td_info of priv->apTD0Rings[i], with i increasing from 0. In case of allocation failure, the memory is freed in reversed order, with i decreasing to 0. However, the case i=0 is left out and thus memory is leaked. Modify the memory freeing loop to include the case i=0. Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Signed-off-by: Nam Cao <namcaov@gmail.com> Link: https://lore.kernel.org/r/20220909141338.19343-1-namcaov@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org> 
[ Upstream commit c8ff91535880d41b49699b3829fb6151942de29e ]

In function device_init_td0_ring, memory is allocated for member
td_info of priv->apTD0Rings[i], with i increasing from 0. In case of
allocation failure, the memory is freed in reversed order, with i
decreasing to 0. However, the case i=0 is left out and thus memory is
leaked.

Modify the memory freeing loop to include the case i=0.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Signed-off-by: Nam Cao <namcaov@gmail.com>
Link: https://lore.kernel.org/r/20220909141338.19343-1-namcaov@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
staging: vt6655: fix some erroneous memory clean-up loops 2022-10-26T10:35:14+00:00 Nam Cao namcaov@gmail.com 2022-09-12T17:04:31+00:00 f19e5b7df54590c831f350381963f25585c8f7d5 [ Upstream commit 2a2db520e3ca5aafba7c211abfd397666c9b5f9d ] In some initialization functions of this driver, memory is allocated with 'i' acting as an index variable and increasing from 0. The commit in "Fixes" introduces some clean-up codes in case of allocation failure, which free memory in reverse order with 'i' decreasing to 0. However, there are some problems: - The case i=0 is left out. Thus memory is leaked. - In case memory allocation fails right from the start, the memory freeing loops will start with i=-1 and invalid memory locations will be accessed. One of these loops has been fixed in commit c8ff91535880 ("staging: vt6655: fix potential memory leak"). Fix the remaining erroneous loops. Link: https://lore.kernel.org/linux-staging/Yx9H1zSpxmNqx6Xc@kadam/ Fixes: 5341ee0adb17 ("staging: vt6655: check for memory allocation failures") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Signed-off-by: Nam Cao <namcaov@gmail.com> Link: https://lore.kernel.org/r/20220912170429.29852-1-namcaov@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org> 
[ Upstream commit 2a2db520e3ca5aafba7c211abfd397666c9b5f9d ]

In some initialization functions of this driver, memory is allocated with
'i' acting as an index variable and increasing from 0. The commit in
"Fixes" introduces some clean-up codes in case of allocation failure,
which free memory in reverse order with 'i' decreasing to 0. However,
there are some problems:
  - The case i=0 is left out. Thus memory is leaked.
  - In case memory allocation fails right from the start, the memory
    freeing loops will start with i=-1 and invalid memory locations will
    be accessed.

One of these loops has been fixed in commit c8ff91535880 ("staging:
vt6655: fix potential memory leak"). Fix the remaining erroneous loops.

Link: https://lore.kernel.org/linux-staging/Yx9H1zSpxmNqx6Xc@kadam/
Fixes: 5341ee0adb17 ("staging: vt6655: check for memory allocation failures")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Signed-off-by: Nam Cao <namcaov@gmail.com>
Link: https://lore.kernel.org/r/20220912170429.29852-1-namcaov@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
staging: vt6655: Remove filenames in files 2021-08-28T07:45:10+00:00 Aldas Taraškevičius aldas60@gmail.com 2021-08-28T07:21:19+00:00 4adb389e08c95fdf91995271932c59250ff0d561 Fix checkpatch warnings about having filenames in the files. Signed-off-by: Aldas Taraškevičius <aldas60@gmail.com> Link: https://lore.kernel.org/r/20210828072119.1395-1-aldas60@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fix checkpatch warnings about having filenames in the files.

Signed-off-by: Aldas Taraškevičius <aldas60@gmail.com>
Link: https://lore.kernel.org/r/20210828072119.1395-1-aldas60@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt665X: remove unused CONFIG_PATH 2021-07-30T08:20:53+00:00 Greg Kroah-Hartman gregkh@linuxfoundation.org 2021-07-29T09:58:12+00:00 ece42658c85df4c2d6c9b3ddb116003a2de4ecef The vt6655 and vt6656 drivers have an unused CONFIG_PATH define floating around in the code, but it is never used. Remove it as drivers should never be reading from config files anyway, even if these were valid files. Reported-by: Joe Perches <joe@perches.com> Reported-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Randy Dunlap <rdunlap@infradead.org> Link: https://lore.kernel.org/r/20210729095812.1693061-1-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The vt6655 and vt6656 drivers have an unused CONFIG_PATH define floating
around in the code, but it is never used.  Remove it as drivers should
never be reading from config files anyway, even if these were valid
files.

Reported-by: Joe Perches <joe@perches.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20210729095812.1693061-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6655: remove filename from upc.h 2021-07-27T13:22:15+00:00 Lucas Henneman lucas.henneman@linaro.org 2021-07-23T14:43:40+00:00 050cbd980e6bc882b8c2a6e954ada48cbd5ce5c2 This patch resolves checkpatch's warning, "It's generally not useful to have the filename in the file" for upc.h. Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org> Link: https://lore.kernel.org/r/20210723144340.15787-15-lucas.henneman@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for upc.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-15-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6655: remove filename from mac.h 2021-07-27T13:22:15+00:00 Lucas Henneman lucas.henneman@linaro.org 2021-07-23T14:43:39+00:00 ed0b62a568d13c8418a930bb4b36cbfc52f8f39b This patch resolves checkpatch's warning, "It's generally not useful to have the filename in the file" for mac.c. Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org> Link: https://lore.kernel.org/r/20210723144340.15787-14-lucas.henneman@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for mac.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-14-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6655: kernel style cleanup of mac.c 2021-07-27T13:22:15+00:00 Lucas Henneman lucas.henneman@linaro.org 2021-07-23T14:43:38+00:00 290262b9198d9731e285315056ff4c087f6d92d4 This patch removes from mac.c the file name and an ftrace-like pr_debug per checkpatch's two warnings. Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org> Link: https://lore.kernel.org/r/20210723144340.15787-13-lucas.henneman@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch removes from mac.c the file name and an ftrace-like pr_debug
per checkpatch's two warnings.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-13-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6655: remove filename from key.h 2021-07-27T13:22:15+00:00 Lucas Henneman lucas.henneman@linaro.org 2021-07-23T14:43:37+00:00 56bfb9bc6cd1e4e91ce4376018e361223b737353 This patch resolves checkpatch's warning, "It's generally not useful to have the filename in the file" for key.h. Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org> Link: https://lore.kernel.org/r/20210723144340.15787-12-lucas.henneman@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for key.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-12-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6655: remove filename from key.c 2021-07-27T13:22:15+00:00 Lucas Henneman lucas.henneman@linaro.org 2021-07-23T14:43:36+00:00 692b3e44b7afe2c3c348cd20edfa0a5336f13b54 This patch resolves checkpatch's warning, "It's generally not useful to have the filename in the file" for key.c. Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org> Link: https://lore.kernel.org/r/20210723144340.15787-11-lucas.henneman@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for key.c.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-11-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: vt6655: remove filename from dpc.h 2021-07-27T13:22:15+00:00 Lucas Henneman lucas.henneman@linaro.org 2021-07-23T14:43:35+00:00 82bcc3174af2472c10d9feeef8ceea32d54d9ef3 This patch resolves checkpatch's warning, "It's generally not useful to have the filename in the file" for dpc.h. Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org> Link: https://lore.kernel.org/r/20210723144340.15787-10-lucas.henneman@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch resolves checkpatch's warning, "It's generally not useful to
have the filename in the file" for dpc.h.

Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org>
Link: https://lore.kernel.org/r/20210723144340.15787-10-lucas.henneman@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>