linux-stable.git/drivers/staging/vt6655, branch linux-5.0.y

staging: vt6655: Fix interrupt race condition on device start up.

2019-04-03T04:27:32+00:00

commit 3b9c2f2e0e99bb67c96abcb659b3465efe3bee1f upstream.

It appears on some slower systems that the driver can find its way
out of the workqueue while the interrupt is disabled by continuous polling
by it.

Move MACvIntEnable to vnt_interrupt_work so that it is always enabled
on all routes out of vnt_interrupt_process.

Move MACvIntDisable so that the device doesn't keep polling the system
while the workqueue is being processed.

Signed-off-by: Malcolm Priestley 
CC: stable@vger.kernel.org # v4.2+
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Remove vif check from vnt_interrupt

2019-04-03T04:27:32+00:00

commit cc26358f89c3e493b54766b1ca56cfc6b14db78a upstream.

A check for vif is made in vnt_interrupt_work.

There is a small chance of leaving interrupt disabled while vif
is NULL and the work hasn't been scheduled.

Signed-off-by: Malcolm Priestley 
CC: stable@vger.kernel.org # v4.2+
Signed-off-by: Greg Kroah-Hartman

cross-tree: phase out dma_zalloc_coherent()

2019-01-08T12:58:37+00:00

We already need to zero out memory for dma_alloc_coherent(), as such
using dma_zalloc_coherent() is superflous. Phase it out.

This change was generated with the following Coccinelle SmPL patch:

@ replace_dma_zalloc_coherent @
expression dev, size, data, handle, flags;
@@

-dma_zalloc_coherent(dev, size, handle, flags)
+dma_alloc_coherent(dev, size, handle, flags)

Suggested-by: Christoph Hellwig 
Signed-off-by: Luis Chamberlain 
[hch: re-ran the script on the latest tree]
Signed-off-by: Christoph Hellwig

staging: vt6655: fix small typo

2018-11-07T12:07:26+00:00

Correct spelling mistakes of "Calculate"

Signed-off-by: Yangtao Li 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Remove space after cast

2018-10-09T12:59:58+00:00

Remove space after cast to fix checkpatch issue.
CHECK: No space is necessary after a cast

Signed-off-by: Mamta Shukla 
Reviewed-by: Himanshu Jha 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Add spaces around operators

2018-10-09T12:59:58+00:00

Add spaces around '*' and '-' to fix checkpatch issue.

Signed-off-by: Mamta Shukla 
Reviewed-by: Himanshu Jha 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Add blank line after function/struct/union/enum declarations

2018-10-09T12:59:58+00:00

Add blank line after function/struct/union/enum declarations to fix
checkpatch issue.
CHECK: Please use a blank line after function/struct/union/enum
declarations

Signed-off-by: Mamta Shukla 
Reviewed-by: Himanshu Jha 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: remove some redundant variables

2018-07-11T12:47:08+00:00

Variables rx_sts, sq, frame and is_pspoll are being assigned but are
never used hence they are redundant and can be removed.

Cleans up clang warnings:
warning: variable 'sq' set but not used [-Wunused-but-set-variable]
warning: variable 'rx_sts' set but not used [-Wunused-but-set-variable]
warning: variable 'frame' set but not used [-Wunused-but-set-variable]
warning: variable 'is_pspoll' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: remove unnecessary line breaks in function definition.

2018-04-23T13:23:36+00:00

This patch corrects the function definition style of CARDvSafeResetRx.
Issue found by checkpatch.

CHECK: Lines should not end with a '('

Signed-off-by: Danilo Alves 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: add handling memory leak on vnt_start()

2018-04-23T13:23:36+00:00

There was no code for handling memory leaks of device_init_rings() and
request_irq(). It needs to free allocated memory in the device_init_rings()
, when request_irq() would be failed. Add freeing sequences of irq and
device init rings.

Signed-off-by: Ji-Hun Kim 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman