linux-stable.git/drivers/staging/vt6655, branch linux-4.1.y

vt6655: Fix a possible sleep-in-atomic bug in vt6655_suspend

2018-01-17T17:55:40+00:00

[ Upstream commit 42c8eb3f6e15367981b274cb79ee4657e2c6949d ]

The driver may sleep under a spinlock, and the function call path is:
vt6655_suspend (acquire the spinlock)
  pci_set_power_state
    __pci_start_power_transition (drivers/pci/pci.c)
      msleep --> may sleep

To fix it, pci_set_power_state is called without having a spinlock.

This bug is found by my static analysis tool and my code review.

Signed-off-by: Jia-Ju Bai 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

staging: vt6655: vnt_bss_info_changed check conf->beacon_rate is not NULL

2015-08-17T03:52:23+00:00

commit 1f17124006b65482d9084c01e252b59dbca8db8f upstream.

conf->beacon_rate can be NULL on association. So check conf->beacon_rate

BSS_CHANGED_BEACON_INFO needs to flagged in changed as the beacon_rate
will appear later.

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: device_rx_srv check sk_buff is NULL

2015-08-03T16:28:59+00:00

commit b5eeed8cb6097c8ea660b6598d36fdbb94065a22 upstream.

There is a small chance that pRD->pRDInfo->skb could go NULL
while the interrupt is processing.

Put NULL check on loop to break out.

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: check ieee80211_bss_conf bssid not NULL

2015-08-03T16:28:59+00:00

commit 8e8e9198920ddfa920191069ae02eba75d39e653 upstream.

Sometimes bssid can go null on failed association.

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: lock MACvWriteBSSIDAddress.

2015-05-08T12:35:23+00:00

This function selects page 1 and cause intermittent problems on
interrupt handler.

lock call with spin_lock_irqsave.

Signed-off-by: Malcolm Priestley 
Cc:  # v3.19+
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: CARDbUpdateTSF bss timestamp correct tsf counter value.

2015-05-08T12:35:22+00:00

The TSF counter is not set correctly.

Use sync_tsf for last beacon value and get tsf local value.

Remove qwLocalTSF variable and call CARDbGetCurrentTSF.

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: vnt_tx_packet Correct TX order of OWNED_BY_NIC

2015-05-08T12:35:22+00:00

The state of m_td0TD0.f1Owner should change after the buff_addr
has been filled otherwise the device grabs the buffer too early.

m_td0TD0.f1Owner is protected by memory barriers on both sides
of change.

iTDUsed is best incremented after MACvTransmit.

It appears that f1Owner actually polls to do the memory transfer.

A back port patch will be needed for v3.19

Signed-off-by: Malcolm Priestley 
Cc:  # v4.0+
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Fix 80211 control and management status reporting.

2015-05-08T12:28:05+00:00

Currently only TD_FLAGS_NETIF_SKB are reported back to mac80211.

Move vnt_int_report_rate to report all frame types.

Signed-off-by: Malcolm Priestley 
Cc:  # v3.19+
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: implement IEEE80211_TX_STAT_NOACK_TRANSMITTED

2015-05-08T12:28:05+00:00

Make use of this macro for non ack frames.

Signed-off-by: Malcolm Priestley 
Cc:  # v4.0
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: device_free_tx_buf use only ieee80211_tx_status_irqsafe

2015-05-08T12:28:05+00:00

TD_FLAGS_NETIF_SKB is only for data.

Fixes issue of ack frames not being reported.

Signed-off-by: Malcolm Priestley 
Cc:  # v3.19+
Signed-off-by: Greg Kroah-Hartman