linux-stable.git/drivers/staging/vt6655, branch linux-3.16.y

staging: vt6655: fix overly large stack usage

2017-11-11T13:33:56+00:00

We get a warning for the large stack usage in some configurations:

drivers/staging/vt6655/device_main.c: In function 'device_ioctl':
drivers/staging/vt6655/device_main.c:2974:1: warning: the frame size of 1304 bytes is larger than 1024 bytes [-Wframe-larger-than=]

This is addressed in linux-3.19 with commit 67013f2c0e58 ("staging: vt6655:
mac80211 conversion add main mac80211 functions"), which obsoletes the
device_ioctl() function, but as that does not apply to stable kernels,
this picks an easier way out by using dynamic allocation.

The driver was merged in 2.6.31, and the fix applies to all versions
before 3.19.

Fixes: 5449c685a4b3 ("Staging: Add pristine upstream vt6655 driver sources")
Signed-off-by: Arnd Bergmann 
Signed-off-by: Ben Hutchings

staging: vt6655: device_rx_srv check sk_buff is NULL

2015-07-15T09:00:15+00:00

commit b5eeed8cb6097c8ea660b6598d36fdbb94065a22 upstream.

There is a small chance that pRD->pRDInfo->skb could go NULL
while the interrupt is processing.

Put NULL check on loop to break out.

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman 
[ luis: backported to 3.16: adjusted context ]
Signed-off-by: Luis Henriques

vt6655: RFbSetPower fix missing rate RATE_12M

2015-03-30T10:11:17+00:00

commit 40c8790bcb7ac74f3038153cd09310e220c6a1df upstream.

When the driver sets this rate a power of zero value is set causing
data flow stoppage until another rate is tried.

Signed-off-by: Malcolm Priestley 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Luis Henriques

staging: vt6655: Fix disassociated messages every 10 seconds

2014-07-24T22:10:42+00:00

byReAssocCount is incremented every second resulting in
disassociated message being send every 10 seconds whether
connection or not.

byReAssocCount should only advance while eCommandState
is in WLAN_ASSOCIATE_WAIT

Change existing scope to if condition.

Signed-off-by: Malcolm Priestley 
Cc: 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Fix Warning on boot handle_irq_event_percpu.

2014-07-24T22:10:42+00:00

WARNING: CPU: 0 PID: 929 at /home/apw/COD/linux/kernel/irq/handle.c:147 handle_irq_event_percpu+0x1d1/0x1e0()
irq 17 handler device_intr+0x0/0xa80 [vt6655_stage] enabled interrupts

Using spin_lock_irqsave appears to fix this.

Signed-off-by: Malcolm Priestley 
Cc: 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: refactor iwctl_giwaplist() to avoid -Wframe-larger-than warn.

2014-05-28T21:10:46+00:00

This commit refactors the iwctl_giwaplist() function so that the sparse
warning "the frame size of 1292 bytes is larger than 1024 bytes
[-Wframe-larger-than=]" is no more.

The root cause of this warning were two arrays allocated on the stack
and this commit changes this - these arrays are now kmalloc'ed. As a
result the function is refactored and hopefully stil working the same.

I were not able to test these changes so at least the carefull review
is more than welcomed.

Note that my changes has broadened the set of error codes that this
function can return. The new error code is ENOMEM. Luckily, this is
no issue.

Signed-off-by: Konrad Zapalowicz 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Remove useless return variables

2014-05-23T12:35:27+00:00

This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// 
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// 

Signed-off-by: Peter Senna Tschudin 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: fix checkpatch bracing issues

2014-05-15T20:26:37+00:00

This patchs fixes tons of warnings such as:

  WARNING: braces {} are not necessary for single statement blocks
  #354: FILE: drivers/staging/vt6655/wmgr.c:354:
  +       for (ii = 0; ii < WLAN_BSSID_LEN; ii++) {
  +               pMgmt->abyDesireBSSID[ii] = 0xFF;
  +       }

Please note: this patch only fixes bracing issues (and there is still a
lot to do); so if you run checkpatch it _will_ throw a lot of errors.
Use --test-only=braces

Signed-off-by: Guido Martínez 
Signed-off-by: Greg Kroah-Hartman

staging: vt6655: remove dead code

2014-05-15T20:25:58+00:00

Remove dead code in many places on this driver.

Signed-off-by: Guido Martínez 
Signed-off-by: Greg Kroah-Hartman

Staging: vt6655: tether: fixed a brace coding style issue

2014-05-15T20:23:03+00:00

Fixed a coding style issue.

Signed-off-by: Nicolas Del Piano 
Signed-off-by: Greg Kroah-Hartman