linux-stable.git/drivers/staging/usbip, branch linux-2.6.36.y

staging: usbip: remove double giveback of URB

2011-02-17T22:46:36+00:00

commit 7571f089d7522a95c103558faf313c7af8856ceb upstream.

In the vhci_urb_dequeue() function the TCP connection is checked twice.
Each time when the TCP connection is closed the URB is unlinked and given
back. Remove the second attempt of unlinking and giving back of the URB completely.

This patch fixes the bug described at https://bugzilla.kernel.org/show_bug.cgi?id=24872 .

Signed-off-by: Márton Németh 
Signed-off-by: Greg Kroah-Hartman

staging: usbip: Process event flags without delay

2010-11-22T19:02:59+00:00

commit 584c5b7cf06194464240280483ee0376cdddbbae upstream.

The way the event handler works can cause it to delay
events until eventual wakeup for another event.

For example, on device detach (vhci):

 - Write to sysfs detach file
    -> usbip_event_add(VDEV_EVENT_DOWN)
      -> wakeup()

#define VDEV_EVENT_DOWN (USBIP_EH_SHUTDOWN | USBIP_EH_RESET).

 - Event thread wakes up and passes the event to
   event_handler() to process.

 - It processes and clears the USBIP_EH_SHUTDOWN
   flag then returns.

 - The outer event loop (event_handler_loop()) calls
   wait_event_interruptible().

The processing of the second flag which is part of
VDEV_EVENT_DOWN (USBIP_EH_RESET) did not happen yet.
It is delayed until the next event.

This means the ->reset callback may not happen for
a long time (if ever), leaving the usbip port in a
weird state which prevents its reuse.

This patch changes the handler to process all flags
before waiting for another wakeup.

I have verified this change to fix a problem which
prevented reattach of a usbip device. It also helps
for socket errors which missed the RESET as well.

The delayed event processing also affects the stub
side of usbip and the error handling there.

Signed-off-by: Max Vozeler 
Reported-by: Marco Lancione 
Tested-by: Luc Jalbert 
Signed-off-by: Greg Kroah-Hartman

staging: usbip: Notify usb core of port status changes

2010-11-22T19:02:59+00:00

commit 0c9a32f0192e656daa2ff3c9149f6d71b4a1b873 upstream.

This patch changes vhci to behave like dummy and
other hcds when disconnecting a device.

Previously detaching a device from the root hub
did not notify the usb core of the disconnect and
left the device visible.

Signed-off-by: Max Vozeler 
Reported-by: Marco Lancione 
Tested-by: Luc Jalbert 
Signed-off-by: Greg Kroah-Hartman

USB: convert usb_hcd bitfields into atomic flags

2010-08-10T21:35:37+00:00

This patch (as1393) converts several of the single-bit fields in
struct usb_hcd to atomic flags.  This is for safety's sake; not all
CPUs can update bitfield values atomically, and these flags are used
in multiple contexts.

The flag fields that are set only during registration or removal can
remain as they are, since non-atomic accesses at those times will not
cause any problems.

(Strictly speaking, the authorized_default flag should become atomic
as well.  I didn't bother with it because it gets changed only via
sysfs.  It can be done later, if anyone wants.)

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

Staging: Merge staging-next into Linus's tree

2010-08-05T21:18:03+00:00

Conflicts:
	drivers/staging/Kconfig
	drivers/staging/batman-adv/bat_sysfs.c
	drivers/staging/batman-adv/device.c
	drivers/staging/batman-adv/hard-interface.c
	drivers/staging/cx25821/cx25821-audups11.c

Signed-off-by: Greg Kroah-Hartman

Staging: usbip: fix up build error

2010-07-27T18:12:21+00:00

This dma flag is no longer in the kernel.  Remove it as it's pointless
and it causes a build error.

Cc: Endre Kollar 
Signed-off-by: Greg Kroah-Hartman

Staging: usbip: Filtering illegal flags from remote driver

2010-07-27T18:08:31+00:00

The usb_submit_urb function in debug mode monitors the bogus flags. The
client driver errors should not be conveyed to the local USB device.

Signed-off-by: Endre Kollar 
Signed-off-by: Greg Kroah-Hartman

Staging: usbip: simplify get_ep_from_epnum

2010-07-27T18:08:31+00:00

usb_device->ep_in/out includes the necessary endpoints, search is not needed.

Signed-off-by: Endre Kollar 
Signed-off-by: Greg Kroah-Hartman

Staging: usbip: fix multiple interfaces

2010-07-27T18:06:29+00:00

The stub_probe function instantiates an stub_dev object  for all
interfaces. Wich causes a problem.  The stub_dev object belongs to their
own interfaces. This patch creates the sdev object at the first
stub_probe call, the other calls associate the interfaces to this.

Signed-off-by: Endre Kollar 
Signed-off-by: Greg Kroah-Hartman

staging: usbip: fix memory leak

2010-07-22T18:33:49+00:00

sdev should be freed if stub_add_files() failed.

Signed-off-by: Kulikov Vasiliy 
Signed-off-by: Greg Kroah-Hartman