linux-stable.git/drivers/staging/speakup, branch linux-5.5.y

staging/speakup: fix get_word non-space look-ahead

2020-03-25T07:27:05+00:00

commit 9d32c0cde4e2d1343dfb88a67b2ec6397705b32b upstream.

get_char was erroneously given the address of the pointer to the text
instead of the address of the text, thus leading to random crashes when
the user requests speaking a word while the current position is on a space
character and say_word_ctl is not enabled.

Reported-on: https://github.com/bytefire/speakup/issues/1
Reported-by: Kirk Reiser 
Reported-by: Janina Sajka 
Reported-by: Alexandr Epaneshnikov 
Reported-by: Gregory Nowak 
Reported-by: deedra waters 
Signed-off-by: Samuel Thibault 
Tested-by: Alexandr Epaneshnikov 
Tested-by: Gregory Nowak 
Tested-by: Michael Taboada 
Cc: stable 
Link: https://lore.kernel.org/r/20200306003047.thijtmqrnayd3dmw@function
Signed-off-by: Greg Kroah-Hartman

vt: selection, push console lock down

2020-03-12T06:18:34+00:00

commit 4b70dd57a15d2f4685ac6e38056bad93e81e982f upstream.

We need to nest the console lock in sel_lock, so we have to push it down
a bit. Fortunately, the callers of set_selection_* just lock the console
lock around the function call. So moving it down is easy.

In the next patch, we switch the order.

Signed-off-by: Jiri Slaby 
Fixes: 07e6124a1a46 ("vt: selection, close sel_buffer race")
Cc: stable 
Link: https://lore.kernel.org/r/20200228115406.5735-1-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

staging: speakup: document sysfs attributes

2019-10-04T08:06:05+00:00

Speakup exposes a set of sysfs attributes under
/sys/accessibility/speakup/ for user-space to interact with and
configure speakup's kernel modules. This patch describes those
attributes. Some attributes either lack a description or contain
incomplete description. They are marked wit TODO.

Authored-by: Gregory Nowak 
Submitted-by: Okash Khawaja 
Signed-off-by: Okash Khawaja 
Link: https://lore.kernel.org/r/20191001214729.1770-1-okash.khawaja@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: speakup: serialio: fix warning linux/serial.h is included more than once

2019-05-30T20:59:16+00:00

fix below warning reported by  includecheck

./drivers/staging/speakup/serialio.h: linux/serial.h is included more
than once.

Signed-off-by: Hariprasad Kelam 
Reviewed-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: refactor to use existing code in vt

2019-04-19T13:09:10+00:00

This patch replaces speakup's implementations with calls to functions
in tty/vt/selection.c. Those functions are:

cancel_selection()
set_selection_kernel()
paste_selection()

Currently setting selection is done in interrupt context. However,
set_selection_kernel() can sleep - for instance, it requires console_lock
which can sleep. Therefore we offload that work to a work_struct thread,
following the same pattern which was already set for paste_selection().
When setting selection, we also get a reference to tty and make sure to
release the reference before returning.

struct speakup_paste_work has been renamed to the more generic
speakup_selection_work because it is now used for both pasting as well
as setting selection. When paste work is cancelled, the code wasn't
setting tty to NULL. This patch also fixes that by setting tty to NULL
so that in case of failure we don't get EBUSY forever.

Signed-off-by: Okash Khawaja 
Reviewed-by: Samuel Thibault 
Tested-by: Gregory Nowak 
Signed-off-by: Greg Kroah-Hartman

staging: add missing SPDX lines to Kconfig files

2019-04-03T09:10:15+00:00

There are a few remaining drivers/staging/*/Kconfig files that do not
have SPDX identifiers in them.  Add the correct GPL-2.0 identifier to
them to make scanning tools happy.

Signed-off-by: Greg Kroah-Hartman

Merge 5.1-rc3 into staging-next

2019-04-01T05:49:24+00:00

We want those fixes and this resolves an erofs merge conflict.

Signed-off-by: Greg Kroah-Hartman

staging: speakup: fix printk KERN_LEVEL facility level warning

2019-03-18T17:53:16+00:00

Replace printk with pr_info to solve checkpatch.pl warning:
 " WARNING: printk() should include  KERN_ facility level"

Signed-off-by: Jules Irenge 
Signed-off-by: Greg Kroah-Hartman

staging: speakup_soft: Fix alternate speech with other synths

2019-03-18T06:57:58+00:00

When switching from speakup_soft to another synth, speakup_soft would
keep calling synth_buffer_getc() from softsynthx_read.

Let's thus make synth.c export the knowledge of the current synth, so
that speakup_soft can determine whether it should be running.

speakup_soft also needs to set itself alive, otherwise the switch would
let it remain silent.

Signed-off-by: Samuel Thibault 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: fix line over 80 characters.

2019-03-18T06:47:53+00:00

Fix coding style issues which solves checkpatch.pl warning:
    "WARNING: line over 80 characters".

Signed-off-by: Jules Irenge 
Signed-off-by: Greg Kroah-Hartman