linux-stable.git/drivers/staging/speakup, branch linux-4.6.y

staging: speakup: Replace del_timer with del_timer_sync

2016-03-12T06:09:09+00:00

Use del_timer_sync to ensure timer is stopped on all CPUs before
the driver exists and the timer should not run when the module is
being removed. Since the timer is not called from an interrupt
context, this change is safe and will not cause deadlock.

The Coccinelle semantic patch used to make this change is as
follows:
// 
@r@
declarer name module_exit;
identifier ex;
@@

module_exit(ex);

@@
identifier r.ex;
@@

ex(...) {
  <...
- del_timer
+ del_timer_sync
    (...)
  ...>
}
// 

Signed-off-by: Amitoj Kaur Chawla 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Remove unnecessary test in if condition

2016-03-05T22:48:04+00:00

Remove unnecessary test on synth->alive since it has already been
tested previously.

This fixes the following smatch warning:
drivers/staging/speakup/synth.c:182 spk_synth_is_alive_restart() warn:
we tested 'synth->alive' before and it was 'false'

Signed-off-by: Amitoj Kaur Chawla 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: remove multiple assignments

2016-03-05T22:48:04+00:00

Remove multiple assignments by factorizing.

Coccinelle semantic patch used:
@@ identifier x,y; constant z; @@
- x=y=z;
+ x=z;
+ y=z;

Signed-off-by: Alison Schofield 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: Add space around '|'

2016-03-05T22:48:04+00:00

Add space around operator '|'. Problem found using checkpatch.pl
CHECK: spaces preferred around that '|' (ctx:VxV)

Signed-off-by: Dilek Uzulmez 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Fix block comment style

2016-02-15T00:49:09+00:00

Use trailing */ on a separate line when it is a block comment.
This patch fixes the last of the checkpatch warnings for the file.

Signed-off-by: Janani Ravichandran 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: compress return logic into one line

2016-02-12T04:00:30+00:00

Simplify function return by merging assignment and return into
one command line. Remove (now) unused local variable.

Found using Coccinelle:
@@
expression e, ret;
@@

-ret =
+return
	e;
-return ret;

Signed-off-by: Alison Schofield 
Acked-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Eliminate commented out code

2016-02-12T04:00:30+00:00

This patch removes commented out code as it contributes to code clutter.

Signed-off-by: Janani Ravichandran 
Signed-off-by: Greg Kroah-Hartman

Staging:speakup:add space around '|'

2016-02-08T03:07:38+00:00

Fix checkpatch.pl check:CHECK: spaces preferred around that '|'.
Add spaces around operands to fix these warnings.

Signed-off-by: Bhumika Goyal 
Signed-off-by: Greg Kroah-Hartman

Merge 4.5-rc3 into staging-next

2016-02-08T01:34:04+00:00

We want the upstream staging fixes in here as well.

Signed-off-by: Greg Kroah-Hartman

Staging: speakup: Fix allyesconfig build on mn10300

2016-02-01T21:05:44+00:00

mn10300 uses an mmio-driven uart. This is not supported by speakup, so
prevent from enabling it.

Signed-off-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman