linux-stable.git/drivers/staging/speakup, branch linux-3.5.y

staging: speakup_soft: Fix reading of init string

2012-10-07T15:35:51+00:00

commit 40fe4f89671fb3c7ded94190fb267402a38b0261 upstream.

softsynth_read() reads a character at a time from the init string;
when it finds the null terminator it sets the initialized flag but
then repeats the last character.

Additionally, if the read() buffer is not big enough for the init
string, the next read() will start reading from the beginning again.
So the caller may never progress to reading anything else.

Replace the simple initialized flag with the current position in
the init string, carried over between calls.  Switch to reading
real data once this reaches the null terminator.

(This assumes that the length of the init string can't change, which
seems to be the case.  Really, the string and position belong together
in a per-file private struct.)

Tested-by: Samuel Thibault 
Signed-off-by: Ben Hutchings 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: fix an improperly-declared variable.

2012-10-02T17:39:01+00:00

commit 4ea418b8b2fa8a70d0fcc8231b65e67b3a72984b upstream.

A local static variable was declared as a pointer to a string
constant.  We're assigning to the underlying memory, so it
needs to be an array instead.

Signed-off-by: Christopher Brannon 
Signed-off-by: Greg Kroah-Hartman

TTY: speakup, do not use serialP

2012-03-08T19:47:02+00:00

The structures there are going away. And speakup has enough troubles
already.

So define a structure similar to what 8250 does: old_serial_port.
There define an array of speed, port base and so on needed for
configuration. Then use this structure instead of serial_state defined
in serialP.h.

Signed-off-by: Jiri Slaby 
Cc: William Hubbs 
Cc: Chris Brannon 
Cc: Kirk Reiser 
Cc: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman

vt:tackle kbd_table

2012-03-08T18:50:35+00:00

Keyboard struct lifetime is easy, but the locking is not and is completely
ignored by the existing code. Tackle this one head on

- Make the kbd_table private so we can run down all direct users
- Hoick the relevant ioctl handlers into the keyboard layer
- Lock them with the keyboard lock so they don't change mid keypress
- Add helpers for things like console stop/start so we isolate the poking
  around properly
- Tweak the braille console so it still builds

There are a couple of FIXME locking cases left for ioctls that are so hideous
they should be addressed in a later patch. After this patch the kbd_table is
private and all the keyboard jiggery pokery is in one place.

This update fixes speakup and also a memory leak in the original.

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

module_param: make bool parameters really bool (drivers & misc)

2012-01-12T23:02:20+00:00

module_param(bool) used to counter-intuitively take an int.  In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.

It's time to remove the int/unsigned int option.  For this version
it'll simply give a warning, but it'll break next kernel version.

Acked-by: Mauro Carvalho Chehab 
Signed-off-by: Rusty Russell

Staging: speakup: Don't try to access an unallocated struct.

2011-11-27T02:13:55+00:00

In speakup_init, we have the following:
	if (quiet_boot)
		spk_shut_up |= 0x01;
And in spk_types.h:
This patch moves the statement in speakup_init so that
speakup_console[vc->vc_num] is guaranteed to be allocated when it
executes.

Signed-off-by: Christopher Brannon 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: Use kmemdup rather than duplicating its implementation

2011-11-27T02:12:56+00:00

Use kmemdup rather than duplicating its implementation

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer 
Signed-off-by: Greg Kroah-Hartman

drivers/staging/speakup/devsynth.c: fix "buffer size is not provably correct" error

2011-08-02T23:09:46+00:00

x86_64 allmodconfig:

In file included from arch/x86/include/asm/uaccess.h:572,
                 from include/linux/uaccess.h:5,
                 from drivers/staging/speakup/devsynth.c:4:
In function 'copy_from_user',
    inlined from 'speakup_file_write' at drivers/staging/speakup/devsynth.c:28:
arch/x86/include/asm/uaccess_64.h:64: error: call to 'copy_from_user_overflow' declared with attribute error: copy_from_user() buffer size is not provably correct

I'm not sure what was unprovable about it, but size_t is the correct type
anyway.

Also replace needless min_t() with min()

Cc: William Hubbs 
Cc: Arjan van de Ven 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

Remove unneeded version.h includes from drivers/staging/speakup/

2011-07-05T17:39:38+00:00

It was pointed out by 'make versioncheck' that some includes of
linux/version.h are not needed in drivers/staging/speakup/.
This patch removes them.

Signed-off-by: Jesper Juhl 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Use kstrtoul_from_user

2011-06-28T21:35:41+00:00

This patch replaces the code for getting an unsigned long from a
userspace buffer by a simple call to kstroul_from_user.
This makes it easier to read and less error prone.

Kernel Version: staging of 20110606

Signed-off-by: Peter Huewe 
Signed-off-by: Greg Kroah-Hartman