linux-stable.git/drivers/staging/speakup, branch linux-3.2.y

staging: speakup: Prefix set_mask_bits() symbol

2014-04-09T01:20:44+00:00

This is part of commit ca2beaf84d96 ('staging: speakup: Prefix
externally-visible symbols') upstream.  It is required as preparation
for commit 00a1a053ebe5 ('ext4: atomically set inode->i_flags in
ext4_set_inode_flags()').

Signed-off-by: Ben Hutchings

speakup: lower default software speech rate

2013-03-06T03:24:26+00:00

commit cfd757010691eae4e17acc246f74e7622c3a2f05 upstream.

Speech synthesis beginners need a low speech rate, and trained people
want a high speech rate.  A medium speech rate is thus actually not a
good default for neither.  Since trained people will typically know how
to change the rate, better default for a low speech rate, which
beginners can grasp and learn how to increase it afterwards

This was agreed with users on the speakup mailing list.

Signed-off-by: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Ben Hutchings

staging: speakup: avoid out-of-range access in synth_add()

2013-02-06T04:33:25+00:00

commit 6102c48bd421074a33e102f2ebda3724e8d275f9 upstream.

Check that array index is in-bounds before accessing the synths[] array.

Signed-off-by: Samuel Thibault 
Cc: Nickolai Zeldovich 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Ben Hutchings

staging: speakup: avoid out-of-range access in synth_init()

2013-02-06T04:33:24+00:00

commit ae428655b826f2755a8101b27beda42a275ef8ad upstream.

Check that array index is in-bounds before accessing the synths[] array.

Signed-off-by: Nickolai Zeldovich 
Cc: Samuel Thibault 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Ben Hutchings

staging: speakup_soft: Fix reading of init string

2012-10-17T02:48:30+00:00

commit 40fe4f89671fb3c7ded94190fb267402a38b0261 upstream.

softsynth_read() reads a character at a time from the init string;
when it finds the null terminator it sets the initialized flag but
then repeats the last character.

Additionally, if the read() buffer is not big enough for the init
string, the next read() will start reading from the beginning again.
So the caller may never progress to reading anything else.

Replace the simple initialized flag with the current position in
the init string, carried over between calls.  Switch to reading
real data once this reaches the null terminator.

(This assumes that the length of the init string can't change, which
seems to be the case.  Really, the string and position belong together
in a per-file private struct.)

Tested-by: Samuel Thibault 
Signed-off-by: Ben Hutchings 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: fix an improperly-declared variable.

2012-09-12T02:37:35+00:00

commit 4ea418b8b2fa8a70d0fcc8231b65e67b3a72984b upstream.

A local static variable was declared as a pointer to a string
constant.  We're assigning to the underlying memory, so it
needs to be an array instead.

Signed-off-by: Christopher Brannon 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Ben Hutchings

drivers/staging/speakup/devsynth.c: fix "buffer size is not provably correct" error

2011-08-02T23:09:46+00:00

x86_64 allmodconfig:

In file included from arch/x86/include/asm/uaccess.h:572,
                 from include/linux/uaccess.h:5,
                 from drivers/staging/speakup/devsynth.c:4:
In function 'copy_from_user',
    inlined from 'speakup_file_write' at drivers/staging/speakup/devsynth.c:28:
arch/x86/include/asm/uaccess_64.h:64: error: call to 'copy_from_user_overflow' declared with attribute error: copy_from_user() buffer size is not provably correct

I'm not sure what was unprovable about it, but size_t is the correct type
anyway.

Also replace needless min_t() with min()

Cc: William Hubbs 
Cc: Arjan van de Ven 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

Remove unneeded version.h includes from drivers/staging/speakup/

2011-07-05T17:39:38+00:00

It was pointed out by 'make versioncheck' that some includes of
linux/version.h are not needed in drivers/staging/speakup/.
This patch removes them.

Signed-off-by: Jesper Juhl 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Use kstrtoul_from_user

2011-06-28T21:35:41+00:00

This patch replaces the code for getting an unsigned long from a
userspace buffer by a simple call to kstroul_from_user.
This makes it easier to read and less error prone.

Kernel Version: staging of 20110606

Signed-off-by: Peter Huewe 
Signed-off-by: Greg Kroah-Hartman

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi