linux-stable.git/drivers/staging/speakup, branch linux-3.1.y

drivers/staging/speakup/devsynth.c: fix "buffer size is not provably correct" error

2011-08-02T23:09:46+00:00

x86_64 allmodconfig:

In file included from arch/x86/include/asm/uaccess.h:572,
                 from include/linux/uaccess.h:5,
                 from drivers/staging/speakup/devsynth.c:4:
In function 'copy_from_user',
    inlined from 'speakup_file_write' at drivers/staging/speakup/devsynth.c:28:
arch/x86/include/asm/uaccess_64.h:64: error: call to 'copy_from_user_overflow' declared with attribute error: copy_from_user() buffer size is not provably correct

I'm not sure what was unprovable about it, but size_t is the correct type
anyway.

Also replace needless min_t() with min()

Cc: William Hubbs 
Cc: Arjan van de Ven 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

Remove unneeded version.h includes from drivers/staging/speakup/

2011-07-05T17:39:38+00:00

It was pointed out by 'make versioncheck' that some includes of
linux/version.h are not needed in drivers/staging/speakup/.
This patch removes them.

Signed-off-by: Jesper Juhl 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: Use kstrtoul_from_user

2011-06-28T21:35:41+00:00

This patch replaces the code for getting an unsigned long from a
userspace buffer by a simple call to kstroul_from_user.
This makes it easier to read and less error prone.

Kernel Version: staging of 20110606

Signed-off-by: Peter Huewe 
Signed-off-by: Greg Kroah-Hartman

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

staging: speakup: Remove NULL check before kfree

2011-03-14T18:57:36+00:00

This patch was generated by the following semantic patch:
// 
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);

@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// 

Signed-off-by: Ilia Mirkin 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: fix an out-of-bounds error.

2011-02-23T22:39:09+00:00

The cur_item variable from keyhelp.c is an index into a table of
messages.  The following condition should always hold:
MSG_FUNCNAMES_START + cur_item <= MSG_FUNCNAMES_END.
The check in keyhelp.c was wrong.  It allowed cur_item to be
incremented to an out-of-bounds value.

Signed-off-by: Christopher Brannon 
Signed-off-by: Greg Kroah-Hartman

staging: speakup: enlosed macros with complex values in parenthesis

2011-02-04T21:01:02+00:00

Enclosed all macros with complex values in parenthesis

Signed-off-by: Timo von Holtz 
Signed-off-by: Greg Kroah-Hartman

Staging: Merge branch 'staging-next' into 2.6.38-rc3

2011-02-02T21:35:58+00:00

This was done to resolve conflicts in the following files due
to patches in Linus's tree and in the staging-next tree:
	drivers/staging/brcm80211/brcmsmac/wl_mac80211.c
	drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c

Signed-off-by: Greg Kroah-Hartman

staging: speakup: more fixes for init-failure handling.

2011-01-20T23:58:16+00:00

We still leaked many resources when Speakup failed to initialize.
Examples of leaked resources include:
/dev/synth, keyboard or VT notifiers, and heap-allocated st_spk_t
structs.
This is fixed.

* We now use PTR_ERR to detect kthread_create failure
(thank you Dan Carpenter).

* The loop which frees members of the speakup_console array now iterates
over the whole array, not stopping at the first NULL value.  Fixes
a possible memory leak.  Safe because kfree(NULL) is a no-op.

* The order of some initializations was changed.  The safe ones, which
will never fail, are performed first.

Signed-off-by: Christopher Brannon 
Acked-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

Staging: speakup: &&/|| confusion in silent_store()

2011-01-20T20:06:07+00:00

Fix test: the branch is always taken.

Signed-off-by: Roel Kluin 
Cc: Andrew Morton 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman