linux-stable.git/drivers/staging/slicoss, branch linux-3.7.y

staging: slicoss: fix a null deref when pci_alloc_consistent fail

2012-09-05T18:59:51+00:00

we are dereferencing the pshmem , and the pci_alloc_consistent can fail
returning null,

do a memcpy if we have a valid pshmem

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: remove return statement at the end of slic_mcast_set_list

2012-09-05T18:59:51+00:00

this function return void, means return at the end of this function
is not needed

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: clean the spinlock code in slic_entry_open

2012-09-05T18:59:51+00:00

the locked variable is used for checking whether the function
acquired lock, then unlock. actually with out this we
can achieve the same lock and unlock senario, remove the locked
variable and also cleanup the code around.

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: remove default case after we done with request_firmware

2012-09-05T18:59:51+00:00

we are returning -ENOENT when there is no firmware file for a matching
device id. then we start calling request_firmware,
after this we do checks on the firmware length of corresponding
device id, since the default case is handled in the begining itself
there is no need of a default case at the firmware length checks

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: release firmware before returning

2012-09-04T21:23:33+00:00

we request_firmware in slic_card_download_gbrcv and we return out
with out calling release_firmware, where we compare against a
firmware lengths of certain device ids.

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: return early before calling request_firmware with empty firmware filename

2012-09-04T21:23:33+00:00

when the device id doesn't match in slic_card_download_gbrcv the filename is "",
i.e an empty name, and we try calling request_firmware with that name,
actually we can just fail out at default case before even calling request_firmware

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

staging/slicoss: disable pci device at remove

2012-07-12T00:26:02+00:00

at probe we enabled the device, and we should disable it at remove.

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

staging/slicoss: return -ENODEV if no devid matches

2012-07-09T20:06:21+00:00

if no case matches we are simply asserting and doing break.
and i think we may need to return that -ENODEV , no device is
present, rather assert'ing.

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

staging/slicoss: remove not-needed ASSERT

2012-07-09T20:06:21+00:00

As the private pointer is valid at the remove of driver, and remove wont' be called if probe fails, so no point for checking of ASSERT

Signed-off-by: Devendra Naga 
Signed-off-by: Greg Kroah-Hartman

staging: slicoss: Fix a typo.

2012-06-19T00:23:52+00:00

The below patch fixes a typo found while reading through staging/slicoss

Signed-off-by: Justin P. Mattock 
Signed-off-by: Greg Kroah-Hartman