linux-stable.git/drivers/staging/sep, branch linux-3.16.y Linux kernel stable tree drivers/staging: Remove useless return variables 2014-05-26T17:32:15+00:00 Peter Senna Tschudin peter.senna@gmail.com 2014-05-26T14:08:50+00:00 4764ca981b040048766e4f39a45a4b9c5cecff9c This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret when strict return - ret + C ; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
    when strict
return
- ret
+ C
;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: sep: Fix coding style 2014-05-15T22:04:45+00:00 Camille Bordignon camille.bordignon@gmail.com 2014-04-06T16:21:27+00:00 2787b99fd62f01af33bea5a076b665e128c67177 Fix coding style warning "Missing a blank line after declarations" Signed-off-by: Camille Bordignon <camille.bordignon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Fix coding style warning "Missing a blank line after declarations"

Signed-off-by: Camille Bordignon <camille.bordignon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: sep: Add fallthrough comment 2014-03-17T00:52:00+00:00 Andreea-Cristina Bernat bernat.ada@gmail.com 2014-03-12T19:19:53+00:00 98e2dda325e9978a98635ad264438dcaea7f0b9c This patch solves the warning "possible switch/case default not preceded by break or fallthrough comment". Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> 
This patch solves the warning "possible switch/case default not preceded by
break or fallthrough comment".

Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Staging: sep: Fix line length over 80 characters in sep_main.c 2014-02-27T21:07:59+00:00 Monam Agarwal monamagarwal123@gmail.com 2014-02-26T05:27:14+00:00 e26b0da125b475bbfbc4e6e6936cfd2795e5aa3b This patch fixes the following checkpatch.pl warning in sep_main.c WARNING: line length over 80 characters Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch fixes the following checkpatch.pl warning in sep_main.c
WARNING: line length over 80 characters

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: sep: Fix quoted string split across lines in sep_main.c 2014-02-27T21:07:59+00:00 Monam Agarwal monamagarwal123@gmail.com 2014-02-26T05:25:08+00:00 22fc12669bc624f28c815b4eddff81331205f583 This patch fixes the following checkpatch.pl warning in sep_main.c WARNING: Quoted string split across lines Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch fixes the following checkpatch.pl warning in sep_main.c
WARNING: Quoted string split across lines

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: sep: Fix missing space after return type in sep_crypto.c 2014-02-27T21:07:59+00:00 Monam Agarwal monamagarwal123@gmail.com 2014-02-26T05:22:36+00:00 38d6bc53e2473e1c3bb91c28eb29b9a33d4e0d38 This patch fixes the following checkpatch.pl warning in sep_main.c WARNING: Missing space after return type Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch fixes the following checkpatch.pl warning in sep_main.c
WARNING: Missing space after return type

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: sep: add missing destroy_workqueue() in sep_crypto.c 2013-12-20T19:45:09+00:00 Wei Yongjun yongjun_wei@trendmicro.com.cn 2013-12-20T03:05:16+00:00 a7c7eb03fd370b33ba9c93766df2af61551c4310 Add the missing destroy_workqueue() before return from sep_crypto_setup() and sep_crypto_takedown(). Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Add the missing destroy_workqueue() before return from
sep_crypto_setup() and sep_crypto_takedown().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: delete non-required instances of include <linux/init.h> 2013-12-17T18:08:14+00:00 Paul Gortmaker paul.gortmaker@windriver.com 2013-12-10T20:23:48+00:00 885a947e5b08953ebd5fce88be89a0399a7ab918 None of these files are actually using any __init type directives and hence don't need to include <linux/init.h>. Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
None of these files are actually using any __init type directives
and hence don't need to include <linux/init.h>.  Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: remove DEFINE_PCI_DEVICE_TABLE macro 2013-12-03T06:32:35+00:00 Jingoo Han jg1.han@samsung.com 2013-12-02T23:26:00+00:00 41e043fcfa2236bb2c4a8335eb09f4c8cee224b3 Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
is not preferred.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: sep: do not use comparisons on bool tests 2013-10-28T21:32:51+00:00 Valentina Manea valentina.manea.m@gmail.com 2013-10-25T08:48:29+00:00 d5f9f1e3a9945198be1bf20f0e110af9e29f9970 This patch fixes coccinelle errors regarding comparisons used in bool tests. Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch fixes coccinelle errors regarding comparisons
used in bool tests.

Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>