linux-stable.git/drivers/staging/rtl8712, branch v4.2.3

staging: rtl8712: fix else after break or return warning

2015-06-13T21:45:51+00:00

This patch fixes checkpatch.pl warning.
WARNING: else is not generally useful after a break or return

Signed-off-by: Dogukan Ergun 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: use swap() in dequeue_xframe_ex()

2015-06-13T00:19:47+00:00

Use kernel.h macro definition.

Thanks to Julia Lawall for Coccinelle scripting support.

Signed-off-by: Fabian Frederick 
Signed-off-by: Greg Kroah-Hartman

staging:rtl8712:Fix compressed return statement

2015-06-08T20:38:56+00:00

Fix reported by coccinelle compressing last two lines with single return
call

Signed-off-by: Prasanna Karthik 
Acked-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: fix indentation issue

2015-06-08T20:33:40+00:00

Fixed indentation issue in few lines

Signed-off-by: Hari Prasath Gujulan Elango 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: remove useless return value

2015-05-31T02:49:58+00:00

The loadparam() function cannot fail, it's called only once and its return
value is ignored there.

Signed-off-by: Luca Ceresoli 
Cc: Greg Kroah-Hartman 
Cc: Larry Finger 
Cc: Florian Schilhabel 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: remove unneeded forward declaration

2015-05-31T02:49:57+00:00

Signed-off-by: Luca Ceresoli 
Cc: Greg Kroah-Hartman 
Cc: Larry Finger 
Cc: Florian Schilhabel 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: remove useless comment

2015-05-31T02:49:57+00:00

"step 2" does mean much as there is no "step 1" stated anywhere...

Signed-off-by: Luca Ceresoli 
Cc: Greg Kroah-Hartman 
Cc: Larry Finger 
Cc: Florian Schilhabel 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: prevent buffer overrun in recvbuf2recvframe

2015-05-31T02:49:57+00:00

With an RTL8191SU USB adaptor, sometimes the hints for a fragmented
packet are set, but the packet length is too large. Allocate enough
space to prevent memory corruption and a resulting kernel panic [1].

[1] http://www.spinics.net/lists/linux-wireless/msg136546.html

Cc: 
Signed-off-by: Haggai Eran 
ACKed-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: fix stack dump

2015-05-31T02:49:57+00:00

del_timer_sync() is not to be called in the interrupt context unless
the timer is irqsafe. but most of the functions where commits
6501c8e7d86cca5f and 382d020f4459cd77 touched were called in interrupt
context. And as a result the WARN_ON was getting triggered. Changed
to del_timer() in places which were called from interrupt.

Fixes: 382d020f4459cd77 ("Staging: rtl8712: Eliminate use of _cancel_timer"
Fixes: 6501c8e7d86cca5f ("Staging: rtl8712: Eliminate use of _cancel_timer_ex")
Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=97711
Reported-by: Arek Rusniak 
Tested-by: Arek Rusniak 
Signed-off-by: Sudip Mukherjee 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Use ether_addr_copy() instead of memcpy()

2015-05-31T02:47:56+00:00

Fixes Warning encounter this by applying checkpatch.pl against this file:
Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
are __aligned(2)

pahole output for respective structures:
- addr->sa_data
struct sockaddr {
	sa_family_t                sa_family;            /*     0     2 */
	char                       sa_data[14];          /*     2    14 */

	/* size: 16, cachelines: 1, members: 2 */
	/* last cacheline: 16 bytes */
};

- pnetdev->dev_addr
dev_addr is interface address infor from generic net_device structure
which is properly aligned and have some patches with this change as well.
"staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()"
(sha1: 36e4d8826b317080e283e4edd08bf8d5ac706f38)

Signed-off-by: Jagan Teki 
Cc: Greg Kroah-Hartman 
Cc: Larry Finger 
Cc: Florian Schilhabel 
Signed-off-by: Greg Kroah-Hartman