linux-stable.git/drivers/staging/rtl8712, branch linux-5.0.y

staging: rtl8712: uninitialized memory in read_bbreg_hdl()

2019-05-04T07:21:16+00:00

[ Upstream commit 22c971db7dd4b0ad8dd88e99c407f7a1f4231a2e ]

Colin King reported a bug in read_bbreg_hdl():

	memcpy(pcmd->rsp, (u8 *)&val, pcmd->rspsz);

The problem is that "val" is uninitialized.

This code is obviously not useful, but so far as I can tell
"pcmd->cmdcode" is never GEN_CMD_CODE(_Read_BBREG) so it's not harmful
either.  For now the easiest fix is to just call r8712_free_cmd_obj()
and return.

Fixes: 2865d42c78a9 ("staging: r8712u: Add the new driver to the mainline kernel")
Reported-by: Colin Ian King 
Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin (Microsoft)

Merge 4.20-rc6 into staging-next

2018-12-10T08:23:50+00:00

We want the staging fixes in here as well.

Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Fix possible buffer overrun

2018-12-05T08:56:09+00:00

In commit 8b7a13c3f404 ("staging: r8712u: Fix possible buffer
overrun") we fix a potential off by one by making the limit smaller.
The better fix is to make the buffer larger.  This makes it match up
with the similar code in other drivers.

Fixes: 8b7a13c3f404 ("staging: r8712u: Fix possible buffer overrun")
Signed-off-by: Young Xiao 
Cc: stable 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8712: fix small typo

2018-11-07T12:07:26+00:00

ture->true

Signed-off-by: Yangtao Li 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: fix CamelCase in fw_priv struct

2018-11-07T11:35:10+00:00

Rename fields in fw_priv struct from CamelCase to snake_case.
Reported by checkpatch.

Signed-off-by: Robert Eshleman 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: add SPDX identifiers

2018-10-03T18:36:09+00:00

This satisfies a checkpatch warning and is the preferred
method for notating the license.

The SPDX identifier is a legally binding shorthand, which
can be used instead of the full boiler plate text.

Signed-off-by: Michael Straube 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Remove unnecessary parentheses

2018-10-02T21:59:14+00:00

Remove unnecessary parentheses between 'address-of' operators
and struct members.
Issues found with checkpatch.pl

Signed-off-by: Dafna Hirschfeld 
Acked-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: replace licence header with SPDX licence id

2018-09-20T10:29:26+00:00

fixed warning found by checkpatch

Signed-off-by: André Lehmann 
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8712: Add space between else and opening brace

2018-09-10T15:12:42+00:00

issue found by checkpatch

Signed-off-by: André Lehmann 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712u: Fix compiler warning about strncpy

2018-09-10T08:18:32+00:00

When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. Using
strlcpy() rather than strncpy() forces a null at the end and quiets the
warning.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman