linux-stable.git/drivers/staging/rtl8712, branch linux-4.12.y

staging: rtl8712: fixed multiple line derefence issue

2017-04-08T15:05:59+00:00

Checkpatch emits WARNING: Avoid multiple line dereference.

Checkpatch warning is fixed by:
* Trivial indentation improvement and
* Using += instead of + helps shortening the statement.

Signed-off-by: Prasant Jalan 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: code style fix

2017-04-08T15:05:59+00:00

Fixed the warnings from checkpatch.pl on file rtl8712/mlme_linux.c
Avoided multiple line dereferences in the code

Signed-off-by: Tejaswini Poluri 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Invert comparison to reduce indentation

2017-03-23T13:24:45+00:00

Check the condition: "pdata->length < 32" first, to be able to return immediately
in case of error and then continue with the rest of the function without one
extra indentation level.

This was found using the following Coccinelle script:

@disable neg_if@
expression e,E;
statement S;
@@

*if (e)
    S
    else { return -E; }

    @disable neg_if@
    expression e,E;
    statement S;
    identifier l;
    @@

    *if
(e)
    S
    else
{ rc = -E; goto l; }

Signed-off-by: Narcisa Ana Maria Vasile 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Restructure code for clarity

2017-03-23T13:24:45+00:00

Invert if statements to be able to return immediately in case of error,
and to avoid additional else branch.

Improve layout of function since there is more horizontal space now.

This was found using the following Coccinelle script:

@disable neg_if@
expression e,E;
statement S;
@@

*if (e)
    S
    else { return -E; }

    @disable neg_if@
    expression e,E;
    statement S;
    identifier l;
    @@

    *if
(e)
    S
    else
{ rc = -E; goto l; }

Signed-off-by: Narcisa Ana Maria Vasile 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Invert the test on check_fwstate() to reduce indentation

2017-03-23T13:24:45+00:00

Negate if condition to be able to return immediately in case of error,
and then continue with the rest of the function
without extra indentation level.

This was found using the following Coccinelle script:

@disable neg_if@
expression e,E;
statement S;
@@

*if (e)
    S
    else { return -E; }

    @disable neg_if@
    expression e,E;
    statement S;
    identifier
    l;
    @@

    *if
(e)
    S
    else
{ rc = -E; goto l; }

Signed-off-by: Narcisa Ana Maria Vasile 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Invert if statements to reduce indentation level

2017-03-23T13:24:45+00:00

Invert if statements to be able to return immediately in case of error,
and to avoid additional else branch, and then continue with the rest
of the function without excessive indentation.

This was found using the following Coccinelle script:

@disable neg_if@
expression e,E;
statement S;
@@

*if (e)
S
else { return -E; }

@disable neg_if@
expression e,E;
statement S;
identifier l;
@@

*if (e)
S
else { rc = -E; goto l;  }

Signed-off-by: Narcisa Ana Maria Vasile 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: checkpatch: Avoid multiple line dereferences

2017-03-21T07:44:55+00:00

"WARNING: Avoid multiple line dereference - prefer 'poid_par_priv->information_buf_len'"
"WARNING: Avoid multiple line dereference - prefer 'padapter->registrypriv.dev_network.Configuration'"
"WARNING: Avoid multiple line dereference - prefer 'Adapter->mppriv.workparam.io_value'"

Signed-off-by: Ding-Chi Wang 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: fix bad indentation

2017-03-12T14:27:40+00:00

Fix bad indentation as reported by checkpatch.pl script.

Signed-off-by: Thibaut SAUTEREAU 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Remove unnecessary cast on void pointer

2017-03-09T16:37:21+00:00

The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T*)x)->f
|
- (T*)
  e
)

Signed-off-by: simran singhal 
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8712: rtl871x_mp_ioctl.h - style fix

2017-03-09T16:37:21+00:00

Fixed style of block comments
Found using checkpatch

Signed-off-by: Derek Robson 
Signed-off-by: Greg Kroah-Hartman