linux-stable.git/drivers/staging/rtl8712, branch linux-3.18.y

staging: r8712u: Fix Sparse warning in rtl871x_xmit.c

2017-11-08T09:03:50+00:00

[ Upstream commit 07222e535831b916221dd2a48a3047ec7e45dc72 ]

Sparse reports the following:
  CHECK   drivers/staging/rtl8712/rtl871x_xmit.c
drivers/staging/rtl8712/rtl871x_xmit.c:350:44: warning: restricted __le32 degrades to integer
drivers/staging/rtl8712/rtl871x_xmit.c:491:23: warning: incorrect type in initializer (different base types)
drivers/staging/rtl8712/rtl871x_xmit.c:491:23:    expected unsigned short [usertype] *fctrl
drivers/staging/rtl8712/rtl871x_xmit.c:491:23:    got restricted __le16 *
drivers/staging/rtl8712/rtl871x_xmit.c:580:36: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8712/rtl871x_xmit.c:580:36:    expected unsigned short [unsigned] [short] [usertype] 
drivers/staging/rtl8712/rtl871x_xmit.c:580:36:    got restricted __be16 [usertype] 

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712u: Fix endian settings for structs describing network packets

2017-11-08T09:03:49+00:00

[ Upstream commit 221c46d28957bd6e2158abc2179ce4a8c9ce07d3 ]

The headers describing a number of network packets do not have the
correct endian settings for several types of data.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: prevent buffer overrun in recvbuf2recvframe

2015-07-04T03:02:21+00:00

[ Upstream commit cab462140f8a183e3cca0b51c8b59ef715cb6148 ]

With an RTL8191SU USB adaptor, sometimes the hints for a fragmented
packet are set, but the packet length is too large. Allocate enough
space to prevent memory corruption and a resulting kernel panic [1].

[1] http://www.spinics.net/lists/linux-wireless/msg136546.html

Cc: 
Signed-off-by: Haggai Eran 
ACKed-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

staging: rtl8712: Fixed else not required after return

2014-10-02T18:59:40+00:00

WARNING: Else generally not required after return
checkpatch.pl warning in hal_init.c
Fixed by removing else

Signed-off-by: Sarah Khan 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Fix missing blank line warning

2014-10-02T18:59:40+00:00

Fixes "Missing a blank line after declarations" checkpatch.pl warning in
usb_ops_linux.c

Signed-off-by: Melike Yurtoglu 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: Fix unnecessary parentheses style warning

2014-10-02T17:15:12+00:00

This fixes the following checkpatch.pl warning:

drivers/staging/rtl8712/rtl871x_recv.c:634 warning: Unnecessary parentheses - maybe == should be = ?

Signed-off-by: Yeliz Taneroglu 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: add new line after declarations

2014-09-29T02:41:23+00:00

This patch fixes checkpatch.pl warning in hal_init.c file
WARNING : Missing a blank line after declarations

Signed-off-by: Tapasweni Pathak 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: fixed missing blank line

2014-09-24T03:33:23+00:00

WARNING : Missing a blank line after declaration
checkpatch.pl warning in hal_init.c

Signed-off-by: Sarah Khan 
Acked-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: merge lines and remove unused variable for immediate return

2014-09-23T15:14:37+00:00

This patch merge two lines in a single line if immediate return is found.
Unused variables in each case were removed manually as they are no longer
needed.

This is done using Coccinelle. Semantic patch used for this is as
follows :
@@
expression ret;
identifier f;
@@

-ret =
+return
     f(...);
-return ret;

Signed-off-by: Tapasweni Pathak 
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8712: Add space after return type

2014-09-23T15:14:36+00:00

This patch fixes checkpatch.pl warning in file rtl871x_ioctl.h
WARNING : Missing space after return type

Signed-off-by: Tapasweni Pathak 
Signed-off-by: Greg Kroah-Hartman