linux-stable.git/drivers/staging/rtl8712, branch linux-3.12.y

staging: rtl: fix possible NULL pointer dereference

2017-03-13T20:40:23+00:00

commit 6e017006022abfea5d2466cad936065f45763ad1 upstream.

gcc-7 detects that wlanhdr_to_ethhdr() in two drivers calls memcpy() with
a destination argument that an earlier function call may have set to NULL:

staging/rtl8188eu/core/rtw_recv.c: In function 'wlanhdr_to_ethhdr':
staging/rtl8188eu/core/rtw_recv.c:1318:2: warning: argument 1 null where non-null expected [-Wnonnull]
staging/rtl8712/rtl871x_recv.c: In function 'r8712_wlanhdr_to_ethhdr':
staging/rtl8712/rtl871x_recv.c:649:2: warning: argument 1 null where non-null expected [-Wnonnull]

I'm fixing this by adding a NULL pointer check and returning failure
from the function, which is hopefully already handled properly.

This seems to date back to when the drivers were originally added,
so backporting the fix to stable seems appropriate. There are other
related realtek drivers in the kernel, but none of them contain a
function with a similar name or produce this warning.

Fixes: 1cc18a22b96b ("staging: r8188eu: Add files for new driver - part 5")
Fixes: 2865d42c78a9 ("staging: r8712u: Add the new driver to the mainline kernel")
Signed-off-by: Arnd Bergmann 
Signed-off-by: Jiri Slaby

staging: rtl8712: Add device ID for Sitecom WLA2100

2016-01-05T15:23:34+00:00

commit 1e6e63283691a2a9048a35d9c6c59cf0abd342e4 upstream.

This adds the USB ID for the Sitecom WLA2100. The Windows 10 inf file
was checked to verify that the addition is correct.

Reported-by: Frans van de Wiel 
Signed-off-by: Larry Finger 
Cc: Frans van de Wiel 
Signed-off-by: Jiri Slaby

staging: rtl8712: prevent buffer overrun in recvbuf2recvframe

2015-08-04T14:52:01+00:00

commit cab462140f8a183e3cca0b51c8b59ef715cb6148 upstream.

With an RTL8191SU USB adaptor, sometimes the hints for a fragmented
packet are set, but the packet length is too large. Allocate enough
space to prevent memory corruption and a resulting kernel panic [1].

[1] http://www.spinics.net/lists/linux-wireless/msg136546.html

Signed-off-by: Haggai Eran 
ACKed-by: Larry Finger 
Signed-off-by: Jiri Slaby

staging: rtl8712, rtl8712: avoid lots of build warnings

2015-05-26T14:27:01+00:00

commit 0c9f3a65c5eb7fe1fc611a22eb8a8b71ea865998 upstream.

The rtl8712 driver has an 'extern inline' function that contains an
'if', which causes lots of warnings with CONFIG_PROFILE_ALL_BRANCHES
overriding the definition of 'if':

drivers/staging/rtl8712/ieee80211.h:759:229: warning: '______f' is static but declared in inline function 'ieee80211_get_hdrlen' which is not static [enabled by default]

This changes the driver to use 'static inline' instead, which happens
to be the correct annotation anyway.

Signed-off-by: Arnd Bergmann 
Cc: Larry Finger 
Cc: Florian Schilhabel 
Signed-off-by: Jiri Slaby

staging: r8712u: Fix case where ethtype was never obtained and always be checked against 0

2014-05-15T07:55:00+00:00

commit f764cd68d9036498f08fe8834deb6a367b5c2542 upstream.

Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparison against eapol_type
would always fail.

Reported-by: Jes Sorensen 
Signed-off-by: Larry Finger 
Signed-off-by: Jiri Slaby

staging: r8712u: Set device type to wlan

2014-02-06T19:22:16+00:00

commit 3a21f00a5002b14e4aab52aef59d33ed28468a13 upstream.

The latest version of NetworkManager does not recognize the device as wireless
without this change.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8712: return MAC in standard form

2013-07-23T21:52:19+00:00

MAC respresentation should follow standard form.

Signed-off-by: Andy Shevchenko 
Acked-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

drivers: avoid parsing names as kthread_run() format strings

2013-07-03T23:07:41+00:00

Calling kthread_run with a single name parameter causes it to be handled
as a format string. Many callers are passing potentially dynamic string
content, so use "%s" in those cases to avoid any potential accidents.

Signed-off-by: Kees Cook 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtl8712: remove redundant if statement

2013-03-11T16:49:55+00:00

Same result no matter what path is taken.

Signed-off-by: Niklas Söderlund 
Acked-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

rtl8712: remove unused definitions from rtl871x_recv.h

2013-03-11T16:49:55+00:00

Signed-off-by: Niklas Söderlund 
Signed-off-by: Greg Kroah-Hartman