linux-stable.git/drivers/staging/rtl8192e, branch v4.3 Linux kernel stable tree staging: rtl8192e: Fix log spamming in rtl8192_hard_data_xmit 2015-08-15T01:56:55+00:00 Mateusz Kulikowski mateusz.kulikowski@gmail.com 2015-08-12T19:54:49+00:00 435009bba4d0449b611bc24ae5c9636ac5b2a00e This patch fixes issue generated by commit ca93dcba3a92 ("staging: rtl8192e: Remove assert() macro") One negation was missed in conversion, therefore asserted message was always printed. For 1MB file downloaded via http, ~500 messages were generated. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch fixes issue generated by commit ca93dcba3a92
("staging: rtl8192e: Remove assert() macro")

One negation was missed in conversion, therefore
asserted message was always printed.
For 1MB file downloaded via http, ~500 messages
were generated.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8192e: Remove unnecessary externs 2015-08-15T01:51:56+00:00 Joe Perches joe@perches.com 2015-08-10T21:51:29+00:00 ee233d3e19d7a5624e872710b1a6f629a0e8ef4f Using 'extern' is not necessary for function prototypes. Miscellanea: o Reflow alignments Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Using 'extern' is not necessary for function prototypes.

Miscellanea:

o Reflow alignments

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8192e: Rework EEPROM handling code 2015-08-04T00:46:43+00:00 Mateusz Kulikowski mateusz.kulikowski@gmail.com 2015-07-30T21:48:50+00:00 08582d83e5a23aa2f6316421a4f14a44be3c8e32 Card configuration is stored in SPI EEPROM (93c46 or 93c56) working in 128|256x16 mode. Communication is handled using GPIO bitbang. >From behaviour perspective, delay after read was removed. It is not needed as we wait after reading GPIO mapped to PCI-E register - it should have no side effects. According to sample EEPROM datasheet (AT93Cx6), max frequency for worst case scenario (1.8V supply) is 250kHZ (vs. 1MHz for 5V). Driver generates ~50kHZ clock - margin should be big enough even for devices from other vendors. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Card configuration is stored in SPI EEPROM (93c46 or 93c56)
working in 128|256x16 mode.
Communication is handled using GPIO bitbang.

>From behaviour perspective, delay after read was removed.
It is not needed as we wait after reading GPIO mapped to
PCI-E register - it should have no side effects.

According to sample EEPROM datasheet (AT93Cx6), max frequency for
worst case scenario (1.8V supply) is 250kHZ (vs. 1MHz for 5V).
Driver generates ~50kHZ clock - margin should be big enough
even for devices from other vendors.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8192e: probe: iounmap mmio when probe fails 2015-07-31T23:21:37+00:00 Mateusz Kulikowski mateusz.kulikowski@gmail.com 2015-07-28T21:31:47+00:00 948fa942dc6bb4000bdf94901e99570b7636ed7c In case of probe failure, io memory was not released properly. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
In case of probe failure, io memory was not released properly.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8192e: Drop large switch in rtl92e_config_rf 2015-07-31T23:21:37+00:00 Mateusz Kulikowski mateusz.kulikowski@gmail.com 2015-07-28T21:31:46+00:00 cb7cca3ae8f152151104252298d2e1e91db6df92 The same steps were made for each RF path independently. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The same steps were made for each RF path independently.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8192e: Fix IW_IOCTL macro 2015-07-31T23:21:37+00:00 Mateusz Kulikowski mateusz.kulikowski@gmail.com 2015-07-28T21:31:45+00:00 976a06cc89e817e94b0d87cf55bb46134c494060 Macro caused checkpatch complaints - replace [] braces with () and use [] braces as array initializers. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Macro caused checkpatch complaints - replace [] braces with ()
and use [] braces as array initializers.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8192e: Remove phy_RF8256_Config_ParaFile 2015-07-31T23:21:37+00:00 Mateusz Kulikowski mateusz.kulikowski@gmail.com 2015-07-28T21:31:44+00:00 90959c3dfcb66cd8467ba0921469b62e42d7879c Merge function into rtl92e_config_rf as having them separated gives no benefit. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Merge function into rtl92e_config_rf as having them
separated gives no benefit.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8192e: Simplify rtl92e_set_bandwidth 2015-07-31T23:21:37+00:00 Mateusz Kulikowski mateusz.kulikowski@gmail.com 2015-07-28T21:31:43+00:00 72f1f75257de812137ee5110822370fadc4927f6 Move phy version check outside of the loop. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Move phy version check outside of the loop.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8192e: Simplify rtl92e_is_halfn_supported_by_ap 2015-07-31T23:21:37+00:00 Mateusz Kulikowski mateusz.kulikowski@gmail.com 2015-07-28T21:31:42+00:00 99d4f5d236eb6a1eaaddb7179a251f385f7e4c2b Function should return struct member - no extra logic is needed. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Function should return struct member - no extra logic is needed.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8192e: MgntActSet_RF_State: remove ProtectOrNot parameter 2015-07-31T23:21:37+00:00 Mateusz Kulikowski mateusz.kulikowski@gmail.com 2015-07-28T21:31:41+00:00 2937a5d272031eb3e189d4383587bc9f62621c43 It is set at the very beginning of function to a constant value. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
It is set at the very beginning of function to a constant value.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>