linux-stable.git/drivers/staging/rtl8192e, branch v3.2

Staging: rtl8192e: off by one in rtl8192_get_channel_map()

2011-09-27T00:26:03+00:00

COUNTRY_CODE_MAX is not a valid country code.  We're off by one here.
This gets passed to Dot11d_Channelmap() where it's used as an offset
into the ChannelPlan[] array.

Signed-off-by: Dan Carpenter 
Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Fix format warning

2011-09-06T23:53:38+00:00

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Fix various problems noted by smatch

2011-09-06T23:36:00+00:00

Smatch reports the following problems:

  CHECK   drivers/staging/rtl8192e/rtllib_softmac.c
drivers/staging/rtl8192e/rtllib_softmac.c +3143 rtllib_softmac_free(4) info: redundant null check on ieee->pDot11dInfo calling kfree()

  CHECK   drivers/staging/rtl8192e/rtllib_module.c
drivers/staging/rtl8192e/rtllib_module.c +198 free_rtllib(6) info: redundant null check on ieee->pHTInfo calling kfree()

  CHECK   drivers/staging/rtl8192e/rtl819x_TSProc.c
drivers/staging/rtl8192e/rtl819x_TSProc.c +280 SearchAdmitTRStream(52) error: potential null derefence 'pRet'.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Fix smatch warnings regarding large arrays on stack

2011-09-06T23:35:59+00:00

Smatch reports the follwing warnings:

  CHECK   drivers/staging/rtl8192e/rtllib_rx.c
drivers/staging/rtl8192e/rtllib_rx.c +552 RxReorderIndicatePacket(6) warn: 'prxbIndicateArray' puts 1024 bytes on stack

  CHECK   drivers/staging/rtl8192e/rtl819x_TSProc.c
drivers/staging/rtl8192e/rtl819x_TSProc.c +40 RxPktPendingTimeout(9) warn: 'stats_IndicateArray' puts 1024 bytes on stack

  CHECK   drivers/staging/rtl8192e/r8192E_phy.c
drivers/staging/rtl8192e/r8192E_phy.c +859 rtl8192_phy_SwChnlStepByStep(11) warn: function puts 797 bytes on stack

  CHECK   drivers/staging/rtl8192e/rtllib_rx.c
drivers/staging/rtl8192e/rtllib_rx.c +552 RxReorderIndicatePacket(6) warn: 'prxbIndicateArray' puts 1024 bytes on stack

These are fixed by adding the arrays in question as a union in a struct used
by nearly all routines.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Fix smatch error in r8192E_phy.c

2011-09-06T23:35:59+00:00

Smatch reports the following:

  CHECK   drivers/staging/rtl8192e/r8192E_phy.c
drivers/staging/rtl8192e/r8192E_phy.c +940 rtl8192_phy_SwChnlStepByStep(92) error: potential null derefence 'CurrentCmd'.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Fix smatch warning in rtl819x_BAProc.c

2011-09-06T23:35:58+00:00

Smatch outputs the following warning:

  CHECK   drivers/staging/rtl8192e/rtl819x_BAProc.c
drivers/staging/rtl8192e/rtl819x_BAProc.c +88 rtllib_ADDBA(12) warn: variable dereferenced before check 'ieee'

As ieee cannot be NULL at this point, remove all such checks.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Silence smatch info in r8192E_cmdpkt.c

2011-09-06T23:35:57+00:00

Smatch outputs the following informational message:

  CHECK   drivers/staging/rtl8192e/r8192E_cmdpkt.c
drivers/staging/rtl8192e/r8192E_cmdpkt.c +419 cmpk_message_handle_rx(77) info: ignoring unreachable code.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Fix smatch warning in rtl_wx.c

2011-09-06T23:35:57+00:00

Smatch reports the following warning:

  CHECK   drivers/staging/rtl8192e/rtl_wx.c

drivers/staging/rtl8192e/rtl_wx.c +262 r8192se_wx_set_radio(16) warn: inconsistent returns sem:&priv->wx_sem: locked (258) unlocked (262)

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Fix smatch info output for r8192E_dev.c

2011-09-06T23:35:57+00:00

Smatch reports the following informational output:

  CHECK   drivers/staging/rtl8192e/r8192E_dev.c
drivers/staging/rtl8192e/r8192E_dev.c +2404 ActUpdateChannelAccessSetting(13) info: ignoring unreachable code.
drivers/staging/rtl8192e/r8192E_dev.c +2404 ActUpdateChannelAccessSetting(13) info: ignoring unreachable code.

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Fix smatch error and warning in rtl_core.c

2011-09-06T23:35:56+00:00

Smatch shows the following errors:

  CHECK   drivers/staging/rtl8192e/rtl_core.c
drivers/staging/rtl8192e/rtl_core.c +600 rtl8192_qos_activate(7) warn: variable dereferenced before check 'priv'
drivers/staging/rtl8192e/rtl_core.c +1345 rtl8192_init(40) warn: 'dev->irq' was not released on error
drivers/staging/rtl8192e/rtl_core.c +2120 rtl8192_alloc_rx_desc_ring(43) error: potential null derefence 'entry'.
drivers/staging/rtl8192e/rtl_core.c +3010 rtl8192_pci_probe(153) warn: 'pmem_start' was not released on error

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman