linux-stable.git/drivers/staging/rtl8192e, branch linux-4.12.y

staging: rtl8192e: GetTs Fix invalid TID 7 warning.

2017-05-15T09:48:45+00:00

TID 7 is a valid value for QoS IEEE 802.11e.

The switch statement that follows states 7 is valid.

Remove function IsACValid and use the default case to filter
invalid TIDs.

Signed-off-by: Malcolm Priestley 
Cc: 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: rtl92e_get_eeprom_size Fix read size of EPROM_CMD.

2017-05-15T09:48:45+00:00

EPROM_CMD is 2 byte aligned on PCI map so calling with rtl92e_readl
will return invalid data so use rtl92e_readw.

The device is unable to select the right eeprom type.

Signed-off-by: Malcolm Priestley 
Cc: 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: fix 2 byte alignment of register BSSIDR.

2017-05-15T09:48:44+00:00

BSSIDR has two byte alignment on PCI ioremap correct the write
by swapping to 16 bits first.

This fixes a problem that the device associates fail because
the filter is not set correctly.

Signed-off-by: Malcolm Priestley 
Cc: 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: rtl92e_fill_tx_desc fix write to mapped out memory.

2017-05-15T09:48:44+00:00

The driver attempts to alter memory that is mapped to PCI device.

This is because tx_fwinfo_8190pci points to skb->data

Move the pci_map_single to when completed buffer is ready to be mapped with
psdec is empty to drop on mapping error.

Signed-off-by: Malcolm Priestley 
Cc: 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Fix embedded function names with func

2017-03-29T07:39:08+00:00

Prefer and make it generic by using %s and __func__ to print
functions name instead of embedding functions name in print statements

Signed-off-by: Suniel Mahesh 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Fix issues reported by checkpatch.pl

2017-03-23T13:30:05+00:00

Fixed the following checkpatch.pl checks:
spaces preferred around that 'operator', spacing provided
Logical continuations should be on the previous line, modified accordingly
Unnecessary parentheses around variables, removed
Please use a blank line after function/struct/union/enum declarations, used

Signed-off-by: Suniel Mahesh 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Rectify pointer comparisions with NULL

2017-03-23T13:30:03+00:00

This patch simplifies code by replacing explicit NULL comparison
with ! or unmark operator
Reported by checkpatch.pl for comparison to NULL could be
written '!foo' or 'foo'

Signed-off-by: Suniel Mahesh 
Signed-off-by: Greg Kroah-Hartman

Staging: rtl8192e - fixed style of block comments

2017-03-23T13:28:47+00:00

Fixed style of block comment across whole driver
Found using checkpatch

Signed-off-by: Derek Robson 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Remove multiple assignments

2017-03-12T13:46:34+00:00

This patch removes multiple assignments by factorizing them.
This was done with Coccinelle for the if branch. For the else part
the change was done manually. Braces were also added to the
else part to remove the checkpatch warning, "braces should be
on all arms of if-else statements".

@ identifier i1,i2; constant c; @@
- i1=i2=c;
+ i1=c;
+ i2=c;

Signed-off-by: Gargi Sharma 
Signed-off-by: Greg Kroah-Hartman

staging: rtl8192e: Indent the code

2017-03-09T17:18:20+00:00

Indent the code in order to follow the rules and to
increase the readability of the code.

Signed-off-by: Georgiana Rodica Chelu 
Signed-off-by: Greg Kroah-Hartman