linux-stable.git/drivers/staging/rtl8192e, branch linux-3.5.y Linux kernel stable tree staging: Remove test of is_broadcast with is_multicast 2012-05-09T20:52:23+00:00 Joe Perches joe@perches.com 2012-05-08T17:11:56+00:00 14fc42355f10199f39bc38dd2d3e9288a31e770c A broadcast packet is a multicast packet, no need to test twice. Reorder one defective test in rtl_core of is_multi_ether_addr before is_broadcast_ether_addr as the is_multi returns true for broadcast frames. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
A broadcast packet is a multicast packet, no need to test twice.

Reorder one defective test in rtl_core of is_multi_ether_addr
before is_broadcast_ether_addr as the is_multi returns true for
broadcast frames.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: "rtl8192e/r8192u" typo change ContiuneDiffCount. 2012-05-02T04:52:12+00:00 Justin P. Mattock justinmattock@gmail.com 2012-05-01T15:34:14+00:00 4c234ebcf4c98b20b8e3fa121b2382c375c3aa57 As mentioned by jesper juhl, we should probably change ContiuneDiffCount to ContinueDiffCount. Below you will find the changes to do so. I have compile tested this and everything builds with the changes, as for testing on the hardware I am unable to do. Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
As mentioned by jesper juhl, we should probably change ContiuneDiffCount
to ContinueDiffCount. Below you will find the changes to do so.  I have
compile tested this and everything builds with the changes, as for
testing on the hardware I am unable to do.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: rtl8192e: Fix typos. 2012-04-24T18:28:24+00:00 Justin P. Mattock justinmattock@gmail.com 2012-04-23T14:36:52+00:00 cd01712397ad428f443c05add5d7435e899c0ef1 Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> ACKed-by: Larry Finger <Larry.finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
ACKed-by: Larry Finger <Larry.finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: r8192e_pci: Change memcpy to memcmp 2012-04-20T22:12:12+00:00 Larry Finger Larry.Finger@lwfinger.net 2012-04-20T19:45:37+00:00 ea9f10f2fd207bb70a730ee3b356f75bc00ff41d Routine rtllib_MlmeDisassociateRequest() has a comparison of memcpy() with NULL, which makes no sense. Analysis of the code suggests that memcmp() was intended. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Routine rtllib_MlmeDisassociateRequest() has a comparison of memcpy()
with NULL, which makes no sense. Analysis of the code suggests that
memcmp() was intended.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: r8192e: Fix possible error in configuration 2012-04-18T23:58:16+00:00 Larry Finger Larry.Finger@lwfinger.net 2012-04-16T21:06:18+00:00 e0e3daddad36f8303ca3bbeab558ced00f4e7d3e It is possible to misconfigure a kernel by selecting the rtllib crypto routines without enabling the underlying support from the crypto library. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Acked-by: Sean MacLennan <seanm@seanm.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
It is possible to misconfigure a kernel by selecting the rtllib crypto
routines without enabling the underlying support from the crypto library.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Acked-by: Sean MacLennan <seanm@seanm.ca>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: rtl8192e: remove some dead code 2012-04-18T23:58:16+00:00 Dan Carpenter dan.carpenter@oracle.com 2012-04-17T06:45:59+00:00 6b56d2459be6ce0e87b18a4276fef5d1bc265320 We don't use the rxcmdpkt[] counters at all and we can remove them. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> ACKed-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
We don't use the rxcmdpkt[] counters at all and we can remove them.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: replace open-coded ARRAY_SIZEs 2012-04-10T22:25:55+00:00 Jim Cromie jim.cromie@gmail.com 2012-04-10T22:06:41+00:00 b330f606ed7591dc078acd856454e3a383299fb3 spatch http://coccinelle.lip6.fr/rules/array.cocci did these. Signed-off-by: Jim Cromie <jim.cromie@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
spatch http://coccinelle.lip6.fr/rules/array.cocci did these.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: Fix typo in multiple files 2012-04-10T17:31:01+00:00 Masanari Iida standby24x7@gmail.com 2012-04-06T14:33:52+00:00 73e2918990c0d0ba7866696d492a8090e4f9f396 Collect spelling typo in multiple files within staging directory. Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Collect spelling typo in multiple files within staging directory.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging/rtl8192e - fix typo in printk message 2012-04-10T16:24:34+00:00 Axel Köllhofer AxelKoellhofer@web.de 2012-03-22T21:49:55+00:00 96ddcd439871658b797289dde8fcead8bde73b68 In drivers/staging/rtl8192e/rtl8192e/rtl_core.c the follwing printk-message can be found: printk(KERN_ERR "rtl8193e: Unable to allocate space " This is quite obviously just a typo, all other similar messages use "rtl8192e" and the string "rtl8193e" does not occur anywhere else in the source of the driver. Signed-off-by: Axel Koellhofer <AxelKoellhofer@web.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
In drivers/staging/rtl8192e/rtl8192e/rtl_core.c the follwing printk-message can be found:

printk(KERN_ERR "rtl8193e: Unable to allocate space "

This is quite obviously just a typo, all other similar messages use
"rtl8192e" and the string "rtl8193e" does not occur anywhere else in the
source of the driver.

Signed-off-by:	Axel Koellhofer <AxelKoellhofer@web.de>

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
usermodehelper: use UMH_WAIT_PROC consistently 2012-03-23T23:58:41+00:00 Oleg Nesterov oleg@redhat.com 2012-03-23T22:02:46+00:00 70834d3070c3f3015ab5c05176d54bd4a0100546 A few call_usermodehelper() callers use the hardcoded constant instead of the proper UMH_WAIT_PROC, fix them. Reported-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> Signed-off-by: Oleg Nesterov <oleg@redhat.com> Cc: Lars Ellenberg <drbd-dev@lists.linbit.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Michal Januszewski <spock@gentoo.org> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> Cc: Kentaro Takeda <takedakn@nttdata.co.jp> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: James Morris <jmorris@namei.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
A few call_usermodehelper() callers use the hardcoded constant instead of
the proper UMH_WAIT_PROC, fix them.

Reported-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Lars Ellenberg <drbd-dev@lists.linbit.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michal Januszewski <spock@gentoo.org>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: Kentaro Takeda <takedakn@nttdata.co.jp>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: James Morris <jmorris@namei.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>