linux-stable.git/drivers/staging/rdma, branch v4.3

IB/hfi: Properly set permissions for user device files

2015-09-18T15:28:47+00:00

Some of the device files are required to be user accessible for PSM while
most should remain accessible only by root.

Add a parameter to hfi1_cdev_init which controls if the user should have access
to this device which places it in a different class with the appropriate
devnode callback.

In addition set the devnode call back for the existing class to be a bit more
explicit for those permissions.

Finally remove the unnecessary null check before class_destroy

Tested-by: Donald Dutile 
Signed-off-by: Haralanov, Mitko (mitko.haralanov@intel.com)
Signed-off-by: Ira Weiny 
Signed-off-by: Doug Ledford

IB/hfi1: mask vs shift confusion

2015-09-18T15:28:47+00:00

We are shifting by the _MASK macros instead of the _SHIFT ones.

Signed-off-by: Dan Carpenter 
Signed-off-by: Doug Ledford

IB/hfi1: clean up some defines

2015-09-18T15:28:47+00:00

I added spaces around operators so it matches kernel style because
normally "-1ULL" is a number and " - 1" is a subtract operation.  Also
removed some superflous "ULL" types so "1ULL" becomes "1".

Signed-off-by: Dan Carpenter 
Signed-off-by: Doug Ledford

IB/hfi1: info leak in get_ctxt_info()

2015-09-18T15:28:47+00:00

The cinfo struct has a hole after the last struct member so we need to
zero it out.  Otherwise we disclose some uninitialized stack data.

Signed-off-by: Dan Carpenter 
Signed-off-by: Doug Ledford

IB/hfi1: fix a locking bug

2015-09-18T15:28:47+00:00

mutex_trylock() returns zero on failure, not EBUSY.

Signed-off-by: Dan Carpenter 
Signed-off-by: Doug Ledford

IB/hfi1: checking for NULL instead of IS_ERR

2015-09-18T15:28:47+00:00

__get_txreq() returns an ERR_PTR() but this checks for NULL so it would
oops on failure.

Signed-off-by: Dan Carpenter 
Signed-off-by: Doug Ledford

IB/hfi1: fix sdma_descq_cnt parameter parsing

2015-09-18T15:28:47+00:00

The boolean tests should have been or-ed.

Reported-by: David Binderman 
Reviewed-by: Jubin John 
Signed-off-by: Mike Marciniszyn 
Signed-off-by: Doug Ledford

IB/hfi1: fix copy_to/from_user() error handling

2015-09-18T15:28:47+00:00

copy_to/from_user() returns the number of bytes which we were not able
to copy.  It doesn't return an error code.

Also a couple places had a printk() on error and I removed that because
people can take advantage of it to fill /var/log/messages with spam.

Signed-off-by: Dan Carpenter 
Acked-by: Mike Marciniszyn 
Signed-off-by: Doug Ledford

IB/hfi1: fix pstateinfo from returning improperly byteswapped value

2015-09-18T15:28:47+00:00

Byteswap link_width_downgrade_*_active values before sending on the wire.  In
addition properly define the Port State Info structure.

Reviewed-by: Dennis Dalessandro 
Reviewed-by: Christian Gomez 
Signed-off-by: Rimmer, Todd 
Signed-off-by: Ira Weiny 
Acked-by: Mike Marciniszyn 
Signed-off-by: Doug Ledford

IB/ehca: Deprecate driver, move to staging, schedule deletion

2015-09-11T22:13:35+00:00

The ehca driver is only supported on IBM machines with a custom EBus.
As they have opted to build their newer machines using more industry
standard technology and haven't really been pushing EBus capable
machines for a while, this driver can now safely be moved to the
staging area and scheduled for eventual removal.  This plan was brought
to IBM's attention and received their sign-off.

Cc: alexs@linux.vnet.ibm.com
Cc: hnguyen@de.ibm.com
Cc: raisch@de.ibm.com
Cc: stefan.roscher@de.ibm.com
Signed-off-by: Doug Ledford