linux-stable.git/drivers/staging/pi433, branch linux-4.20.y

staging: pi433: fix potential null dereference

2019-02-12T19:02:11+00:00

[ Upstream commit 64c4c4ca6c129a4191e8e1e91b2d5d9b8d08c518 ]

Add a test for successful call to cdev_alloc() to avoid
potential null dereference. Issue reported by smatch.

Signed-off-by: Michael Straube 
Fixes: 874bcba65f9a ("staging: pi433: New driver")
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

staging: pi433: eliminate a temporary variable

2018-08-27T10:07:56+00:00

We can just get rid of the "spi_address".  It's not clear what the
"address" part of the name means, and the type should have been a u8.

Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: pi433: fix error return code in pi433_probe()

2018-07-12T19:49:24+00:00

Fix to return a negative error code from the kthread_run() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun 
Signed-off-by: Greg Kroah-Hartman

staging: pi433: Make only one statement per line

2018-07-11T11:12:34+00:00

Lines containing multiple statements were broken into multiple
lines, increasing readability and complying with the coding standard.
This also fixes several checkpatch.pl errors complaining about
the lines being too long.

Signed-off-by: Sophie Matter 
Signed-off-by: Rico Schrage 
Signed-off-by: Greg Kroah-Hartman

staging: pi433: Use preferred commenting style

2018-07-11T11:12:34+00:00

For multi-line comments, the preferred commenting style from the
coding style Documentation was applied to the comments, meaning
almost blank lines at the beginning and end of the comment.
One changed comment includes a line over 80 characters, causing
checkpatch.pl to complain, however breaking this line would not
make much sense, so it is kept like it is.

Signed-off-by: Sophie Matter 
Signed-off-by: Rico Schrage 
Signed-off-by: Greg Kroah-Hartman

staging: pi433: Comply with 80 character column limit

2018-07-11T11:12:33+00:00

Lines have been split where it makes sense to shorten them in order
to comply with the coding standards and fix checkpatch.pl warnings.
There are still lines left that are too long, however breaking
those would impair readability.

Changes in v2:
 - now working on staging-next branch of the staging tree
 - the changes to the defines previously made are deleted
   due to readability

Signed-off-by: Sophie Matter 
Signed-off-by: Rico Schrage 
Signed-off-by: Greg Kroah-Hartman

staging: pi433: cleanup comments in rf69.h

2018-06-28T13:00:13+00:00

Fixes checkpatch warning:

  WARNING: line over 80 characters

Signed-off-by: Valentin Vidic 
Signed-off-by: Greg Kroah-Hartman

staging: pi433: add SPDX-License-Identifier tag

2018-06-28T13:00:13+00:00

Use GPL-2.0+ based on the license text in each of the files.

Signed-off-by: Valentin Vidic 
Signed-off-by: Greg Kroah-Hartman

staging: pi433: replace simple switch statements

2018-06-28T13:00:13+00:00

Use const array to map switch cases to resulting values.

Signed-off-by: Valentin Vidic 
Reviewed-by: Marcus Wolf 
Signed-off-by: Greg Kroah-Hartman

staging: pi433: fix race condition in pi433_open

2018-06-28T13:00:13+00:00

The device structure contains a useless non-atomic users counter which
is subject to race conditions. It has probably been created to handle
the case where remove is executed while operations are still executing
on open fds but this will never happen because of reference counts.

Drop the users counter and move rx buffer {de,}allocation to probe()
and remove(). Remove associated dead code from open() and release().
Remove related TODO entry from ioctl().

Signed-off-by: Hugo Lefeuvre 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman