linux-stable.git/drivers/staging/panel, branch v4.1

staging: panel: fix lcd type

2015-03-26T10:00:22+00:00

the lcd type as defined in the Kconfig is not matching in the code.
as a result the rs, rw and en pins were getting interchanged.
Kconfig defines the value of PANEL_LCD to be 1 if we select custom
configuration but in the code LCD_TYPE_CUSTOM is defined as 5.

my hardware is LCD_TYPE_CUSTOM, but the pins were assigned to it
as pins of LCD_TYPE_OLD, and it was not working.
Now values are corrected with referenece to the values defined in
Kconfig and it is working.
checked on JHD204A lcd with LCD_TYPE_CUSTOM configuration.

Cc:  # 2.6.32+
Signed-off-by: Sudip Mukherjee 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: remove initialization check

2015-03-20T13:06:12+00:00

no need to monitor init_in_progress now as keypad_send_key() can only
be called after the timer is initialized. and timer is initialized
from keypad_init() which is in the attach section and can only execute
after the module has initialized.

Signed-off-by: Sudip Mukherjee 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: return register value

2015-03-20T13:06:12+00:00

we were returning success even if the module failed to register.
now we are returning the actual return value, success or error.

Signed-off-by: Sudip Mukherjee 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: register reboot

2015-03-20T13:06:12+00:00

we donot need the reboot notifier in module init section, as the
notifier is used after lcd is initialized. so lets register for the
reboot notifier only after we have successfully attached to the
parallel port. and similarly unregister at detach.

Signed-off-by: Sudip Mukherjee 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: initialize lcd if lcd enabled

2015-03-07T00:31:58+00:00

initialiaze lcd parameters only if lcd is enabled.

Signed-off-by: Sudip Mukherjee 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: register driver after checking device

2015-03-07T00:31:57+00:00

register the driver only if lcd or keypad has been enabled and if
both are disabled then just exit.

Signed-off-by: Sudip Mukherjee 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: replace init_timer by setup_timer

2015-02-26T21:12:40+00:00

This patch replaces init_timer and the 2 step initialization of function
and data by setup_timer to make the code more concise.

The issue was discovered using the following coccinelle script:

@@
expression ds, e1, e2;
@@

-init_timer (&ds);
+setup_timer (&ds, e1, e2);
...
(
-ds.function = e1;
...
-ds.data = e2;
|
-ds.data = e2;
...
-ds.function = e1;
)

Signed-off-by: Aya Mahfouz 
Signed-off-by: Greg Kroah-Hartman

drivers/staging: use current->state helpers

2015-01-28T19:25:28+00:00

Call __set_current_state() instead of assigning the new state directly.
These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments,
keeping track of who changed the state.

Signed-off-by: Davidlohr Bueso 
Signed-off-by: Greg Kroah-Hartman

staging: panel: Remove magic numbers in LCD commands

2015-01-12T14:39:33+00:00

Get rid of magic numbers in LCD commands and replace them with defined
values, so that it's more obvious that the commands are doing.

Signed-off-by: Mariusz Gorski 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: Remove unused variable

2015-01-12T14:39:33+00:00

Remove lcd.left_shift because it is only written to at some places but
never read from.

Signed-off-by: Mariusz Gorski 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman