linux-stable.git/drivers/staging/panel, branch linux-3.19.y

staging: panel: fix lcd type

2015-05-06T20:01:45+00:00

commit 2c20d92dad5db6440cfa88d811b69fd605240ce4 upstream.

the lcd type as defined in the Kconfig is not matching in the code.
as a result the rs, rw and en pins were getting interchanged.
Kconfig defines the value of PANEL_LCD to be 1 if we select custom
configuration but in the code LCD_TYPE_CUSTOM is defined as 5.

my hardware is LCD_TYPE_CUSTOM, but the pins were assigned to it
as pins of LCD_TYPE_OLD, and it was not working.
Now values are corrected with referenece to the values defined in
Kconfig and it is working.
checked on JHD204A lcd with LCD_TYPE_CUSTOM configuration.

Signed-off-by: Sudip Mukherjee 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: Move LCD-related state into struct lcd

2014-12-03T00:34:35+00:00

Move more or less all LCD-related state into struct lcd
in order to get better cohesion; use bool instead of int
where it makes sense.

Signed-off-by: Mariusz Gorski 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: Remove more magic number comparison

2014-12-03T00:34:35+00:00

Use a defined value instead of magic number comparison
for checking whether a module param value has been set.

Signed-off-by: Mariusz Gorski 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: Refactor LCD init code

2014-12-03T00:34:34+00:00

Rework lcd_init method to make it a little bit more clear about
the precedence of the params, move LCD geometry and pins layout
to the LCD struct and thus make the LCD-related module params
effectively read-only.

Signed-off-by: Mariusz Gorski 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: Make two more module params read-only

2014-12-03T00:34:34+00:00

Make keypad_type and lcd_type module params read-only.
This step also starts making it more clear what is
the precedence of device params coming from different
sources (device profile, runtime module param values etc).

Signed-off-by: Mariusz Gorski 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: Start making module params read-only

2014-12-03T00:34:34+00:00

Start decoupling module params from the actual device state,
both for lcd and keypad, by keeping the params read-only
and moving the device state to related structs.

Signed-off-by: Mariusz Gorski 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: Use defined value or checking module params state

2014-12-03T00:34:34+00:00

Avoid magic number and use a comparison with a defined value instead
that checks whether module param has been set by the user to some
value at loading time.

Signed-off-by: Mariusz Gorski 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: Remove magic numbers

2014-12-03T00:34:34+00:00

Get rid of magic numbers indicating that the value of a module param
is not set. Use a defined value instead.

Signed-off-by: Mariusz Gorski 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: Call init function directly

2014-12-03T00:34:34+00:00

Remove useless function and let the kernel call the actual
init function directly.

Signed-off-by: Mariusz Gorski 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman

staging: panel: Set default parport module param value

2014-12-03T00:34:34+00:00

Set default parport module param value to DEFAULT_PARPORT so that
a if-block can be avoided.

Signed-off-by: Mariusz Gorski 
Acked-by: Willy Tarreau 
Signed-off-by: Greg Kroah-Hartman