linux-stable.git/drivers/staging/panel, branch linux-3.17.y

Staging: panel: fixed frivilous else statement warning

2014-07-10T22:12:51+00:00

Fixed one instance of the following checkpatch.pl warning in
panel.c:
WARNING: else is not generally useful after a break or return

Signed-off-by: Vincent Heuken 
Signed-off-by: Greg Kroah-Hartman

staging: panel: (coding style) Multiple assignments

2014-05-25T17:59:52+00:00

Style-only modifications to comply with checkpatch.pl --strict --file.
. Breaks down compound assignments.

Signed-off-by: Dominique van den Broeck 
Signed-off-by: Greg Kroah-Hartman

staging: panel: (coding style) Line alignments and malloc sizeof

2014-05-23T11:33:57+00:00

Style-only modifications to comply with checkpatch.pl --strict --file.
. Correctly realigns the lines that needed to be ;
. Suppress useless blank rows ;
. Fix sizeof() issues in various -malloc() functions.

Signed-off-by: Dominique van den Broeck 
Signed-off-by: Greg Kroah-Hartman

staging: panel: (coding style) Matching braces

2014-05-23T11:33:57+00:00

Style-only modifications to comply with checkpatch.pl --strict --file.
. Adds every missing brace in condition statements.

Signed-off-by: Dominique van den Broeck 
Signed-off-by: Greg Kroah-Hartman

staging: panel: fix regression in lcd_write

2014-05-23T11:33:56+00:00

This patch fix a regression in lcd_write caused by commit
70a8c3eb8546cefe40fb0bc7991e8899b7b91075

Signed-off-by: Bastien Armand 
Signed-off-by: Greg Kroah-Hartman

staging: panel: add blank lines after declarations

2014-04-18T23:17:12+00:00

This patch fixes "Missing a blank line after declarations" checkpatch warnings in panel.c.

Signed-off-by: Bastien Armand 
Signed-off-by: Greg Kroah-Hartman

staging: panel: fix sparse warnings in keypad_read

2014-04-18T23:17:12+00:00

This patch fixes two sparse warnings related to keypad_read :
warning: incorrect type in argument 1 (different address spaces)
warning: incorrect type in initializer (incompatible argument 2 (different address spaces))

Signed-off-by: Bastien Armand 
Signed-off-by: Greg Kroah-Hartman

staging: panel: fix sparse warnings in lcd_write

2014-04-18T23:17:12+00:00

This patch fixes two sparse warnings related to lcd_write :
warning: incorrect type in argument 1 (different address spaces)
warning: incorrect type in initializer (incompatible argument 2
(different address spaces))

lcd_write can be used from kernel space (in panel_lcd_print) or from user
space. So we introduce the lcd_write_char function that will write a char to
the device. We modify lcd_write and panel_lcd_print to use it. Finally we add
__user annotation missing in lcd_write.

Signed-off-by: Bastien Armand 
Signed-off-by: Greg Kroah-Hartman

staging: panel: replace del_timer by del_timer_sync

2014-04-18T23:16:58+00:00

Use del_timer_sync to ensure that the timer is stopped on all CPUs before
the driver exists.

This change was suggested by Thomas Gleixner.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// 
@r@
declarer name module_exit;
identifier ex;
@@

module_exit(ex);

@@
identifier r.ex;
@@

ex(...) {
  <...
- del_timer
+ del_timer_sync
    (...)
  ...>
}
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

Staging: panel: Fix quoted string split across line in panel.c

2014-02-27T20:29:24+00:00

This patch fixes the following checkpatch.pl warning in panel.c:
WARNING: quoted string split across lines

Signed-off-by: Monam Agarwal 
Signed-off-by: Greg Kroah-Hartman