linux-stable.git/drivers/staging/panel, branch linux-3.10.y Linux kernel stable tree staging: panel: fix lcd type 2015-05-13T12:15:42+00:00 Sudip Mukherjee sudipm.mukherjee@gmail.com 2015-03-24T10:59:32+00:00 b68cec9dc947f92bf8cdbe9cadcbb7583f5b3d14 commit 2c20d92dad5db6440cfa88d811b69fd605240ce4 upstream. the lcd type as defined in the Kconfig is not matching in the code. as a result the rs, rw and en pins were getting interchanged. Kconfig defines the value of PANEL_LCD to be 1 if we select custom configuration but in the code LCD_TYPE_CUSTOM is defined as 5. my hardware is LCD_TYPE_CUSTOM, but the pins were assigned to it as pins of LCD_TYPE_OLD, and it was not working. Now values are corrected with referenece to the values defined in Kconfig and it is working. checked on JHD204A lcd with LCD_TYPE_CUSTOM configuration. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Acked-by: Willy Tarreau <w@1wt.eu> [wt: backport to 3.10 and 3.14] Signed-off-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
commit 2c20d92dad5db6440cfa88d811b69fd605240ce4 upstream.

the lcd type as defined in the Kconfig is not matching in the code.
as a result the rs, rw and en pins were getting interchanged.
Kconfig defines the value of PANEL_LCD to be 1 if we select custom
configuration but in the code LCD_TYPE_CUSTOM is defined as 5.

my hardware is LCD_TYPE_CUSTOM, but the pins were assigned to it
as pins of LCD_TYPE_OLD, and it was not working.
Now values are corrected with referenece to the values defined in
Kconfig and it is working.
checked on JHD204A lcd with LCD_TYPE_CUSTOM configuration.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Acked-by: Willy Tarreau <w@1wt.eu>
[wt: backport to 3.10 and 3.14]
Signed-off-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging/panel: Mark local functions/structs static and add const if applicable (fix sparse warnings) 2013-02-15T18:20:14+00:00 Peter Huewe peterhuewe@gmx.de 2013-02-15T12:47:05+00:00 36d2041a3d57b9542bb93c94df4f9ebf3a1aee32 sparse complains about the following functions: panel.c:188:1: warning: symbol 'logical_inputs' was not declared. Should it be static? panel.c:569:6: warning: symbol 'old_keypad_profile' was not declared. Should it be static? panel.c:580:6: warning: symbol 'new_keypad_profile' was not declared. Should it be static? panel.c:593:6: warning: symbol 'nexcom_keypad_profile' was not declared. Should it be static? panel.c:672:6: warning: symbol 'pin_to_bits' was not declared. Should it be static? panel.c:1375:6: warning: symbol 'panel_lcd_print' was not declared. Should it be static? panel.c:1382:6: warning: symbol 'lcd_init' was not declared. Should it be static? panel.c:2181:5: warning: symbol 'panel_init' was not declared. Should it be static? Add the static keyword to silence these warnings and make sparse happy. If structs or function parameters are used readonly they are also marked as const. CC: David Howells <dhowells@redhat.com> Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
sparse complains about the following functions:
panel.c:188:1: warning: symbol 'logical_inputs' was not declared. Should it be static?
panel.c:569:6: warning: symbol 'old_keypad_profile' was not declared. Should it be static?
panel.c:580:6: warning: symbol 'new_keypad_profile' was not declared. Should it be static?
panel.c:593:6: warning: symbol 'nexcom_keypad_profile' was not declared. Should it be static?
panel.c:672:6: warning: symbol 'pin_to_bits' was not declared. Should it be static?
panel.c:1375:6: warning: symbol 'panel_lcd_print' was not declared. Should it be static?
panel.c:1382:6: warning: symbol 'lcd_init' was not declared. Should it be static?
panel.c:2181:5: warning: symbol 'panel_init' was not declared. Should it be static?

Add the static keyword to silence these warnings and make sparse happy.

If structs or function parameters are used readonly they are also marked
as const.

CC: David Howells <dhowells@redhat.com>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: panel: pass correct lengths to keypad_send_key() 2012-11-30T02:16:15+00:00 Dan Carpenter dan.carpenter@oracle.com 2012-11-29T14:38:35+00:00 a171516c3490fed2a06bc621f9ef5cc1e0e6749e We changed the sizeof() statements in 429ccf058b "staging:panel: Fixed coding conventions." so that they could fit inside the 80 character line limit. Unfortunately, the new sizeof() statements are a smaller size. This reverts it. There isn't a nice way to stay within the 80 character limit without a re-work so I've gone over. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
We changed the sizeof() statements in 429ccf058b "staging:panel: Fixed
coding conventions." so that they could fit inside the 80 character
line limit.  Unfortunately, the new sizeof() statements are a smaller
size.  This reverts it.

There isn't a nice way to stay within the 80 character limit without
a re-work so I've gone over.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: Fix misspellings of "whether". 2012-09-21T15:56:40+00:00 Adam Buchbinder adam.buchbinder@gmail.com 2012-09-20T01:51:07+00:00 f2635894e8e786d7c93a21f24efb690981d15842 "Whether" is spelled "wether" in several places. This fixes those that are in the staging tree. Signed-off-by: Adam Buchbinder <adam.buchbinder@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
"Whether" is spelled "wether" in several places. This fixes those that
are in the staging tree.

Signed-off-by: Adam Buchbinder <adam.buchbinder@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: panel: fix spinlock trylock failure on UP 2012-09-10T18:23:32+00:00 Fengguang Wu fengguang.wu@intel.com 2012-09-09T08:23:46+00:00 d4d2dbcaedb9334d0c462129099346d617f61768 Use spin_lock_irq() to quiet warning: [ 8.232324] BUG: spinlock trylock failure on UP on CPU#0, reboot/85 [ 8.234138] lock: c161c760, .magic: dead4ead, .owner: reboot/85, .owner_cpu: 0 [ 8.236132] Pid: 85, comm: reboot Not tainted 3.4.0-rc7-00656-g82163ed #5 [ 8.237965] Call Trace: [ 8.238648] [<c13dfd20>] ? printk+0x18/0x1a [ 8.239827] [<c122a5e0>] spin_dump+0x80/0xd0 [ 8.241016] [<c122a652>] spin_bug+0x22/0x30 [ 8.242181] [<c122a93b>] do_raw_spin_trylock+0x5b/0x70 [ 8.243611] [<c13e8bae>] _raw_spin_trylock+0xe/0x60 [ 8.244975] [<c1392230>] ? keypad_send_key.constprop.9+0xe0/0xe0 ==> [ 8.246638] [<c13922ea>] panel_scan_timer+0xba/0x570 [ 8.248019] [<c1392230>] ? keypad_send_key.constprop.9+0xe0/0xe0 [ 8.249689] [<c102f6f5>] run_timer_softirq+0x1e5/0x370 [ 8.251191] [<c102f645>] ? run_timer_softirq+0x135/0x370 [ 8.252718] [<c1392230>] ? keypad_send_key.constprop.9+0xe0/0xe0 [ 8.254462] [<c102a592>] __do_softirq+0xc2/0x1c0 [ 8.255758] [<c102a4d0>] ? local_bh_enable_ip+0x130/0x130 [ 8.257228] <IRQ> [<c102a855>] ? irq_exit+0x65/0x70 [ 8.258647] [<c1013ff9>] ? smp_apic_timer_interrupt+0x49/0x80 [ 8.260226] [<c13e96c1>] ? apic_timer_interrupt+0x31/0x38 [ 8.261737] [<c12700e0>] ? drm_vm_open_locked+0x70/0xb0 [ 8.263166] [<c122489a>] ? delay_tsc+0x1a/0x30 [ 8.264452] [<c12248c9>] ? __delay+0x9/0x10 [ 8.265621] [<c12248ec>] ? __const_udelay+0x1c/0x20 ==> [ 8.266967] [<c139136c>] ? lcd_clear_fast_p8+0x9c/0xe0 [ 8.268386] [<c1391a66>] ? lcd_write+0x226/0x810 [ 8.269653] [<c1367900>] ? md_set_readonly+0xc0/0xc0 [ 8.271013] [<c122a9ed>] ? do_raw_spin_unlock+0x9d/0xe0 [ 8.272470] [<c1392a98>] ? panel_lcd_print+0x38/0x40 [ 8.273837] [<c1392ace>] ? panel_notify_sys+0x2e/0x60 [ 8.275224] [<c1046634>] ? notifier_call_chain+0x84/0xb0 [ 8.276754] [<c10469ce>] ? __blocking_notifier_call_chain+0x3e/0x60 [ 8.278576] [<c1046a0a>] ? blocking_notifier_call_chain+0x1a/0x20 [ 8.280267] [<c1036a14>] ? kernel_restart_prepare+0x14/0x40 [ 8.281901] [<c1036a8e>] ? kernel_restart+0xe/0x50 [ 8.283216] [<c1036ce9>] ? sys_reboot+0x149/0x1e0 [ 8.284532] [<c10b3fb3>] ? handle_pte_fault+0x93/0xd70 [ 8.285956] [<c1019e35>] ? do_page_fault+0x215/0x5e0 [ 8.287330] [<c101a113>] ? do_page_fault+0x4f3/0x5e0 [ 8.288704] [<c1045ac6>] ? up_read+0x16/0x30 [ 8.289890] [<c101a113>] ? do_page_fault+0x4f3/0x5e0 [ 8.291252] [<c10d4486>] ? iterate_supers+0x86/0xd0 [ 8.292615] [<c122a9ed>] ? do_raw_spin_unlock+0x9d/0xe0 [ 8.294049] [<c13e8dcd>] ? _raw_spin_unlock+0x1d/0x20 [ 8.295449] [<c10d44ab>] ? iterate_supers+0xab/0xd0 [ 8.296795] [<c10fb620>] ? __sync_filesystem+0xa0/0xa0 [ 8.298199] [<c13e9b03>] ? sysenter_do_call+0x12/0x37 [ 8.306899] Restarting system. [ 8.307747] machine restart Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Use spin_lock_irq() to quiet warning:

         [    8.232324] BUG: spinlock trylock failure on UP on CPU#0, reboot/85
         [    8.234138]  lock: c161c760, .magic: dead4ead, .owner: reboot/85, .owner_cpu: 0
         [    8.236132] Pid: 85, comm: reboot Not tainted 3.4.0-rc7-00656-g82163ed #5
         [    8.237965] Call Trace:
         [    8.238648]  [<c13dfd20>] ? printk+0x18/0x1a
         [    8.239827]  [<c122a5e0>] spin_dump+0x80/0xd0
         [    8.241016]  [<c122a652>] spin_bug+0x22/0x30
         [    8.242181]  [<c122a93b>] do_raw_spin_trylock+0x5b/0x70
         [    8.243611]  [<c13e8bae>] _raw_spin_trylock+0xe/0x60
         [    8.244975]  [<c1392230>] ? keypad_send_key.constprop.9+0xe0/0xe0
 ==>     [    8.246638]  [<c13922ea>] panel_scan_timer+0xba/0x570
         [    8.248019]  [<c1392230>] ? keypad_send_key.constprop.9+0xe0/0xe0
         [    8.249689]  [<c102f6f5>] run_timer_softirq+0x1e5/0x370
         [    8.251191]  [<c102f645>] ? run_timer_softirq+0x135/0x370
         [    8.252718]  [<c1392230>] ? keypad_send_key.constprop.9+0xe0/0xe0
         [    8.254462]  [<c102a592>] __do_softirq+0xc2/0x1c0
         [    8.255758]  [<c102a4d0>] ? local_bh_enable_ip+0x130/0x130
         [    8.257228]  <IRQ>  [<c102a855>] ? irq_exit+0x65/0x70
         [    8.258647]  [<c1013ff9>] ? smp_apic_timer_interrupt+0x49/0x80
         [    8.260226]  [<c13e96c1>] ? apic_timer_interrupt+0x31/0x38
         [    8.261737]  [<c12700e0>] ? drm_vm_open_locked+0x70/0xb0
         [    8.263166]  [<c122489a>] ? delay_tsc+0x1a/0x30
         [    8.264452]  [<c12248c9>] ? __delay+0x9/0x10
         [    8.265621]  [<c12248ec>] ? __const_udelay+0x1c/0x20
 ==>     [    8.266967]  [<c139136c>] ? lcd_clear_fast_p8+0x9c/0xe0
         [    8.268386]  [<c1391a66>] ? lcd_write+0x226/0x810
         [    8.269653]  [<c1367900>] ? md_set_readonly+0xc0/0xc0
         [    8.271013]  [<c122a9ed>] ? do_raw_spin_unlock+0x9d/0xe0
         [    8.272470]  [<c1392a98>] ? panel_lcd_print+0x38/0x40
         [    8.273837]  [<c1392ace>] ? panel_notify_sys+0x2e/0x60
         [    8.275224]  [<c1046634>] ? notifier_call_chain+0x84/0xb0
         [    8.276754]  [<c10469ce>] ? __blocking_notifier_call_chain+0x3e/0x60
         [    8.278576]  [<c1046a0a>] ? blocking_notifier_call_chain+0x1a/0x20
         [    8.280267]  [<c1036a14>] ? kernel_restart_prepare+0x14/0x40
         [    8.281901]  [<c1036a8e>] ? kernel_restart+0xe/0x50
         [    8.283216]  [<c1036ce9>] ? sys_reboot+0x149/0x1e0
         [    8.284532]  [<c10b3fb3>] ? handle_pte_fault+0x93/0xd70
         [    8.285956]  [<c1019e35>] ? do_page_fault+0x215/0x5e0
         [    8.287330]  [<c101a113>] ? do_page_fault+0x4f3/0x5e0
         [    8.288704]  [<c1045ac6>] ? up_read+0x16/0x30
         [    8.289890]  [<c101a113>] ? do_page_fault+0x4f3/0x5e0
         [    8.291252]  [<c10d4486>] ? iterate_supers+0x86/0xd0
         [    8.292615]  [<c122a9ed>] ? do_raw_spin_unlock+0x9d/0xe0
         [    8.294049]  [<c13e8dcd>] ? _raw_spin_unlock+0x1d/0x20
         [    8.295449]  [<c10d44ab>] ? iterate_supers+0xab/0xd0
         [    8.296795]  [<c10fb620>] ? __sync_filesystem+0xa0/0xa0
         [    8.298199]  [<c13e9b03>] ? sysenter_do_call+0x12/0x37
         [    8.306899] Restarting system.
         [    8.307747] machine restart

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: panel: fix checkpatch warnings 2012-08-14T02:25:48+00:00 Toshiaki Yamane yamanetoshi@gmail.com 2012-07-25T03:18:12+00:00 6ebb56d974b2c0b31effd1bb2bde554582a9ebd8 Now checkpatch clean. $ find drivers/staging/panel -name "*.[ch]"|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut -f3- -d":"|sort |uniq -c|sort -n 2 WARNING: Single statement macros should not use a do {} while (0) loop Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Now checkpatch clean.

$ find drivers/staging/panel -name "*.[ch]"|xargs ./scripts/checkpatch.pl \
-f --terse --nosummary|cut -f3- -d":"|sort |uniq -c|sort -n

2  WARNING: Single statement macros should not use a do {} while (0) loop

Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: panel: Use pr_info(...) rather than printk(KERN_INFO 2012-07-17T01:57:26+00:00 Toshiaki Yamane yamanetoshi@gmail.com 2012-07-12T13:01:00+00:00 493aa896cbed9e5a60f498076d4e3145335cf4c9 -Added pr_fmt. -Converted printk(KERN_INFO to pr_info -Removed embedded message prefixes. Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
-Added pr_fmt.
-Converted printk(KERN_INFO to pr_info
-Removed embedded message prefixes.

Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: panel: Use pr_err(...) rather than printk(KERN_ERR ...) 2012-07-17T01:57:26+00:00 Toshiaki Yamane yamanetoshi@gmail.com 2012-07-12T13:01:17+00:00 eb073a9bf2b6edf8cf69eb393a1e511942cd1c64 -Removed unnecessary OOM messages. -Removed embedded message prefixes. -Added __func__ to some pr_err messages. -Converted printk(KERN_ERR to pr_err -Refactored split printk strings onto a single line -Removed the space before the '!'. Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
-Removed unnecessary OOM messages.
-Removed embedded message prefixes.
-Added __func__ to some pr_err messages.
-Converted printk(KERN_ERR to pr_err
-Refactored split printk strings onto a single line
-Removed the space before the '!'.

Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: panel: Remove printk(KERN_DEBUG ...) located in the #if 0 block 2012-07-17T01:57:22+00:00 Toshiaki Yamane yamanetoshi@gmail.com 2012-07-12T13:00:33+00:00 6622bcd64f7432b99718b373fe6231992e832c9e Deleted #if 0 blocks Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Deleted #if 0 blocks

Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging:panel:panel.c Fix typo in staging:panel 2012-04-10T16:29:21+00:00 Justin P. Mattock justinmattock@gmail.com 2012-03-19T15:17:52+00:00 6975e183bb59dd6cc281247925092ca42ab7e1d5 The below patch fixes a typo I found while reading. Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> Cc: Willy Tarreau <willy@meta-x.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The below patch fixes a typo I found while reading.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Cc: Willy Tarreau <willy@meta-x.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>