linux-stable.git/drivers/staging/most, branch v6.4

staging: most: dim2: Convert to platform remove callback returning void

2023-04-03T19:49:54+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20230403154014.2564054-18-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman

staging: most: fix line ending with '(' in dim2/

2023-03-25T08:47:27+00:00

Splitting function header to multiple lines because of 80 characters per
line limit, results in ending the function call line with '('.
This leads to CHECK reported by checkpatch.pl

Move the function parameters right after the '(' in the function call
line. Align the rest of the parameters to the opening parenthesis.

Signed-off-by: Khadija Kamran 
Link: https://lore.kernel.org/r/ZByu29jb1mE3KOsn@khadija-virtual-machine
Signed-off-by: Greg Kroah-Hartman

staging: most: fix line ending with '(' in video/

2023-03-25T08:47:26+00:00

Splitting function header to multiple lines because of 80 characters per
line limit, results in ending the function call line with '('.
This leads to CHECK reported by checkpatch.pl

Move the function parameters right after the '(' in the function call
line.

Signed-off-by: Khadija Kamran 
Link: https://lore.kernel.org/r/ZBytWDocM7XbXkRx@khadija-virtual-machine
Signed-off-by: Greg Kroah-Hartman

staging: most: remove extra blank line

2023-03-25T08:47:24+00:00

Remove extra blank line reported by checkpatch script.

Signed-off-by: Khadija Kamran 
Link: https://lore.kernel.org/r/ZBsPOk3TgQTfNAAK@khadija-virtual-machine
Signed-off-by: Greg Kroah-Hartman

staging: most: define iface_to_hdm as an inline function

2023-03-22T09:17:17+00:00

Convert `iface_to_hdm` macro into a static inline function.
it is not great to have macro that use `container_of` macro,
because from looking at the definition one cannot tell
what type it applies to.

One can get the same benefit from an efficiency point of view
by making an inline function.

Suggested-by: Julia Lawall 
Signed-off-by: Menna Mahmoud 
Link: https://lore.kernel.org/r/20230320212239.22452-1-eng.mennamahmoud.mm@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: use inline functions for to_hdm

2023-03-22T09:17:14+00:00

Convert `to_hdm` macro into a static inline function.
it is not great to have macro that use `container_of` macro,
because from looking at the definition one cannot tell
what type it applies to.

One can get the same benefit from an efficiency point of view
by making an inline function.

Suggested-by: Julia Lawall 
Signed-off-by: Menna Mahmoud 
Link: https://lore.kernel.org/r/20230320103356.6498-1-eng.mennamahmoud.mm@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: Use devm_platform_get_and_ioremap_resource()

2023-03-08T16:02:52+00:00

According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li 
Link: https://lore.kernel.org/r/20230308063653.92879-1-yang.lee@linux.alibaba.com
Signed-off-by: Greg Kroah-Hartman

staging: most: i2c: Convert to i2c's .probe_new()

2022-11-22T12:23:25+00:00

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20221118224540.619276-570-uwe@kleine-koenig.org
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: correct misleading struct type name

2022-10-22T07:59:49+00:00

Correct the misleading struct type name dim_ch_state_t to dim_ch_state
since this not a typedef but a normal structure declaration.

Suggested-by: Julia Lawall 
Signed-off-by: Deepak R Varma 
Link: https://lore.kernel.org/r/Y1GDQO+06fD24Pf/@debian-BULLSEYE-live-builder-AMD64
Signed-off-by: Greg Kroah-Hartman

i2c: Make remove callback return void

2022-08-16T10:46:26+00:00

The value returned by an i2c driver's remove function is mostly ignored.
(Only an error message is printed if the value is non-zero that the
error is ignored.)

So change the prototype of the remove function to return no value. This
way driver authors are not tempted to assume that passing an error to
the upper layer is a good idea. All drivers are adapted accordingly.
There is no intended change of behaviour, all callbacks were prepared to
return 0 before.

Reviewed-by: Peter Senna Tschudin 
Reviewed-by: Jeremy Kerr 
Reviewed-by: Benjamin Mugnier 
Reviewed-by: Javier Martinez Canillas 
Reviewed-by: Crt Mori 
Reviewed-by: Heikki Krogerus 
Acked-by: Greg Kroah-Hartman 
Acked-by: Marek Behún  # for leds-turris-omnia
Acked-by: Andy Shevchenko 
Reviewed-by: Petr Machata  # for mlxsw
Reviewed-by: Maximilian Luz  # for surface3_power
Acked-by: Srinivas Pandruvada  # for bmc150-accel-i2c + kxcjk-1013
Reviewed-by: Hans Verkuil  # for media/* + staging/media/*
Acked-by: Miguel Ojeda  # for auxdisplay/ht16k33 + auxdisplay/lcd2s
Reviewed-by: Luca Ceresoli  # for versaclock5
Reviewed-by: Ajay Gupta  # for ucsi_ccg
Acked-by: Jonathan Cameron  # for iio
Acked-by: Peter Rosin  # for i2c-mux-*, max9860
Acked-by: Adrien Grassein  # for lontium-lt8912b
Reviewed-by: Jean Delvare  # for hwmon, i2c-core and i2c/muxes
Acked-by: Corey Minyard  # for IPMI
Reviewed-by: Vladimir Oltean 
Acked-by: Dmitry Torokhov 
Acked-by: Sebastian Reichel  # for drivers/power
Acked-by: Krzysztof Hałasa 
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Wolfram Sang