linux-stable.git/drivers/staging/most, branch linux-5.0.y

staging: most: sound: pass correct device when creating a sound card

2019-05-10T16:36:04+00:00

commit 98592c1faca82a9024a64e4ecead68b19f81c299 upstream.

This patch fixes the usage of the wrong struct device when calling
function snd_card_new.

Reported-by: Eugeniu Rosca 
Signed-off-by: Christian Gromm 
Fixes: 69c90cf1b2fa ("staging: most: sound: call snd_card_new with struct device")
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

staging: most: cdev: fix chrdev_region leak in mod_exit

2019-05-10T16:36:04+00:00

commit af708900e9a48c0aa46070c8a8cdf0608a1d2025 upstream.

It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0
commit [1] missed to fix the memory leak in mod_exit function.

Do it now.

[0] aba258b7310167 ("staging: most: cdev: fix chrdev_region leak")
[1] https://github.com/microchip-ais/linux/commit/a2d8f7ae7ea381
    ("staging: most: cdev: fix leak for chrdev_region")

Signed-off-by: Suresh Udipi 
Signed-off-by: Eugeniu Rosca 
Acked-by: Christian Gromm 
Fixes: aba258b73101 ("staging: most: cdev: fix chrdev_region leak")
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

staging: most: core: use device description as name

2019-04-27T07:37:39+00:00

commit 131ac62253dba79daf4a6d83ab12293d2b9863d3 upstream.

This patch uses the device description to clearly identity a device
attached to the bus. It is needed as the currently useed mdevX
notation is not sufficiant in case more than one network
interface controller is being used at the same time.

Cc: stable@vger.kernel.org
Signed-off-by: Christian Gromm 
Signed-off-by: Greg Kroah-Hartman

staging: most: sound: replace snprintf with strscpy

2018-12-19T07:28:22+00:00

Using snprintf without a format specifier is potentially risky if
the string device_name contains format specifiers. Replace this with
the safer and more efficient strscpy.

Cleans up clang warning:
drivers/staging/most/sound/sound.c:673:41: warning: format string is not
a string literal (potentially insecure) [-Wformat-security]

Signed-off-by: Colin Ian King 
Signed-off-by: Greg Kroah-Hartman

staging: most: Documentation: add information to driver_usage file

2018-12-17T15:10:20+00:00

This patch updates driver_usage.txt file to reflect the latest changes
that this patch set introduces.

Signed-off-by: Christian Gromm 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: most: sound: remove channel number from ALSA card's long name

2018-12-17T15:10:20+00:00

Adding the channel number to the name of the sound card is wrong,
as the card does not represent a single streaming channel of the
MOST device.

Signed-off-by: Christian Gromm 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: most: sound: use static name for ALSA card

2018-12-17T15:10:20+00:00

This patch uses a static name for the sound card's short name and
long name. Having the card names configurable doesn't make sense
anymore, as the card represents the same physical hardware.

Signed-off-by: Christian Gromm 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: most: sound: rename variable

2018-12-17T15:10:20+00:00

Since the channels of a MOST device are now being represented as
individual PCM devices of one sound card, the variable card_name is not
suitable anymore to describe them. Therefore, this patch renames the
variable to device_name.

Signed-off-by: Christian Gromm 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: most: sound: correct label name

2018-12-17T15:10:20+00:00

This patch fixes the lable name that is used to jump to error
handling section of function audio_probe_channel() in case
something went wrong.

Signed-off-by: Christian Gromm 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: most: sound: create one sound card w/ multiple PCM devices per MOST device

2018-12-17T15:10:20+00:00

This patch avoids that a sound card is created and registered with ALSA
every time a channel is being linked. Instead the channels are hooked on
the same card, which is registered not until the final link has been added
to the component. The string provided by user space that used to be the
card name becomes the PCM device name. The user space API to add a link is
being expanded by a "create" flag to trigger the registration.

Signed-off-by: Christian Gromm 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman