linux-stable.git/drivers/staging/most, branch linux-4.8.y

Staging: most: Remove __cplusplus check in header files

2016-03-28T14:30:36+00:00

Remove unnecessary __cplusplus check in header files as it is not
required.

Signed-off-by: PrasannaKumar Muralidharan 
Signed-off-by: Greg Kroah-Hartman

Staging: most: Remove atomic_counter_t typedef

2016-03-28T14:30:36+00:00

Remove atomic_counter_t typedef, use int instead.

Signed-off-by: PrasannaKumar Muralidharan 
Signed-off-by: Greg Kroah-Hartman

staging: most: hdm-dim2: Remove possible dereference error

2016-03-23T02:22:13+00:00

Commit 3eced21a5afb ("staging: most: hdm-dim2: Replace request_irq
with devm_request_irq") introduced the following static checker
warning:

drivers/staging/most/hdm-dim2/dim2_hdm.c:841 dim2_probe() error: 'dev->netinfo_task' dereferencing possible ERR_PTR()

Remove the bug introduced by the commit due to change in control flow
by returning PTR_ERR immediately rather than returning at the end of
the function since we do not need to free anything.

Fixes: 3eced21a5afb
Signed-off-by: Amitoj Kaur Chawla 
Signed-off-by: Greg Kroah-Hartman

staging: most: hdm-usb: Remove invalid reference error

2016-03-12T06:09:09+00:00

commit e3479f77("staging: most: hdm-usb: Remove create_workqueue()")
cancel_work_sync(&anchor->clear_work_obj) is introduced after freeing
`anchor` causing a invalid reference error. This patch removes this
error by shifting the call to cancel_work_sync before freeing
`anchor`.

Signed-off-by: Amitoj Kaur Chawla 
Signed-off-by: Greg Kroah-Hartman

Staging: most: Use usb_endpoint_dir_in(endpoint) instead of (endpoint->bEndpointAddress & USB_DIR_IN).

2016-03-11T03:26:05+00:00

Use usb_endpoint_dir_in(endpoint) instead of (endpoint->bEndpointAddress & USB_DIR_IN) to check if the endpoint has IN direction.
This correction is based on following semantic patch,

@@
struct usb_endpoint_descriptor *endpoint;
expression E;
@@

(
- endpoint->bEndpointAddress & USB_DIR_IN
+ usb_endpoint_dir_in(endpoint)
|
- endpoint->bEndpointAddress == USB_DIR_IN
+ usb_endpoint_dir_in(endpoint)
|
- (endpoint->bEndpointAddress & E) == USB_DIR_IN
+ usb_endpoint_dir_in(endpoint)
)

Signed-off-by: Sandhya Bankar 
Signed-off-by: Greg Kroah-Hartman

Staging: most: Use list_first_entry instead of list_entry

2016-03-11T03:26:05+00:00

This patch replaces list_entry with list_first_entry as it makes the
code more clear.
Done using coccinelle:

@@
expression e;
@@
(
- list_entry(e->next,
+ list_first_entry(e,
  ...)
|
- list_entry(e->prev,
+ list_last_entry(e,
  ...)
)

Signed-off-by: Bhumika Goyal 
Signed-off-by: Greg Kroah-Hartman

Staging: most: Replace pr_err with dev_err

2016-03-11T03:26:05+00:00

All devm functions has a device structure as the first argument which is
required by dev_{err,info,dbg} printing functions.
This patch converts pr_err to dev_err as dev_* is preferred after calls
to devm functions.

Done using coccinelle:

@r1 exists@
expression e,e1;
identifier f =~ "^devm_";
identifier g =~ "^pcim_";
identifier h =~ "^dmam_";
@@
e=\(f\|g\|h\)(e1,...);
<+...
(
- pr_info(
+ dev_info(e1,
   ...);
|
- pr_err(
+ dev_err(e1,
  ...);
|
- pr_debug(
+ dev_dbg(e1,
  ...);
)
...+>

Signed-off-by: Bhumika Goyal 
Signed-off-by: Greg Kroah-Hartman

staging: most: hdm-usb: Use macro DIV_ROUND_UP

2016-02-26T06:35:10+00:00

The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)).
It clarifies the divisor calculations. This occurence was detected using the
coccinelle script:
@@
expression e1;
expression e2;
@@
(
- ((e1) + e2 - 1) / (e2)
+ DIV_ROUND_UP(e1,e2)
|
- ((e1) + (e2 - 1))/ (e2)
+ DIV_ROUND_UP(e1,e2)
)

The macro CEILING was dropped altogether and has been replaced with
DIV_ROUND_UP.

Signed-off-by: Bhaktipriya Shridhar 
Signed-off-by: Greg Kroah-Hartman

Staging: most: Do not print message if kzalloc() failed.

2016-02-26T06:34:19+00:00

Do not print message if kzalloc() failed.
kzalloc() has its own messages. So no need to add extra one.

Signed-off-by: Sandhya Bankar 
Signed-off-by: Greg Kroah-Hartman

staging: most: compress return logic into one line

2016-02-26T06:34:19+00:00

Eliminate local variable 'ret' and modify return statement to contain
the value being returned directly instead of assigning it first to 'ret'
and returning this variable.

Coccinelle semantic patch used:
@@ expression e, ret; @@
-ret =
+return
	e;
-return ret;

Signed-off-by: Eva Rachel Retuya 
Signed-off-by: Greg Kroah-Hartman