linux-stable.git/drivers/staging/most/dim2, branch master

staging: most: dim2: use dev_err_probe() for clock errors in rcar enable functions

2026-07-10T14:50:11+00:00

rcar_gen2_enable() and rcar_gen3_enable() use the old pattern of
dev_err() followed by return PTR_ERR() when devm_clk_get() fails.
fsl_mx6_enable() in the same file was already converted to use
dev_err_probe() by a previous cleanup series.

Convert the remaining two functions for consistency. devm_clk_get()
calls clk_get() which can return -EPROBE_DEFER if the clock provider
has not yet registered. Using dev_err_probe() suppresses the log at
error level in that case, avoiding misleading "cannot get clock" output
during a normal deferred probe.

clk_prepare_enable() cannot return -EPROBE_DEFER since the clock handle
is already acquired at that point, so those error paths are left as
dev_err().

Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Batu Ada Tutkun 
Reviewed-by: Dan Carpenter 
Link: https://patch.msgid.link/6a4ff7ac.cef1946f.13cfe2.dd63@mx.google.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: remove filename from comment blocks

2026-05-04T14:17:58+00:00

Remove redundant filename references from top-of-file
comment blocks across dim2 source files to resolve
checkpatch.pl warnings.

The filename is already implied by the file path and
including it in comments can become outdated.

No functional changes.

Signed-off-by: Shyam Sunder Reddy Padira 
Link: https://patch.msgid.link/20260503104447.64657-1-shyamsunderreddypadira@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: remove unnecessary NULL check in try_start_dim_transfer()

2026-04-27T11:01:51+00:00

Remove the !hdm_ch check. Although hdm_ch is a function parameter,
it is already dereferenced on the preceding line to initialize
head (head = &hdm_ch->pending_list), so a NULL check after that
point is dead code.

Reported-by: Dan Carpenter 
Closes: https://lore.kernel.org/all/acwjEHyEYg0V3OyC@stanley.mountain
Signed-off-by: Gabriel Rondon 
Link: https://patch.msgid.link/20260401101038.24304-1-grondon@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: remove unnecessary NULL check in service_done_flag()

2026-04-27T11:01:51+00:00

Remove the !hdm_ch check. hdm_ch is derived from dev->hch + ch_idx
(pointer arithmetic on a struct member), so it can never be NULL.
Keep only the !hdm_ch->is_initialized check.

Reported-by: Dan Carpenter 
Closes: https://lore.kernel.org/all/acuoL4DRi0pmsQY1@stanley.mountain
Signed-off-by: Gabriel Rondon 
Link: https://patch.msgid.link/20260331164443.47682-1-grondon@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: replace BUG_ON() in poison_channel()

2026-03-31T08:46:39+00:00

Replace BUG_ON() range check on ch_idx with a return of -EINVAL.

BUG_ON() is deprecated as it crashes the entire kernel on assertion
failure (see Documentation/process/deprecated.rst).

Signed-off-by: Gabriel Rondon 
Link: https://patch.msgid.link/20260330182255.75241-6-grondon@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: replace BUG_ON() in enqueue()

2026-03-31T08:46:39+00:00

Replace BUG_ON() range check on ch_idx with a return of -EINVAL.

BUG_ON() is deprecated as it crashes the entire kernel on assertion
failure (see Documentation/process/deprecated.rst).

Signed-off-by: Gabriel Rondon 
Link: https://patch.msgid.link/20260330182255.75241-5-grondon@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: replace BUG_ON() in configure_channel()

2026-03-31T08:46:39+00:00

Replace BUG_ON() range check on ch_idx with a return of -EINVAL.

BUG_ON() is deprecated as it crashes the entire kernel on assertion
failure (see Documentation/process/deprecated.rst).

Signed-off-by: Gabriel Rondon 
Link: https://patch.msgid.link/20260330182255.75241-4-grondon@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: replace BUG_ON() in service_done_flag()

2026-03-31T08:46:38+00:00

Replace BUG_ON() calls with an early return since the function returns
void.

BUG_ON() is deprecated as it crashes the entire kernel on assertion
failure (see Documentation/process/deprecated.rst).

Signed-off-by: Gabriel Rondon 
Link: https://patch.msgid.link/20260330182255.75241-3-grondon@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: replace BUG_ON() in try_start_dim_transfer()

2026-03-31T08:46:38+00:00

Replace BUG_ON() calls with graceful error handling.

For the null/uninitialized channel checks, return -EINVAL instead of
crashing the kernel. For the zero bus_address check, release the
spinlock and return -EFAULT.

BUG_ON() is deprecated as it crashes the entire kernel on assertion
failure (see Documentation/process/deprecated.rst).

Signed-off-by: Gabriel Rondon 
Link: https://patch.msgid.link/20260330182255.75241-2-grondon@gmail.com
Signed-off-by: Greg Kroah-Hartman

staging: most: dim2: replace ROUND_UP_TO macro with round_up()

2026-03-09T16:49:36+00:00

The ROUND_UP_TO macro reuses argument 'd', which can cause unintended
side effects. Remove it and replace the macro call with the existing
round_up() function.

Signed-off-by: Mark Adamenko 
Reviewed-by: Dan Carpenter 
Link: https://patch.msgid.link/20260306021926.7475-1-marusik.adamenko@gmail.com
Signed-off-by: Greg Kroah-Hartman