linux-stable.git/drivers/staging/media, branch linux-3.18.y

media: staging: omap4iss: Include asm/cacheflush.h after generic includes

2018-09-05T07:16:21+00:00

[ Upstream commit 0894da849f145af51bde88a6b84f95b9c9e0bc66 ]

Including asm/cacheflush.h first results in the following build error
when trying to build sparc32:allmodconfig, because 'struct page' has not
been declared, and the function declaration ends up creating a separate
(private) declaration of struct page (as a result of function arguments
being in the scope of the function declaration and definition, not in
global scope).

The C scoping rules do not just affect variable visibility, they also
affect type declaration visibility.

The end result is that when the actual call site is seen in
, the 'struct page' type in the caller is not the same
'struct page' that the function was declared with, resulting in:

  In file included from arch/sparc/include/asm/page.h:10:0,
                   ...
                   from drivers/staging/media/omap4iss/iss_video.c:15:
  include/linux/highmem.h: In function 'clear_user_highpage':
  include/linux/highmem.h:137:31: error:
	passing argument 1 of 'sparc_flush_page_to_ram' from incompatible
	pointer type

Include generic includes files first to fix the problem.

Fixes: fc96d58c10162 ("[media] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices")
Suggested-by: Linus Torvalds 
Acked-by: David S. Miller 
Cc: Randy Dunlap 
Signed-off-by: Guenter Roeck 
[ Added explanation of C scope rules - Linus ]
Signed-off-by: Linus Torvalds 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

Merge tag 'media/v3.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media

2014-10-11T02:04:49+00:00

Pull media updates from Mauro Carvalho Chehab:

 - new IR driver: hix5hd2-ir

 - the virtual test driver (vivi) was replaced by vivid, with has an
   almost complete set of features to emulate most v4l2 devices and
   properly test all sorts of userspace apps

 - the as102 driver had several bugs fixed and was properly split into a
   frontend and a core driver.  With that, it got promoted from staging
   into mainstream

 - one new CI driver got added for CIMaX SP2/SP2HF (sp2 driver)

 - one new frontend driver for Toshiba ISDB-T/ISDB-S demod (tc90522)

 - one new PCI driver for ISDB-T/ISDB-S (pt3 driver)

 - saa7134 driver got support for go7007-based devices

 - added a new PCI driver for Techwell 68xx chipsets (tw68)

 - a new platform driver was added (coda)

 - new tuner drivers: mxl301rf and qm1d1c0042

 - a new DVB USB driver was added for DVBSky S860 & similar devices

 - added a new SDR driver (hackrf)

 - usbtv got audio support

 - several platform drivers are now compiled with COMPILE_TEST

 - a series of compiler fixup patches, making sparse/spatch happier with
   the media stuff and removing several warnings, especially on those
   platform drivers that didn't use to compile on x86

 - Support for several new modern devices got added

 - lots of other fixes, improvements and cleanups

* tag 'media/v3.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media: (544 commits)
  [media] ir-hix5hd2: fix build on c6x arch
  [media] pt3: fix DTV FE I2C driver load error paths
  Revert "[media] media: em28xx - remove reset_resume interface"
  [media] exynos4-is: fix some warnings when compiling on arm64
  [media] usb drivers: use %zu instead of %zd
  [media] pci drivers: use %zu instead of %zd
  [media] dvb-frontends: use %zu instead of %zd
  [media] s5p-mfc: Fix several printk warnings
  [media] s5p_mfc_opr: Fix warnings
  [media] ti-vpe: Fix typecast
  [media] s3c-camif: fix dma_addr_t printks
  [media] s5p_mfc_opr_v6: get rid of warnings when compiled with 64 bits
  [media] s5p_mfc_opr_v5: Fix lots of warnings on x86_64
  [media] em28xx: Fix identation
  [media] drxd: remove a dead code
  [media] saa7146: remove return after BUG()
  [media] cx88: remove return after BUG()
  [media] cx88: fix cards table CodingStyle
  [media] radio-sf16fmr2: declare some structs as static
  [media] radio-sf16fmi: declare pnp_attached as static
  ...

staging: media: Fixed else after return or break warning

2014-10-02T20:51:03+00:00

The following patch fixes the checkpatch.pl warning:

drivers/staging/media/omap4iss/iss_csi2.c:811 warning: else is not generally useful after a break or return

Signed-off-by: Yeliz Taneroglu 
Signed-off-by: Greg Kroah-Hartman

staging: media: omap4iss: Fixed else after return or break warning

2014-10-02T20:51:03+00:00

The following patch fixes the checkpatch.pl warning:

drivers/staging/media/omap4iss/iss_ipipe.c:184 warning: else is not generally useful after a break or return

Signed-off-by: Yeliz Taneroglu 
Signed-off-by: Greg Kroah-Hartman

Staging: media: omap24xx: Merge two lines and remove unused variable

2014-10-02T16:33:46+00:00

This patch merges two lines and removes a variable that becomes unused
after merging.

Signed-off-by: Mahati Chamarthy 
Signed-off-by: Greg Kroah-Hartman

Revert "staging: media: cxd2099: use usleep_range()"

2014-10-02T16:27:37+00:00

This reverts commit 7b86477c0e5b7b1406f27da519d4df841f306b92.

It was broken and broke the build :(

Reported-by: kbuild test robot 
Reported-by: Stephen Rothwell 
Cc: Tapasweni Pathak 
Signed-off-by: Greg Kroah-Hartman

staging: media: omap4iss: Removed unnecessary else expression.

2014-09-29T03:03:25+00:00

This patch fixes "else is not generally useful after a break or return"
checkpatch.pl warning iss_resizer.c

Signed-off-by: Gulsah Kose 
Signed-off-by: Greg Kroah-Hartman

staging: media: omap4iss: Removed unnecessary else expression.

2014-09-29T03:03:24+00:00

This patch fixes "else is not generally useful after a break or return"
checkpatch.pl warning iss_ipipeif.c

Signed-off-by: Gulsah Kose 
Signed-off-by: Greg Kroah-Hartman

staging: media: omap24xx: Added blank line.

2014-09-29T03:03:24+00:00

This patch fixes "Missing a blank line after declarations" checkpatch.pl
warning in tcm825x.c

Signed-off-by: Gulsah Kose 
Signed-off-by: Greg Kroah-Hartman

staging: media: omap24xx: Added new line after declarations.

2014-09-29T03:03:24+00:00

This patch fixes "Missing a blank line after declarations" checkpatch.pl
warning in omap24xxcam-dma.c

Signed-off-by: Gulsah Kose 
Signed-off-by: Greg Kroah-Hartman