linux-stable.git/drivers/staging/media/atomisp, branch master

media: atomisp: Demote all broken kernel-doc comments

2026-07-15T15:12:55+00:00

The atomisp code has been very heavily annotated in doxygen format.

Unfortunately, both doxygen and kernel-doc use the same mark for signify
the beginning of a comment (/**).

As a result of this, kernel-doc gets confused when it parses atomisp and
throws tons of warnings, which made us completely disable atomisp
kernel-doc checks in Media-CI.

Demote all the broken comments so we can have 100% coverage.

Future patches can convert the doxygen annotations to kernel-doc if this
is deemed useful.

Signed-off-by: Ricardo Ribalda 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Hans Verkuil

media: atomisp: use kmalloc_objs for array allocations

2026-05-20T10:21:42+00:00

Convert manual kmalloc() multiplications to the modern kmalloc_objs()
interface to improve type safety and prevent potential integer
overflows.

Signed-off-by: Pedro Pontes 
Signed-off-by: Sakari Ailus

staging: media: atomisp: remove dead code in ov2722.h

2026-05-20T10:21:42+00:00

Remove unused code blocks enclosed in #if 0 to clean up the code.

Signed-off-by: Taekyung Oh 
Signed-off-by: Sakari Ailus

staging: media: atomisp: Fix block comment style in ov2722.h

2026-05-20T10:21:42+00:00

Fix coding style warnings reported by checkpatch.pl.
Move the comments above the corresponding code lines to align with guideline.

Signed-off-by: Taekyung Oh 
Signed-off-by: Sakari Ailus

staging: media: atomisp: replace msleep() with fsleep() in atomisp-gc2235.c

2026-05-20T10:21:42+00:00

Replace msleep(5) with fsleep(5000) to avoid sleeping longer than
necessary. msleep() with values less than 20ms may sleep for up to
20ms due to timer granularity. fsleep() selects the appropriate sleep
function automatically.

Signed-off-by: Oskar Ray-Frayssinet 
Signed-off-by: Sakari Ailus

staging: media: atomisp: fix map and vmap leaks in stat buffer allocation

2026-05-20T10:21:42+00:00

There are memory leaks in
drivers/staging/media/atomisp/pci/atomisp_compat_css20.c.

In atomisp_css_allocate_stat_buffers(), s3a_map is allocated by
ia_css_isp_3a_statistics_map_allocate() and its backing memory is
mapped via hmm_vmap(). When dis_buf allocation fails, the error path
frees s3a_data but does not unmap or free s3a_map. Similarly, when
md_buf allocation fails, neither s3a_map nor dvs_map (and their hmm
vmaps) are freed.

Add the missing hmm_vunmap() and map free calls on both error paths,
matching the cleanup order used in atomisp_css_free_3a_buffer() and
atomisp_css_free_dis_buffer().

Signed-off-by: Huihui Huang 
Signed-off-by: Sakari Ailus

media: atomisp: style fix for trailing statements

2026-05-20T10:21:41+00:00

Fix checkpatch errors "ERROR: trailing statements should be on next line"
in drivers/staging/media/atomisp/pci/sh_css_params.c.

Signed-off-by: Timo Röhling 
Reviewed-by: Andy Shevchenko 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Sakari Ailus

staging: media: atomisp: fix indentation in bh host files

2026-05-20T10:21:41+00:00

Fix inconsistent tab/space usage and bring function definitions
into a single-line format, matching kernel coding style.

Signed-off-by: LiangCheng Wang 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Sakari Ailus

staging: media: atomisp: use designated initializer in anr config

2026-05-20T10:21:41+00:00

Improve readability by using designated initializer for
default_anr_config.

Signed-off-by: LiangCheng Wang 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Sakari Ailus

staging: media: atomisp: fix indentation in anr files

2026-05-20T10:21:41+00:00

Fix inconsistent tab/space usage and bring function definitions
into a single-line format, matching kernel coding style.

Signed-off-by: LiangCheng Wang 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Sakari Ailus