linux-stable.git/drivers/staging/line6, branch v3.2.78

staging: line6: avoid __sync_fetch_and_{and,or}

2015-08-06T23:32:19+00:00

commit 9f613601482c56e05884f21565e3d218fac427ae upstream.

__sync_fetch_and_and and __sync_fetch_and_or are functions that are provided
by gcc and depending on the target architecture may be implemented in libgcc,
which is not always available in the kernel. This leads to a build failure
on ARMv5:

drivers/built-in.o: In function `line6_pcm_release':
:(.text+0x3bfe80): undefined reference to `__sync_fetch_and_and_4'
drivers/built-in.o: In function `line6_pcm_acquire':
:(.text+0x3bff30): undefined reference to `__sync_fetch_and_or_4'

To work around this, we can use the kernel-provided cmpxchg macro.

Build-tested only.

Signed-off-by: Arnd Bergmann 
Cc: Markus Grabner 
Acked-by: Randy Dunlap 
Signed-off-by: Greg Kroah-Hartman 
[bwh: Backported to 3.2:
 - Adjust context
 - Fix up two more instances of __sync_fetch_and_and() that were removed
   separately upstream]
Signed-off-by: Ben Hutchings

staging: line6: Fix unlocked snd_pcm_stop() call

2013-08-02T20:14:59+00:00

commit 86f0b5b86d142b9323432fef078a6cf0fb5dda74 upstream.

snd_pcm_stop() must be called in the PCM substream lock context.

Signed-off-by: Takashi Iwai 
Signed-off-by: Ben Hutchings

staging: Add export.h for THIS_MODULE/EXPORT_SYMBOL to drivers/staging users.

2011-10-31T23:32:08+00:00

Lots of drivers have in the past expected the presence of basic things
like THIS_MODULE and EXPORT_SYMBOL.  With the header cleanup, they wont
have these.  Call out the include explicitly.

Signed-off-by: Paul Gortmaker

drivers/staging/line6/driver.c: Drop unneeded put functions.

2011-05-17T20:31:32+00:00

This seems to be the result of patches ab366c1a and 1027f476 crossing each
other.  Patch ab366c1a adds calls to usb_put_intf and usb_put_dev at the
end of the function line6_probe, in the error handling code, while patch
1027f476 moves the calls to the corresponding get function from the
beginning to the end of line6_probe, making the calls to put in the error
handling code unnecessary.

// 

Signed-off-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

staging: line6: Remove NULL check before kfree

2011-03-14T18:57:33+00:00

This patch was generated by the following semantic patch:
// 
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);

@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// 

Signed-off-by: Ilia Mirkin 
Signed-off-by: Greg Kroah-Hartman

staging/line6: Fix sparse warning 'Using plain integer as NULL pointer'

2010-12-08T22:31:01+00:00

This patch fixes the warning generated by sparse: "Using plain integer
as NULL pointer" by replacing the offending 0s with NULL.

Signed-off-by: Peter Huewe 
Signed-off-by: Greg Kroah-Hartman

Staging: line6: fix up my fixup for some sysfs attribute permissions

2010-11-18T19:27:20+00:00

They should be writable by root, not readable.
Doh, stupid me with the wrong flags.

Reported-by: Jonathan Cameron 
Cc: Markus Grabner 
Cc: Mariusz Kozlowski 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

Staging: line6: fix up some sysfs attribute permissions

2010-11-16T19:23:33+00:00

They should not be writable by any user

Reported-by: Linus Torvalds 
Cc: Markus Grabner 
Cc: Mariusz Kozlowski 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

Staging: line6: Makefile: replace the use of -objs with -y

2010-10-08T14:23:47+00:00

Changed -objs to -y in Makefile.

Signed-off-by: Tracey Dent 
Signed-off-by: Greg Kroah-Hartman

Staging: line6: minor coding style cleanups

2010-09-21T23:58:00+00:00

This fixes up all of the remaining coding style issues that
make any sense to make in the line6 driver.

Cc: Markus Grabner 
Signed-off-by: Greg Kroah-Hartman