linux-stable.git/drivers/staging/line6, branch linux-3.9.y

staging: Remove unnecessary OOM messages

2013-02-11T18:10:33+00:00

alloc failures already get standardized OOM
messages and a dump_stack.

For the affected mallocs around these OOM messages:

Converted kzallocs with multiplies to kcalloc.
Converted kmallocs with multiplies to kmalloc_array.
Converted a kmalloc/strlen/strncpy to kstrdup.
Moved a spin_lock below a removed OOM message and
removed a now unnecessary spin_unlock.
Neatened alignment and whitespace.

Signed-off-by: Joe Perches 
Signed-off-by: Greg Kroah-Hartman

staging: line6: clean up line6_variax_process_message()

2013-01-20T23:57:47+00:00

Previous versions of the line6 driver snooped MIDI traffic in order to
make device state accessible via sysfs attributes.  This involved a lot
of logic in line6_variax_process_message() that has since been removed.

Drop unused conditionals in line6_variax_process_message().

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: clean up line6_pod_process_message()

2013-01-20T23:57:47+00:00

Previous versions of the line6 driver snooped MIDI traffic in order to
make device state accessible via sysfs attributes.  This involved a lot
of logic in line6_pod_process_message() that has since been removed.

Drop unused conditionals in line6_pod_process_message() and reduce the
levels of indentation.  Only two MIDI messages are still tracked: the
POD version message on startup and monitor level changes originating
from the device.

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: drop CONFIG_LINE6_USB_DUMP_PCM

2013-01-20T23:56:59+00:00

The CONFIG_LINE6_USB_DUMP_PCM config option prints a hexdump of PCM
audio data as URBs are sent and received.  The usbmon feature should be
used instead of manually dumping PCM URBs.  There are a few advantages
to using usbmon:

 * Can be turned on/off at runtime
 * Provides full USB-level traffic
 * tcpdump and wireshark support for powerful analysis
 * No driver-specific code is required

This is the last user of line6_write_hexdump() so we drop it too.

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: avoid CamelCase POD_* enums in pod.c

2013-01-12T00:40:51+00:00

Fix the following checkpatch.pl warnings:

  WARNING: Avoid CamelCase: 
  #4512: FILE: staging/line6/pod.c:41:
  +       POD_monitor_level  = 0x04,

  WARNING: Avoid CamelCase: 
  #4513: FILE: staging/line6/pod.c:42:
  +       POD_system_invalid = 0x10000

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: rename MidiBuffer to avoid CamelCase

2013-01-12T00:40:50+00:00

Fix checkpatch.pl warnings related to MidiBuffer:

  WARNING: Avoid CamelCase: 
  #947: FILE: staging/line6/driver.c:363:
  +       struct MidiBuffer *mb = &line6->line6midi->midibuf_in;

Rename MidiBuffer to midi_buffer.

Note that "midibuf" would be another good name but sound/oss/midibuf.c
already uses it for a different concept.  Avoid possible confusion by
using "midi_buffer" instead.

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: use pr_err() instead of printk(KERN_ERR, ...)

2013-01-12T00:40:50+00:00

Fix the following checkpatch.pl warning:

  WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
  #1861: FILE: staging/line6/driver.h:56:
  +       printk(KERN_ERR "line6usb driver bug: missing case in %s:%d\n", \

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: wrap comment to 80 chars in driver.c

2013-01-12T00:40:50+00:00

Fix the following checkpatch.pl warning:

  WARNING: line over 80 characters
  #1107: FILE: staging/line6/driver.c:523:
  +       /* Wait for data length. We'll get a couple of 0xff until length arrives. */

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: wrap lines to 80 chars in pod.c

2013-01-12T00:40:50+00:00

Fix the following checkpatch.pl warnings:

  WARNING: line over 80 characters
  #4508: FILE: staging/line6/pod.c:37:
  +       /* POD_SYSEX_DUMPMEM2  = 0x76 */   /* dumps entire internal memory of PODxt Pro */

  WARNING: line over 80 characters
  #4630: FILE: staging/line6/pod.c:159:
  +               if (memcmp(buf + 1, line6_midi_id, sizeof(line6_midi_id)) == 0) {

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: drop ToneportSourceInfo CamelCase name

2013-01-12T00:40:50+00:00

Fix the following checkpatch.pl warning:

  WARNING: Avoid CamelCase: 
  #5383: FILE: staging/line6/toneport.c:90:
  +struct ToneportSourceInfo {

Since the struct is only used to define the global
toneport_source_info[] table, I have chosen to make the struct
anonymous and part of the table definition.

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman