linux-stable.git/drivers/staging/line6, branch linux-3.16.y

ALSA: line6: Fix memory leak at line6_init_pcm() error path

2020-02-11T20:03:09+00:00

commit 1bc8d18c75fef3b478dbdfef722aae09e2a9fde7 upstream.

I forgot to release the allocated object at the early error path in
line6_init_pcm().  For addressing it, slightly shuffle the code so
that the PCM destructor (pcm->private_free) is assigned properly
before all error paths.

Fixes: 3450121997ce ("ALSA: line6: Fix write on zero-sized buffer")
Signed-off-by: Takashi Iwai 
[bwh: Backported to 3.16: adjust filename, context]
Signed-off-by: Ben Hutchings

ALSA: line6: Drop superfluous snd_device for PCM

2020-02-11T20:03:08+00:00

commit b45a7c565473d29bd7e02ac8ca86232a24ca247f upstream.

Instead of handling the card-specific resource in snd_device, attach
it into pcm->private_data and release it directly in private_free.
This simplifies the code and structure.

Tested-by: Chris Rorvick 
Signed-off-by: Takashi Iwai 
[bwh: Backported to 3.16 as dependency of commit 1bc8d18c75fe
 "ALSA: line6: Fix memory leak at line6_init_pcm() error path"]
 - Adjust filename, context]
Signed-off-by: Ben Hutchings

ALSA: line6: Fix write on zero-sized buffer

2019-09-23T20:12:15+00:00

commit 3450121997ce872eb7f1248417225827ea249710 upstream.

LINE6 drivers allocate the buffers based on the value returned from
usb_maxpacket() calls.  The manipulated device may return zero for
this, and this results in the kmalloc() with zero size (and it may
succeed) while the other part of the driver code writes the packet
data with the fixed size -- which eventually overwrites.

This patch adds a simple sanity check for the invalid buffer size for
avoiding that problem.

Reported-by: syzbot+219f00fb49874dcaea17@syzkaller.appspotmail.com
Signed-off-by: Takashi Iwai 
[bwh: Backported to 3.16:
 - Driver doesn't support asymmetrical packet sizes, so only check
   snd_line6_pcm::max_packet_size
 - Adjust filename]
Signed-off-by: Ben Hutchings

ALSA: line6: Use correct endpoint type for midi output

2018-10-21T07:45:23+00:00

commit 7ecb46e9ee9af18e304eb9e7d6804c59a408e846 upstream.

Sending MIDI messages to a PODxt through the USB connection shows
"usb_submit_urb failed" in dmesg and the message is not received by
the POD.

The error is caused because in the funcion send_midi_async() in midi.c
there is a call to usb_sndbulkpipe() for endpoint 3 OUT, but the PODxt
USB descriptor shows that this endpoint it's an interrupt endpoint.

Patch tested with PODxt only.

[ The bug has been present from the very beginning in the staging
  driver time, but Fixes below points to the commit moving to sound/
  directory so that the fix can be cleanly applied -- tiwai ]

Fixes: 61864d844c29 ("ALSA: move line6 usb driver into sound/usb")
Signed-off-by: Fabián Inostroza 
Signed-off-by: Takashi Iwai 
[bwh: Backported to 3.16: adjust filename, context]
Signed-off-by: Ben Hutchings

staging/line6: blank line after declaration cleanup

2014-05-15T20:54:29+00:00

Fix coding style warnings reported by checkpath.

Signed-off-by: Jerry Snitselaar 
Signed-off-by: Greg Kroah-Hartman

staging/line6: Fix kzalloc coding style issue

2014-04-17T03:30:04+00:00

Pass the actual variable to sizeof instead of a type definition.

Signed-off-by: L. Alberto Giménez 
Acked-by: Takashi Iwai 
Signed-off-by: Greg Kroah-Hartman

staging: line6: Add blank lines after declarations

2014-04-17T03:29:17+00:00

Use the more common kernel coding style.

Signed-off-by: Fabian Mewes 
Reviewed-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

Merge tag 'staging-3.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging

2014-04-01T23:45:00+00:00

Pull staging driver updates from Greg KH:
 "Here's the huge drivers/staging/ update for 3.15-rc1.

  Loads of cleanup fixes, a few drivers removed, and some new ones
  added.

  All have been in linux-next for a while"

* tag 'staging-3.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (1375 commits)
  staging: xillybus: XILLYBUS_PCIE depends on PCI_MSI
  staging: xillybus: Added "select CRC32" for XILLYBUS in Kconfig
  staging: comedi: poc: remove obsolete driver
  staging: unisys: replace kzalloc/kfree with UISMALLOC/UISFREE
  staging: octeon-usb: prevent memory corruption
  staging: usbip: fix line over 80 characters
  staging: usbip: fix quoted string split across lines
  Staging: unisys: Remove RETINT macro
  Staging: unisys: Remove FAIL macro
  Staging: unisys: Remove RETVOID macro
  Staging: unisys: Remove RETPTR macro
  Staging: unisys: Remove RETBOOL macro
  Staging: unisys: Remove FAIL_WPOSTCODE_1 macro
  Staging: unisys: Cleanup macros to get rid of goto statements
  Staging: unisys: include: Remove unused macros from timskmod.h
  staging: dgap: fix the rest of the checkpatch warnings in dgap.c
  Staging: bcm: Remove unnecessary parentheses
  staging: wlags49_h2: Delete unnecessary braces
  staging: wlags49_h2: Do not use assignment in if condition
  staging: wlags49_h2: Enclose macro in a do-while loop
  ...

staging: line6: Fix coding style problem

2014-03-18T23:11:15+00:00

Fix style issue for eudyptula challenge

Signed-off-by: Mikhail Boiko 
Signed-off-by: Greg Kroah-Hartman

staging: line6: long line fixes

2014-03-17T19:08:42+00:00

Fixed some line over 80 characters.

Signed-off-by: Davide Berardi 
Signed-off-by: Greg Kroah-Hartman