linux-stable.git/drivers/staging/line6, branch linux-3.12.y

ALSA: usb-line6: use the same declaration as definition in header for MIDI manufacturer ID

2016-10-17T07:46:19+00:00

commit 8da08ca03b73593d5299893bf29fc08569c3fb5f upstream.

Currently, usb-line6 module exports an array of MIDI manufacturer ID and
usb-pod module uses it. However, the declaration is not the definition in
common header. The difference is explicit length of array. Although
compiler calculates it and everything goes well, it's better to use the
same representation between definition and declaration.

This commit fills the length of array for usb-line6 module. As a small
good sub-effect, this commit suppress below warnings from static analysis
by sparse v0.5.0.

sound/usb/line6/driver.c:274:43: error: cannot size expression
sound/usb/line6/driver.c:275:16: error: cannot size expression
sound/usb/line6/driver.c:276:16: error: cannot size expression
sound/usb/line6/driver.c:277:16: error: cannot size expression

Fixes: 705ececd1c60 ("Staging: add line6 usb driver")
Signed-off-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai 
Signed-off-by: Jiri Slaby

staging: line6: add bounds check in snd_toneport_source_put()

2013-09-17T14:39:28+00:00

"source" comes from the user in snd_ctl_elem_write() so it needs to be
checked.

Signed-off-by: Dan Carpenter 
Reviewed-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: use default sysfs attribute macros

2013-08-24T17:36:49+00:00

Move to use the DEVICE_ATTR_RW/RO macros, making it easier to audit the
sysfs file permissions, and get rid of the "empty" callback for
read-only files, saving lines of code.

Cc: Stefan Hajnoczi 
Cc: Laurent Navet 
Cc: Johannes Thumshirn 
Signed-off-by: Greg Kroah-Hartman

staging: line6: Fix unlocked snd_pcm_stop() call

2013-07-15T19:25:14+00:00

snd_pcm_stop() must be called in the PCM substream lock context.

Cc: 
Signed-off-by: Takashi Iwai

staging: line6: avoid __sync_fetch_and_{and,or}

2013-06-24T22:56:09+00:00

__sync_fetch_and_and and __sync_fetch_and_or are functions that are provided
by gcc and depending on the target architecture may be implemented in libgcc,
which is not always available in the kernel. This leads to a build failure
on ARMv5:

drivers/built-in.o: In function `line6_pcm_release':
:(.text+0x3bfe80): undefined reference to `__sync_fetch_and_and_4'
drivers/built-in.o: In function `line6_pcm_acquire':
:(.text+0x3bff30): undefined reference to `__sync_fetch_and_or_4'

To work around this, we can use the kernel-provided cmpxchg macro.

Build-tested only.

Signed-off-by: Arnd Bergmann 
Cc: Markus Grabner 
Acked-by: Randy Dunlap 
Signed-off-by: Greg Kroah-Hartman

staging: line6: pod.c: fix checkpatch warning

2013-03-11T16:47:13+00:00

 - WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Laurent Navet 
Reviewed-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: Remove unnecessary OOM messages

2013-02-11T18:10:33+00:00

alloc failures already get standardized OOM
messages and a dump_stack.

For the affected mallocs around these OOM messages:

Converted kzallocs with multiplies to kcalloc.
Converted kmallocs with multiplies to kmalloc_array.
Converted a kmalloc/strlen/strncpy to kstrdup.
Moved a spin_lock below a removed OOM message and
removed a now unnecessary spin_unlock.
Neatened alignment and whitespace.

Signed-off-by: Joe Perches 
Signed-off-by: Greg Kroah-Hartman

staging: line6: clean up line6_variax_process_message()

2013-01-20T23:57:47+00:00

Previous versions of the line6 driver snooped MIDI traffic in order to
make device state accessible via sysfs attributes.  This involved a lot
of logic in line6_variax_process_message() that has since been removed.

Drop unused conditionals in line6_variax_process_message().

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: clean up line6_pod_process_message()

2013-01-20T23:57:47+00:00

Previous versions of the line6 driver snooped MIDI traffic in order to
make device state accessible via sysfs attributes.  This involved a lot
of logic in line6_pod_process_message() that has since been removed.

Drop unused conditionals in line6_pod_process_message() and reduce the
levels of indentation.  Only two MIDI messages are still tracked: the
POD version message on startup and monitor level changes originating
from the device.

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman

staging: line6: drop CONFIG_LINE6_USB_DUMP_PCM

2013-01-20T23:56:59+00:00

The CONFIG_LINE6_USB_DUMP_PCM config option prints a hexdump of PCM
audio data as URBs are sent and received.  The usbmon feature should be
used instead of manually dumping PCM URBs.  There are a few advantages
to using usbmon:

 * Can be turned on/off at runtime
 * Provides full USB-level traffic
 * tcpdump and wireshark support for powerful analysis
 * No driver-specific code is required

This is the last user of line6_write_hexdump() so we drop it too.

Signed-off-by: Stefan Hajnoczi 
Signed-off-by: Greg Kroah-Hartman