linux-stable.git/drivers/staging/ipack/devices, branch v3.6 Linux kernel stable tree Staging: ipack/devices/ipoctal: initialize the device in probe function 2012-07-17T02:11:37+00:00 Samuel Iglesias Gonsálvez siglesias@igalia.com 2012-07-13T11:33:14+00:00 4eed84a8a4731e37254a10adfaad76e69e236b8c Initialize the device when registering it. Sometimes the user access to it and the device is in an unknown state, so it could fail. Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Initialize the device when registering it. Sometimes the user access to it
and the device is in an unknown state, so it could fail.

Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: ipack/devices/ipoctal: fix dereference NULL pointer 2012-07-17T02:11:37+00:00 Samuel Iglesias Gonsálvez siglesias@igalia.com 2012-07-13T11:33:13+00:00 1337b07e664c5a40ae0c5cbc13f5da4cf37c870c After opening and closing the file /dev/ipoctal.X.Y.Z for the second time, it gives a kernel oops due to a dereference of a NULL pointer. The problem was that tty->driver_data was not properly initialized when accessing the file for the second time. Reported-by: Alberto Garcia Gonzalez <agarcia@igalia.com> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
After opening and closing the file /dev/ipoctal.X.Y.Z for the second time, it
gives a kernel oops due to a dereference of a NULL pointer.

The problem was that tty->driver_data was not properly initialized when
accessing the file for the second time.

Reported-by: Alberto Garcia Gonzalez <agarcia@igalia.com>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: ipack/devices/ipoctal: save IRQ vector in MEM space 2012-07-06T23:21:54+00:00 Samuel Iglesias Gonsálvez siglesias@igalia.com 2012-07-04T14:11:10+00:00 7183f337fef677165d3dbd09a42ee9578c94f890 The IRQ vector should be saved in MEM space base address according to the datasheet. Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The IRQ vector should be saved in MEM space base address according to the
datasheet.

Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: ipack/devices/ipoctal: remove unneeded lock in IRQ handler 2012-06-25T17:50:01+00:00 Samuel Iglesias Gonsalvez siglesias@igalia.com 2012-06-25T15:15:47+00:00 59d6a29e554d891a513476c13a6657825f8be270 In the rest of the code, the data is protected with spin_lock_irqsave(). Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
In the rest of the code, the data is protected with spin_lock_irqsave().

Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: ipack/devices/ipoctal: remove unneeded includes 2012-06-25T17:50:00+00:00 Samuel Iglesias Gonsalvez siglesias@igalia.com 2012-06-25T15:15:45+00:00 55c0a6f470517918a996a525325db6a88435c298 Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: ipack/devices/ipoctal: fix oops when accessing "buffer" 2012-06-25T17:50:00+00:00 Samuel Iglesias Gonsalvez siglesias@igalia.com 2012-06-25T15:15:44+00:00 db1db294d9366e95a76f4ca7e6442240eba67a0a The buffer[][] field was replaced by tty_port->xmit_buf field but there was some places that "buffer" was still accessed, giving a kernel oops because it was uninitialized. Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The buffer[][] field was replaced by tty_port->xmit_buf field but there was
some places that "buffer" was still accessed, giving a kernel oops because
it was uninitialized.

Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: ipack/devices/ipoctal: remove unused enum uart_parity_e. 2012-06-09T15:58:04+00:00 Miguel Gómez magomez@igalia.com 2012-06-07T08:24:57+00:00 1be9bbddde32a0c414dd65220ca86f808aaeec5f Signed-off-by: Miguel Gómez <magomez@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Signed-off-by: Miguel Gómez <magomez@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: ipack/devices/ipoctal: remove error_flag field from ipoctal struct. 2012-06-09T15:58:04+00:00 Miguel Gómez magomez@igalia.com 2012-06-07T08:24:56+00:00 c15768bb0c346767eb54e01a7e772041f36eb65e Remove the error_flag field from the ipoctal structure, as the error code is handled through the tty abstraction. Remove the values definition as well. Signed-off-by: Miguel Gómez <magomez@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Remove the error_flag field from the ipoctal structure, as the error code
is handled through the tty abstraction. Remove the values definition as well.

Signed-off-by: Miguel Gómez <magomez@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: ipack/devices/ipoctal: remove ipoctal_config structure. 2012-06-09T15:58:03+00:00 Miguel Gómez magomez@igalia.com 2012-06-07T08:24:55+00:00 8ae7012d3ed3314cc1bf52bd6c51eaa4cc1609a9 The configuration of the communication channel is handled by the tty abstraction, so the ipoctal_config structure has become useless and it's only used to store values that are never accesed. Remove it. Signed-off-by: Miguel Gómez <magomez@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The configuration of the communication channel is handled by the tty
abstraction, so the ipoctal_config structure has become useless and it's
only used to store values that are never accesed. Remove it.

Signed-off-by: Miguel Gómez <magomez@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: ipack/devices/ipoctal: change pr_* usage for dev_* functions 2012-06-07T05:23:33+00:00 Samuel Iglesias Gonsalvez siglesias@igalia.com 2012-05-25T11:08:13+00:00 42b38207c36890ead05ab1c0002714c48b9b996a Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>