linux-stable.git/drivers/staging/iio, branch linux-3.2.y

staging: iio: ade7759: fix signed extension bug on shift of a u8

2018-01-01T20:50:54+00:00

commit 13ffe9a26df4e156363579b25c904dd0b1e31bfb upstream.

The current shift of st->rx[2] left shifts a u8 24 bits left,
promotes the integer to a an int and then to a unsigned u64. If
the top bit of st->rx[2] is set then we end up with all the upper
bits being set to 1. Fix this by casting st->rx[2] to a u64 before
the 24 bit left shift.

Detected by CoverityScan CID#144940 ("Unintended sign extension")

Fixes: 2919fa54ef64 ("staging: iio: meter: new driver for ADE7759 devices")
Signed-off-by: Colin Ian King 
Signed-off-by: Jonathan Cameron 
Signed-off-by: Ben Hutchings

staging:iio:gyro:adis16080: remove sparse warnings

2017-11-11T13:34:48+00:00

commit 4d9505af7743828464d066795c6e1311c7884db4 upstream.

Removed the following sparse warning:

In function 'adis16080_read_raw':
warning: 'ut' may be used uninitialized in this function

Signed-off-by: Leed Aguilar 
Acked-by: Lars-Peter Clausen 
Cc: Jonathan Cameron 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Ben Hutchings

iio: staging: ad7298_ring: Fix maybe-uninitialized warning

2017-11-11T13:34:48+00:00

commit dfffd0d65fdf16d034681716dcbea74776f62e40 upstream.

drivers/staging/iio/adc/ad7298_ring.c:97:37: warning: 'time_ns' may
be used uninitialized in this function [-Wmaybe-uninitialized]

Reported-by: Fengguang Wu 
Signed-off-by: Michael Hennerich 
Signed-off-by: Jonathan Cameron 
Signed-off-by: Ben Hutchings

Staging: iio/accel: Changed return type of lis3l02dq_read_event_config() to int

2017-11-11T13:34:47+00:00

commit 28998e005bb669b60de0e432d6f142267f5c1403 upstream.

The lis3l02dq_read_event_config() function returned an ssize_t up to
now, which lead to a compiler warning in line 660 (initialization from
incompatible pointer type). The iio_info struct is defined to accept an
int-returning function as the read_event_config parameter.

Also it seems odd to have the check for (ret < 0) and return ret in
this case, when the return type is signed.

Signed-off-by: Andreas Ruprecht 
Acked-by: Jonathan Cameron 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Ben Hutchings

staging:iio:resolver:ad2s1210 fix negative IIO_ANGL_VEL read

2017-11-11T13:34:23+00:00

commit 105967ad68d2eb1a041bc041f9cf96af2a653b65 upstream.

gcc-7 points out an older regression:

drivers/staging/iio/resolver/ad2s1210.c: In function 'ad2s1210_read_raw':
drivers/staging/iio/resolver/ad2s1210.c:515:42: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context]

The original code had 'unsigned short' here, but incorrectly got
converted to 'bool'. This reverts the regression and uses a normal
type instead.

Fixes: 29148543c521 ("staging:iio:resolver:ad2s1210 minimal chan spec conversion.")
Signed-off-by: Arnd Bergmann 
Signed-off-by: Jonathan Cameron 
Signed-off-by: Ben Hutchings

iio: light: tsl2563: use correct event code

2017-11-11T13:34:23+00:00

commit a3507e48d3f99a93a3056a34a5365f310434570f upstream.

The TSL2563 driver provides three iio channels, two of which are raw ADC
channels (channel 0 and channel 1) in the device and the remaining one
is calculated by the two.  The ADC channel 0 only supports programmable
interrupt with threshold settings and this driver supports the event but
the generated event code does not contain the corresponding iio channel
type.

This is going to change userspace ABI.  Hopefully fixing this to be
what it should always have been won't break any userspace code.

Cc: Jonathan Cameron 
Signed-off-by: Akinobu Mita 
Signed-off-by: Jonathan Cameron 
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings

staging: iio: ad7606: fix improper setting of oversampling pins

2017-03-16T02:18:23+00:00

commit b321a38d2407c7e425c54bc09be909a34e49f740 upstream.

The oversampling ratio is controlled using the oversampling pins,
OS [2:0] with OS2 being the MSB control bit, and OS0 the LSB control
bit.

The gpio connected to the OS2 pin is not being set correctly, only OS0
and OS1 pins are being set. Fix the typo to allow proper control of the
oversampling pins.

Signed-off-by: Eva Rachel Retuya 
Fixes: b9618c0 ("staging: IIO: ADC: New driver for AD7606/AD7606-6/AD7606-4")
Acked-by: Lars-Peter Clausen 
Signed-off-by: Jonathan Cameron 
Signed-off-by: Ben Hutchings

staging: iio: ad5933: avoid uninitialized variable in error case

2017-02-23T03:50:55+00:00

commit 34eee70a7b82b09dbda4cb453e0e21d460dae226 upstream.

The ad5933_i2c_read function returns an error code to indicate
whether it could read data or not. However ad5933_work() ignores
this return code and just accesses the data unconditionally,
which gets detected by gcc as a possible bug:

drivers/staging/iio/impedance-analyzer/ad5933.c: In function 'ad5933_work':
drivers/staging/iio/impedance-analyzer/ad5933.c:649:16: warning: 'status' may be used uninitialized in this function [-Wmaybe-uninitialized]

This adds minimal error handling so we only evaluate the
data if it was correctly read.

Link: https://patchwork.kernel.org/patch/8110281/
Signed-off-by: Arnd Bergmann 
Acked-by: Lars-Peter Clausen 
Signed-off-by: Jonathan Cameron 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings

iio: accel: kxsd9: Fix scaling bug

2016-11-20T01:01:36+00:00

commit 307fe9dd11ae44d4f8881ee449a7cbac36e1f5de upstream.

All the scaling of the KXSD9 involves multiplication with a
fraction number < 1.

However the scaling value returned from IIO_INFO_SCALE was
unpredictable as only the micros of the value was assigned, and
not the integer part, resulting in scaling like this:

$cat in_accel_scale
-1057462640.011978

Fix this by assigning zero to the integer part.

Tested-by: Jonathan Cameron 
Signed-off-by: Linus Walleij 
Signed-off-by: Jonathan Cameron 
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings

iio: accel: kxsd9: Fix raw read return

2016-11-20T01:01:34+00:00

commit 7ac61a062f3147dc23e3f12b9dfe7c4dd35f9cb8 upstream.

Any readings from the raw interface of the KXSD9 driver will
return an empty string, because it does not return
IIO_VAL_INT but rather some random value from the accelerometer
to the caller.

Signed-off-by: Linus Walleij 
Signed-off-by: Jonathan Cameron 
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings