linux-stable.git/drivers/staging/iio/buffer.h, branch v3.3

staging:iio: Drop {mark,unmark}_in_use callbacks

2011-12-22T21:38:10+00:00

These callbacks are currently used by the individual buffer implementations to
ensure that the request_update callback is not issued while the buffer is in use.
But the core already provides sufficient measures to prevent this from happening
in the first place. So it is safe to remove them.

There is one functional change due to this patch. Since the buffer is no longer
marked as in use when the chrdev is opened, it is now possible to enable the
buffer while it is opened. This did not work before, because mark_param_change
did fail if the buffer was marked as in use.

Acked-by: Jonathan Cameron 
Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Greg Kroah-Hartman

staging:iio: Drop buffer mark_param_change callback

2011-12-22T21:38:09+00:00

Right now we have a mark_param_change callback in the buffer access
functions struct, which should be called whenever the parameters (length,
bytes per datum) of the buffer change. But it is only called when the user
changes the buffer size, not when the bytes per datum change. Additionally each
buffer implementation already keeps track internally whether its parameters
have changed, making the call to mark_param_change after changing the buffer
length redundant. Since each buffer implementation knows best when one of its
parameters has changed just make tracking of this internal and drop the
mark_param_change callback.

Acked-by: Jonathan Cameron 
Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Greg Kroah-Hartman

staging:iio: Drop the unused buffer enable() and is_enabled() callbacks

2011-12-22T21:38:09+00:00

Currently none of the buffer implementations implements the enable() or
is_enable() nor does core code try to call these. So it is safe to remove them.

Acked-by: Jonathan Cameron 
Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Greg Kroah-Hartman

staging:iio: Drop buffer busy flag

2011-12-22T21:38:08+00:00

The flag is only cleared, never set or tested, so it is safe to remove it.

Acked-by: Jonathan Cameron 
Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Greg Kroah-Hartman

staging:iio:kfifo_buf: Fix potential buffer overflow in iio_read_first_n_kfifo

2011-12-13T00:51:03+00:00

n is the number of bytes to read, not the number of samples. So if there is
enough data available we will write to the userspace buffer beyond its bounds.
Fix this by copying n bytes maximum. Also round n down to the next multiple of
the sample size, so we will only read complete samples. If the buffer is too
small to hold at least one sample return -EINVAL.

Also update the documentation of read_first_n to reflect the fact that 'n' is
supposed to be in bytes and not in samples.

Acked-by: Jonathan Cameron 
Signed-off-by: Lars-Peter Clausen 
Signed-off-by: Greg Kroah-Hartman

staging:iio:buffer.h update struct buffer docs.

2011-12-08T20:13:59+00:00

These docs have lagged recent developments.

Signed-off-by: Jonathan Cameron 
Signed-off-by: Greg Kroah-Hartman

staging:iio:buffer struct iio_buffer doesn't need an indio_dev pointer.

2011-12-08T20:13:58+00:00

In all existing cases, the calls are coming from a location where
the indio_dev is already available.

Signed-off-by: Jonathan Cameron 
Signed-off-by: Greg Kroah-Hartman

staging:iio:buffer scrap to_iio_buffer as it no longer has meaning.

2011-12-08T20:13:58+00:00

Now buffers do not have a specific dev structure, this is garbage.

Signed-off-by: Jonathan Cameron 
Signed-off-by: Greg Kroah-Hartman

staging:iio:buffer stop allowing for read_last callback.

2011-12-08T20:13:57+00:00

No longer needed now we don't allow sysfs acccess to buffer data.

Signed-off-by: Jonathan Cameron 
Acked-by: Lars-Peter Clausen 
Signed-off-by: Greg Kroah-Hartman

staging:iio:buffer remove unused owner field from struct iio_buffer

2011-12-08T20:11:09+00:00

Legacy of having multiple chrdevs that never got cleaned up.

Signed-off-by: Jonathan Cameron 
Acked-by: Lars-Peter Clausen 
Signed-off-by: Greg Kroah-Hartman