linux-stable.git/drivers/staging/fwserial, branch linux-4.1.y

staging: fwserial: remove extra parentheses around function arguments

2015-03-15T17:41:11+00:00

Removes extra parentheses around function arguments. Issue
detected and resolved using the following coccinelle script:

@@
expression e;
identifier f;
@@

f(...,
-(
e
-)
,...);

Signed-off-by: Aya Mahfouz 
Signed-off-by: Greg Kroah-Hartman

staging: fwserial: remove multiple blank lines

2014-11-26T21:53:25+00:00

This patch fixes the multiple blank lines issue complained by checkpatch.pl
by removing useless blank lines.

Signed-off-by: Le Tan 
Signed-off-by: Greg Kroah-Hartman

staging/fwserial: (coding style) remove not needed return statements

2014-06-18T22:25:56+00:00

Style-only modifications to make checkpatch.pl -f a bit happier.
Fixes warning: "void function return statements are not generally useful"

Signed-off-by: Radek Dostal 
Signed-off-by: Greg Kroah-Hartman

staging/fwserial: (coding style) add blank line after every declaration

2014-06-18T22:25:56+00:00

Style-only modifications to make checkpatch.pl -f a bit happier.
Fixes warning: "Missing a blank line after declarations"

Signed-off-by: Radek Dostal 
Signed-off-by: Greg Kroah-Hartman

drivers/staging: Use RCU_INIT_POINTER(x, NULL) in fwserial/fwserial.c

2014-04-25T21:01:40+00:00

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize.
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

Signed-off-by: Monam Agarwal 
Signed-off-by: Greg Kroah-Hartman

fwserial: (coding style) removing FSF postal address

2014-04-25T21:01:40+00:00

Style-only modifications to make checkpatch.pl --file --strict a bit happier.
Removing FSF postal address from file top comment since it has changed in the
past, as stated by checkpatch.pl.

Signed-off-by: Dominique van den Broeck 
Signed-off-by: Greg Kroah-Hartman

fwserial: (coding style) useless "extern" & space

2014-04-25T21:01:40+00:00

Style-only modifications to make checkpatch.pl --file --strict a bit happier.
Removed useless "extern" in dma_fifo.h ;
Removed one supernumerary space.

Signed-off-by: Dominique van den Broeck 
Signed-off-by: Greg Kroah-Hartman

fwserial: (coding style) if/else bracket matching

2014-04-25T21:01:40+00:00

Style-only modifications to make checkpatch.pl --file --strict a bit happier.
if/else bracket matching (either none or both options should be bracketed).

Signed-off-by: Dominique van den Broeck 
Signed-off-by: Greg Kroah-Hartman

fwserial: (coding style) open parenthesis alignments

2014-04-25T21:01:40+00:00

Style-only modifications to make checkpatch.pl --file --strict a bit happier.
Open parenthesis alignments.

Signed-off-by: Dominique van den Broeck 
Signed-off-by: Greg Kroah-Hartman

staging/fwserial: don't use PREPARE_WORK

2014-03-07T15:24:50+00:00

PREPARE_[DELAYED_]WORK() are being phased out.  They have few users
and a nasty surprise in terms of reentrancy guarantee as workqueue
considers work items to be different if they don't have the same work
function.

fwtty_peer->work is multiplexed with multiple work functions.
Introduce fwserial_peer_workfn() which invokes fwtty_peer->workfn and
always use it as the work function and update the users to set the
->workfn field instead of overriding the work function using
PREPARE_WORK().

It would probably be best to route this with other related updates
through the workqueue tree.

Compile tested.

Signed-off-by: Tejun Heo 
Acked-by: Peter Hurley