linux-stable.git/drivers/staging/fbtft, branch linux-4.6.y

staging: fbtft: fb_uc1611.c: Drop void pointer cast

2016-03-12T06:09:09+00:00

Void pointers need not be cast to other pointer types.
Semantic patch used:

@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x) [...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Signed-off-by: Janani Ravichandran 
Signed-off-by: Greg Kroah-Hartman

staging: fbtft: fb_ra8875.c: Remove unneeded void pointer cast

2016-03-12T06:09:09+00:00

Void pointers need not be cast to other pointer types.
Semantic patch used:

@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x) [...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Signed-off-by: Janani Ravichandran 
Signed-off-by: Greg Kroah-Hartman

staging: fbtft: fbtft-bus.c: Drop unneeded void pointer cast

2016-03-12T06:09:09+00:00

Remove unneeded cast on the void pointer par->txbuf.buf .
Semantic patch used:

@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x) [...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Signed-off-by: Janani Ravichandran 
Signed-off-by: Greg Kroah-Hartman

staging: fbtft: Use devm_kcalloc instead of devm_kzalloc

2016-03-12T06:09:09+00:00

Replace devm_kzalloc with devm_kcalloc to ensure there are no integer
overflows from the multiplication of a number * sizeof

The following Coccinelle semantic patch was used to make this change:
//
@@
expression dev,E1,E2,E3,E4;
@@

- devm_kzalloc(dev,E1*E2*sizeof(E3),E4)
+ devm_kcalloc(dev,E1*E2,sizeof(E3),E4)
//

Signed-off-by: Amitoj Kaur Chawla 
Signed-off-by: Greg Kroah-Hartman

staging: fbtft: Remove unnecessary spi_set_drvdata()

2016-03-12T06:09:09+00:00

Unnecessary spi_set_drvdata() has been removed since the driver
core clears the driver data to NULL after device release or on
probe failure. There is no need to manually clear the device
driver data to NULL.

The Coccinelle semantic patch used to make this change is as follows:
@@
struct spi_device *spi;
@@
- spi_set_drvdata(spi, NULL);
// 

Due to this removal, variable `spi` was unused so dropped `spi`

Signed-off-by: Amitoj Kaur Chawla 
Signed-off-by: Greg Kroah-Hartman

staging: fbtft: replace ternary operator with min macro

2016-03-12T06:09:09+00:00

Use macro min() to get the minimum of two values for
brevity and readability.

Found using Coccinelle:
@@ type T; T x; T y; @@
(
- x < y ? x : y
+ min(x,y)
|
- x > y ? x : y
+ max(x,y)
)

Signed-off-by: Alison Schofield 
Signed-off-by: Greg Kroah-Hartman

staging: fbtft: Use kmalloc_array

2016-03-12T06:09:09+00:00

Use kmalloc_array instead of kmalloc for arrays to prevent integer
overflows.
This was done using Coccinelle:

@@
expression e1, e2;
constant C;
type t;
@@
(
- kmalloc(
+ kmalloc_array(
e2
- *
+ ,
sizeof(e1), C)
|
- kmalloc(
+ kmalloc_array(
e1
- *
+ ,
sizeof(t), C)
|
- kmalloc(
+ kmalloc_array(
- sizeof(e1)
- *
e2
+ ,
+ sizeof(e1)
, C)
|
- kmalloc(
+ kmalloc_array(
- sizeof(t)
- *
e1
+ ,
+ sizeof(t)
, C)
)

Signed-off-by: Bhaktipriya Shridhar 
Signed-off-by: Greg Kroah-Hartman

staging: fbtft: Fix block comment coding style

2016-02-20T23:09:57+00:00

Add the required leading * on subsequent lines as well as
move the */ on a separate line. Checkpatch found this issue.

Signed-off-by: Anchal Jain 
Signed-off-by: Greg Kroah-Hartman

staging: fbtft: Remove the use of CamelCase

2016-02-15T00:22:49+00:00

Rename the macro defining constant ROWxCOL into ROW_X_COL to remove
checkpatch check concerning use of CamelCase and to achieve better
readability.

CHECK: Avoid CamelCase: 

Signed-off-by: Eva Rachel Retuya 
Signed-off-by: Greg Kroah-Hartman

staging: fbtft: Delete blank line after '{' brace

2016-02-15T00:22:49+00:00

Omit the whitespace after '{' brace as suggested by checkpatch.

CHECK: Blank lines aren't necessary after an open brace '{'

Signed-off-by: Eva Rachel Retuya 
Signed-off-by: Greg Kroah-Hartman