linux-stable.git/drivers/staging/et131x, branch linux-3.4.y

staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

2014-09-25T03:49:12+00:00

commit ec0a38bf8b28b036202070cf3ef271e343d9eafc upstream.

Fix two reported bugs, caused by et131x_adapter->phydev->addr being accessed
before it is initialised, by:

- letting et131x_mii_write() take a phydev address, instead of using the one
  stored in adapter by default. This is so et131x_mdio_write() can use it's own
  addr value.
- removing implementation of et131x_mdio_reset(), as it's not needed.
- moving a call to et131x_disable_phy_coma() in et131x_pci_setup(), which uses
  phydev->addr, until after the mdiobus has been registered.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=80751
Link: https://bugzilla.kernel.org/show_bug.cgi?id=77121
Signed-off-by: Mark Einon 
Signed-off-by: Greg Kroah-Hartman 
[lizf: Backported to 3.4:
- adjust context
- update more update more et131x_mii_write() calls in 
  et1310_phy_access_mii_bit() and et131x_xcvr_init()]
Signed-off-by: Zefan Li

Remove all #inclusions of asm/system.h

2012-03-28T17:30:03+00:00

Remove all #inclusions of asm/system.h preparatory to splitting and killing
it.  Performed with the following command:

perl -p -i -e 's!^#\s*include\s*.*\n!!' `grep -Irl '^#\s*include\s*' *`

Signed-off-by: David Howells

Staging: et131x: unify return value of .ndo_set_mac_address if address is invalid

2012-02-24T20:03:13+00:00

Unify return value of .ndo_set_mac_address if the given address
isn't valid. Return -EADDRNOTAVAIL as eth_mac_addr() already does
if is_valid_ether_addr() fails.

Signed-off-by: Danny Kukawka 
Signed-off-by: Greg Kroah-Hartman

drivers:staging:et131x Fix some typo's in staging et131x.

2012-02-24T20:03:11+00:00

The below patch fixes some comments with typos in the them and makes a comment make more sense.

 Signed-off-by: Justin P. Mattock 

Signed-off-by: Greg Kroah-Hartman

staging: et131x: use netif_rx_ni() for packet receive

2012-02-24T19:59:59+00:00

netif_rx is meant to be called from interrupts because it doesn't wake
up ksoftirqd.  For calling from outside interrupts, netif_rx_ni exists.

This stops the error "NOHZ: local_softirq_panding 08" that happens on
some machines with NOHZ and plip --- it is caused by the fact that
softirq is pending and ksoftirqd is sleeping.

Signed-off-by: Mark Einon 
Signed-off-by: Greg Kroah-Hartman

staging: clean up Greg's email address in some TODO files

2012-02-15T22:45:40+00:00

My old email address was in some TODO files, so this fixes that issue.

Signed-off-by: Greg Kroah-Hartman

staging: et131x: Revert changes from previous commit

2011-12-08T23:03:11+00:00

In commit 834d0ee317b (uintxy_t removal) not all changes were trival text replacements, some converted u64 -> dma_addr_t.
In some configurations dma_addr_t is a u32, meaning that some bit operations cause build warnings. From Randy Dunlap:

----------------
on i386 (X86_32) builds:

drivers/staging/et131x/et131x.c:2483:8: warning: right shift count >= width of type
drivers/staging/et131x/et131x.c:2531:8: warning: right shift count >= width of type
----------------

Removed these by reverting dma_addr_t back to u64 types, as well as
reverting some other non-trivial changes from the aforementioned commit.

Reported-by: Randy Dunlap 
Signed-off-by: Mark Einon 
Acked-by: Randy Dunlap 
Signed-off-by: Greg Kroah-Hartman

staging: et131x: Remove section comments

2011-11-27T00:21:24+00:00

Following the move to put the driver into one file, comments were added to identify which source file each set of functions originated from.
These no longer made sense after functions were moved around to remove some forward declarations, so remove them.

A function comment was previously not moved along with its function, now they are reunited.

Signed-off-by: Mark Einon 
Signed-off-by: Greg Kroah-Hartman

et131x: uncloak PCIe capabilities.

2011-11-27T00:21:24+00:00

FIXME: it should be possible to get rid of ET1310_PCI_L0L1LATENCY as well.

Signed-off-by: Francois Romieu 
Acked-by: Mark Einon 
Signed-off-by: Greg Kroah-Hartman

et131x: kiss netdev.{base_addr, irq} goodbye.

2011-11-27T00:21:06+00:00

Signed-off-by: Francois Romieu 
Acked-by: Mark Einon 
Signed-off-by: Greg Kroah-Hartman