linux-stable.git/drivers/staging/dwc2, branch linux-3.12.y

usb: dwc2: hcd: use new USB_RESUME_TIMEOUT

2015-05-04T09:49:59+00:00

commit 74bd7b69801819707713b88e9d0bc074efa2f5e7 upstream.

Make sure we're using the new macro, so our
resume signaling will always pass certification.

Signed-off-by: Felipe Balbi 
Signed-off-by: Jiri Slaby

staging: dwc2: make dwc2_core_params documentation more complete

2013-08-30T21:14:54+00:00

Some of the defaults were missing or unclear. In particular, I suspect
the defaults were documented assuming there were still module parameters
and taking the default module parameters into account. Now, the defaults
are the values that will get chosen when the params passed to
dwc2_hcd_init are all -1.

Signed-off-by: Matthijs Kooijman 
Acked-by: Paul Zimmerman 
Signed-off-by: Greg Kroah-Hartman

staging: dwc2: validate the value for phy_utmi_width

2013-08-30T21:14:53+00:00

The HWCFG4 register stores the supported utmi width values (8, 16 or
both). This commit reads that value and validates the configured value
against that.

If no (valid) value is given, the parameter defaulted to 8 bits
previously.  However, the documentation for dwc2_core_params_struct
suggests that the default should have been 16. Also, the pci bindings
explicitely set the value to 16, so this commit changes the default to
16 bits (if supported, 8 bits otherwise).

With the default changed, the value set in pci.c is changed to -1 to
make it autodetected as well.

Signed-off-by: Matthijs Kooijman 
Acked-by: Paul Zimmerman 
Signed-off-by: Greg Kroah-Hartman

staging: dwc2: interpret all hwcfg and related register at init time

2013-08-30T21:14:53+00:00

Before, the hwcfg registers were read at device init time, but
interpreted at various parts in the code. This commit unpacks the hwcfg
register values into a struct with properly labeled variables at init
time, which makes all the other code using these values more consise and
easier to read. Some values that were previously stored in the hsotg
struct are now moved into this new struct as well.

In addition to the hwcfg registers, the contents of some fifo size
registers are also unpacked. The hwcfg registers are read-only, so they
can be safely stored. The fifo size registers are read-write registers,
but their power-on values are significant: they give the maximum depth
of the fifo they describe.

This commit mostly moves code, but also attempts to simplify some
expressions from (val >> shift) & (mask >> shift) to
(val & mask) >> shift.

Finally, all of the parameters read from the hardware are debug printed
after unpacking them, so a bunch of debug prints can be removed from
other places.

Signed-off-by: Matthijs Kooijman 
Acked-by: Paul Zimmerman 
Signed-off-by: Greg Kroah-Hartman

staging: dwc2: properly mask the GRXFSIZ register

2013-08-30T21:14:53+00:00

Bits 16-31 are reserved, so the old code just reads the whole register to
get bits 0-15, assuming the reserved bits would be 0 (which seems true
on current hardware, but who knows...).

This commit properly masks out the reserved bits when reading and
doesn't touch the reserved bits while writing.

Signed-off-by: Matthijs Kooijman 
Acked-by: Paul Zimmerman 
Signed-off-by: Greg Kroah-Hartman

staging: dwc2: remove redundant register reads

2013-08-30T21:14:53+00:00

For calculating FIFO offsets, the sizes of preceding fifos need to be
known. For filling the GDFIFOCFG register, these fifo sizes were read
from hardware registers. However, these values were written to these
registers just a few lines before, so we can just use the values written
instead.

Signed-off-by: Matthijs Kooijman 
Acked-by: Paul Zimmerman 
Signed-off-by: Greg Kroah-Hartman

staging: dwc2: re-use hptxfsiz variable

2013-08-30T21:14:53+00:00

For some reason, the value of the HPTXFSIZ register was built in the
ptxfsiz variable, while there was also a hptxfsiz variable availble.
Better just use that and remove the (now unused) ptxfsiz variable.

Signed-off-by: Matthijs Kooijman 
Acked-by: Paul Zimmerman 
Signed-off-by: Greg Kroah-Hartman

staging: dwc2: simplify debug output in dwc_hc_init

2013-08-30T21:14:53+00:00

The value of the hcchar register is built from individual values by
shifting and masking. Before, the debug output extracted the individual
values out of the complete hcchar register again by doing the reverse.
This commit makes the debug output use the original values instead.

One debug message got removed, since it would always print a fixed value
of zero.

Signed-off-by: Matthijs Kooijman 
Acked-by: Paul Zimmerman 
Signed-off-by: Greg Kroah-Hartman

staging: dwc2: add missing shift

2013-08-30T21:14:52+00:00

This line extracted the available queue space without properly shifting
it. Since the code only cared wether it was zero or not, it worked as
expected without the shift, but adding shift makes the code cleaner.

While we're here, store the result in a helper variable that was already
declared to increase readability a bit more.

Signed-off-by: Matthijs Kooijman 
Acked-by: Paul Zimmerman 
Signed-off-by: Greg Kroah-Hartman

staging: dwc2: simplify register shift expressions

2013-08-30T21:14:52+00:00

This commit changes expressions from (val >> shift) & (mask >> shift) to
(val & mask) >> shift.

Signed-off-by: Matthijs Kooijman 
Acked-by: Paul Zimmerman 
Signed-off-by: Greg Kroah-Hartman